From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CF11E695D for ; Tue, 28 Mar 2017 10:16:38 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 28 Mar 2017 01:16:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="80080401" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga005.jf.intel.com with SMTP; 28 Mar 2017 01:16:35 -0700 Received: by (sSMTP sendmail emulation); Tue, 28 Mar 2017 09:16:35 +0100 Date: Tue, 28 Mar 2017 09:16:34 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com Message-ID: <20170328081634.GA20844@bricha3-MOBL3.ger.corp.intel.com> References: <20170307113217.11077-1-bruce.richardson@intel.com> <20170324171008.29355-1-bruce.richardson@intel.com> <20170324171008.29355-9-bruce.richardson@intel.com> <1777203.ud4AFtxiB3@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1777203.ud4AFtxiB3@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v3 08/14] ring: allow enqueue fns to return free space value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 08:16:39 -0000 On Tue, Mar 28, 2017 at 09:12:39AM +0200, Thomas Monjalon wrote: > 2017-03-24 17:10, Bruce Richardson: > > Add an extra parameter to the ring enqueue burst/bulk functions so that > > those functions can optionally return the amount of free space in the > > ring. This information can be used by applications in a number of ways, > > for instance, with single-producer queues, it provides a max > > enqueue size which is guaranteed to work. It can also be used to > > implement watermark functionality in apps, replacing the older > > functionality with a more flexible version, which enables apps to > > implement multiple watermark thresholds, rather than just one. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Olivier Matz > > > There is a an error with this patch and crypto drivers: > > > drivers/crypto/kasumi/rte_kasumi_pmd.c:362:32: fatal error: > too few arguments to function call, expected 4, have 3 > (void **)ops, processed_ops); > ^ > rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here > > > drivers/crypto/snow3g/rte_snow3g_pmd.c:366:31: fatal error: > too few arguments to function call, expected 4, have 3 > (void **)ops, processed_ops); > ^ > rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here > Yes, I'm still working through this patchset with crypto drivers enabled myself. Patch 9 also has issues with some of the other drivers - though I don't have this kasumi one enabled on my system myself. I'll need to do a v4, hopefully today. Sorry for not flagging this sooner, I didn't know you were going to try again to apply the set, so I thought I had more time to report the results of testing with the crypto drivers. /Bruce