DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] pci: default to whitelist mode
Date: Tue, 28 Mar 2017 13:20:00 +0100	[thread overview]
Message-ID: <20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com>

On Tue, Mar 28, 2017 at 02:01:29PM +0200, Gaetan Rivet wrote:
> Expects all devices to be explicitly defined before being probed.
> 
> The blacklist mode can be prone to errors, coaxing users in capturing
> devices that could be used for management or otherwise.
> The whitelist mode offers users more control and highlight mistakes by
> making them visible on the command line.
> 
> This is more useful to have a clear idea of the state of the system used,
> which is better in the context of standalone / headless applications.
> 
> Using the -b option will revert to the original behavior.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> v2: justify this default behavior evolution.
> ---

I don't have major objections to this patch, though it does make it
mandatory to use port parameters where before it was not. The one
suggestion I will make is that, if we take this approach, we should
probably add a --wl-all (whitelist-all) flag to go back to having all
ports automatically bound, if so desired.

/Bruce

  reply	other threads:[~2017-03-28 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 11:51 [dpdk-dev] [PATCH " Gaetan Rivet
2017-03-28 11:58 ` Bruce Richardson
2017-03-28 12:05   ` Gaëtan Rivet
2017-03-28 12:01 ` [dpdk-dev] [PATCH v2 " Gaetan Rivet
2017-03-28 12:20   ` Bruce Richardson [this message]
2017-03-28 12:44     ` Gaëtan Rivet
2017-03-28 13:02       ` Van Haaren, Harry
2017-03-28 13:53         ` Gaëtan Rivet
2017-03-30 19:36         ` Thomas Monjalon
2017-03-28 13:03       ` Bruce Richardson
2017-03-28 13:35         ` Gaëtan Rivet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).