From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 51725D208 for ; Tue, 28 Mar 2017 14:20:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490703604; x=1522239604; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7D7gvmMl4f/qeTwF2V7LKLE/HXH2BxnG7+GFqTuINoI=; b=EhWAUUd1pWwLph9UgtMWmlhFv8n+Se/3CB51fgSoFJu/8VgsUwP1U+T+ TWzgmJn9lTd4t548CiLCD3cAcmhCiw==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 05:20:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="1128019148" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by fmsmga001.fm.intel.com with SMTP; 28 Mar 2017 05:20:01 -0700 Received: by (sSMTP sendmail emulation); Tue, 28 Mar 2017 13:20:00 +0100 Date: Tue, 28 Mar 2017 13:20:00 +0100 From: Bruce Richardson To: Gaetan Rivet Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com> References: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com> <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v2 1/1] pci: default to whitelist mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 12:20:04 -0000 On Tue, Mar 28, 2017 at 02:01:29PM +0200, Gaetan Rivet wrote: > Expects all devices to be explicitly defined before being probed. > > The blacklist mode can be prone to errors, coaxing users in capturing > devices that could be used for management or otherwise. > The whitelist mode offers users more control and highlight mistakes by > making them visible on the command line. > > This is more useful to have a clear idea of the state of the system used, > which is better in the context of standalone / headless applications. > > Using the -b option will revert to the original behavior. > > Signed-off-by: Gaetan Rivet > --- > v2: justify this default behavior evolution. > --- I don't have major objections to this patch, though it does make it mandatory to use port parameters where before it was not. The one suggestion I will make is that, if we take this approach, we should probably add a --wl-all (whitelist-all) flag to go back to having all ports automatically bound, if so desired. /Bruce