From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 71F0736E for ; Tue, 28 Mar 2017 14:44:19 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id w43so89083665wrb.0 for ; Tue, 28 Mar 2017 05:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=EUld79d9186dkJlc0y7VNf1XzowjbgyEyt0UtQ2qFkQ=; b=m3cSKmRlUvxF8WFFhw5hKAMVe4AlhNN6qJoIQfLprCxIGxIpxMFsFlfqNj7+QZSYg9 lhdLBZRxHMcLqGSG9k86Buq1lOZGF9wtuY402kBzeS45RzIjVylGPBYiZSj5KuAhL3X6 EFdR4Hh+1Y2QfVyKfpvilLLUUNpx6f5YyCAMpRGInpK8XVRy/OQ5RMbGY3CgE6gP9R3n h15hwoLFn/QVOvdPXHLqDuQJgc25L4E3NTj60OLL+bnw74TfgEmWZokz5k/WY0G+VX1u Rp2qZPT46B6czotkTo4DeAYR0Fd5L3xR8juycE9vzhoMjtdKPywRPgYGiMdhSI7CpGPd uFNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EUld79d9186dkJlc0y7VNf1XzowjbgyEyt0UtQ2qFkQ=; b=TvBekrnRFbPjHl0hVMVAeG7nSnMPoYNlCDnCojG5NkRVBDjd+WHw60zQ5YeL0Qpvml ABJQ5IQKl6K2fQaZ87uHuNqqs5i9x1K59+7KTLwqXUxygwFF6VqEGX+CUl799x4N/jmF YeM4LSoqiVHINo5hkwEQEW9DInGrDZ1DtyALyHqFqneOtEKrS9rzwdo5oaa3BL5PqpOs AxEQ5SZW5WDXtb7875Uc6aE5yQZK39Uxl8lgO721HBCKxsuW6mpMF7g/gxa3Y8SbAyoo CloPD7IWb5Lj17Gq4Ab3DhWAISaFwhHrdtrsQ2Fu0SnNcu3MEKMm82/kP9m35JgYL/gC WVfQ== X-Gm-Message-State: AFeK/H3wiJdtpK7bVGjHgb4lSuwxBvPhN+cY7EsIdIJdM2VEM5HSYIVVfoQ3VMacejBnqQ8L X-Received: by 10.28.131.65 with SMTP id f62mr14443208wmd.4.1490705058784; Tue, 28 Mar 2017 05:44:18 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v108sm4732235wrc.41.2017.03.28.05.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 05:44:17 -0700 (PDT) Date: Tue, 28 Mar 2017 14:44:09 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20170328124409.GC7450@bidouze.vm.6wind.com> References: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com> <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> <20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 1/1] pci: default to whitelist mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 12:44:19 -0000 On Tue, Mar 28, 2017 at 01:20:00PM +0100, Bruce Richardson wrote: >On Tue, Mar 28, 2017 at 02:01:29PM +0200, Gaetan Rivet wrote: >> Expects all devices to be explicitly defined before being probed. >> >> The blacklist mode can be prone to errors, coaxing users in capturing >> devices that could be used for management or otherwise. >> The whitelist mode offers users more control and highlight mistakes by >> making them visible on the command line. >> >> This is more useful to have a clear idea of the state of the system used, >> which is better in the context of standalone / headless applications. >> >> Using the -b option will revert to the original behavior. >> >> Signed-off-by: Gaetan Rivet >> --- >> v2: justify this default behavior evolution. >> --- > >I don't have major objections to this patch, though it does make it >mandatory to use port parameters where before it was not. The one >suggestion I will make is that, if we take this approach, we should >probably add a --wl-all (whitelist-all) flag to go back to having all >ports automatically bound, if so desired. > Are there use cases where the blacklist mode would be used without blacklisting any device? The current -b option is almost enough for the same level of functionality. If there is an actual need to a full PCI probe, adding this option is certainly possible. I was thinking otherwise of allowing "all" as an argument to -w, which would have our users using -wall or -w=all, which seems clear enough. This would essentially be the inverse of the --no-pci parameter. Which could probably be removed if this patch is accepted. -- Gaëtan Rivet 6WIND