From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DEC082C55 for ; Wed, 29 Mar 2017 08:35:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490769323; x=1522305323; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BlDv09iBJMDpTn6aPnocdDPVolm1a0967PHh3LkE6JA=; b=k9HLdZ8EddOm1HIVLmhLy8A54/q+KHCoRrl+XhO18DaZ1Jc4tXbSYTjq 21SG/Ihoojb4LVb0G2+1FEQp3cz6mg==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 23:35:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="71505057" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga004.jf.intel.com with ESMTP; 28 Mar 2017 23:35:16 -0700 Date: Wed, 29 Mar 2017 14:33:01 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: "dev@dpdk.org" , "david.marchand@6wind.com" Message-ID: <20170329063301.GE18844@yliu-dev.sh.intel.com> References: <1488563803-87754-1-git-send-email-jianfeng.tan@intel.com> <1488563803-87754-4-git-send-email-jianfeng.tan@intel.com> <20170317065445.GH18844@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/5] net/virtio-user: support to report net status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 06:35:23 -0000 On Mon, Mar 27, 2017 at 07:46:32AM +0000, Tan, Jianfeng wrote: > > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c > > b/drivers/net/virtio/virtio_user/virtio_user_dev.c > > > index 9777d6b..cc6f557 100644 > > > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > > > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > > > @@ -176,6 +176,7 @@ virtio_user_start_device(struct virtio_user_dev > > *dev, uint8_t portid) > > > features &= ~(1ull << VIRTIO_NET_F_MAC); > > > /* Strip VIRTIO_NET_F_CTRL_VQ, as devices do not really need to > > know */ > > > features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); > > > + features &= ~(1ull << VIRTIO_NET_F_STATUS); > > > ret = dev->ops->send_request(dev, VHOST_USER_SET_FEATURES, > > &features); > > > if (ret < 0) > > > goto error; > > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > > b/drivers/net/virtio/virtio_user_ethdev.c > > > index fa79419..fbdd0a8 100644 > > > --- a/drivers/net/virtio/virtio_user_ethdev.c > > > +++ b/drivers/net/virtio/virtio_user_ethdev.c > > > @@ -121,7 +121,8 @@ virtio_user_get_features(struct virtio_hw *hw) > > > struct virtio_user_dev *dev = virtio_user_get_dev(hw); > > > > > > /* unmask feature bits defined in vhost user protocol */ > > > - return dev->device_features & > > VIRTIO_PMD_SUPPORTED_GUEST_FEATURES; > > > + return (dev->device_features | (1 << VIRTIO_NET_F_STATUS)) > > > + & VIRTIO_PMD_SUPPORTED_GUEST_FEATURES; > > > > Why not handle the features at virtio_user_dev_init()? > > You mean add VIRTIO_NET_F_STATUS when get_features from device? Yes, we could do that there. But we originally add device_features to only record features supported by device. > Aren't you adding the F_STATUS features to this device? --yliu