From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 590ED37B4 for <dev@dpdk.org>; Wed, 29 Mar 2017 12:08:11 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id k6so1184808wre.2 for <dev@dpdk.org>; Wed, 29 Mar 2017 03:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C6aD50RtkMtE+WLVRW1BD0egbiy95+Jnwasw9XFXznc=; b=PbCMkwXQy1nX1LYxy6BnFXoDRITqJuVEwPWW3JO7+UhdN+z6NJT7/1+f0y5On6YZ8V n5TRIUTkCpnGhlxr3cC6fIFmyYOLpEzxuHCrJL6WHRKTDx5aye543oaBygnEBWIpVCct 0ZJPR3JzVJX+vn8XDTp1lkM5jkx1FUQJBkLUNiR0D3bQiECkhpNtC358A+TH9+nxSeh6 SvCD97cacgLk+qeCb58mFTj9HAHqBd4v0Iqsr/ygqOQUXRiB87uppQbeGMXqzsJ1AHa7 MWlzSNjH5JmPOMmudmrep8a3B4ad6tqQAZBd7WEl2ytNWJsDubwwYKQn8deUyjL0P1Ym Oaww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C6aD50RtkMtE+WLVRW1BD0egbiy95+Jnwasw9XFXznc=; b=LPPXMifb1rHOweT150KvQ5fOiUIiIQyImqCeBUCCzTMX+9xp1E6Db39KvqJhiXg2aS kLvRVQ5SnMQ1ok7Ez8R6VDkumPftZzSQ3fRFaOvtNgOA5fKUAMdZgJAyMuabQIT0H/qr /H7/qq+f7IKakH2c8Hnp1BU/L35DEWPoV3Ot9iD7DL+aKD90Xh4ue+fq7aq09UQhy3Sc xNMJQVIoUW1eAUJrm96lyO9j0JPT5vOqPEbYZuj/4IlHoS2moMIvJG0nL/0E0HHMLrFV 7x9bK8833cL1U/zoLQipD9W11VXMGpkcCPb3BlgLr8EuE4RZnxruZ0g6NxTI3G4VTHFh r4ng== X-Gm-Message-State: AFeK/H3hkF2+X4tmEUnoGXEF31mPd5WHEgHtjQGwSQs5LweL1X4VtE8kkSHPkYbGhNGiP8LW X-Received: by 10.28.13.69 with SMTP id 66mr498056wmn.137.1490782090998; Wed, 29 Mar 2017 03:08:10 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 32sm8723919wrr.64.2017.03.29.03.08.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Mar 2017 03:08:10 -0700 (PDT) Date: Wed, 29 Mar 2017 12:08:08 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: "Dai, Wei" <wei.dai@intel.com> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Guo Fengtian" <fengtian.guo@6wind.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Message-ID: <20170329120808.0907926a@platinum> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A23126@PGSMSX101.gar.corp.intel.com> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170314104640.32b06adb@platinum> <20170324151148.5c3d9f9d@platinum> <1981763.1ss0qQn5ig@xps13> <49759EB36A64CF4892C1AFEC9231E8D650A23126@PGSMSX101.gar.corp.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 29 Mar 2017 10:08:11 -0000 Hi Wei, On Wed, 29 Mar 2017 09:22:55 +0000, "Dai, Wei" <wei.dai@intel.com> wrote: > First of all, I don't agree the method in this patch because the register can also rewind to 0 in normal mode except > reset/PF down. > > In the function void ixgbe_down(struct ixgbe_adapter *adapter) of ixgbe_main.c in the ixgbe kernel PF driver (version 5.0.4), > the PF in kernel driver will ping all the active vfs to let them know PF is going down by mailbox messages. > > On other side, ixgbe VF in DPDK PMD will handle the ping mailbox message in ixgbevf_dev_interrupt_handler( ) which is > registered interrupt routine. > And ixgbevf_dev_interrupt_handler( ) will call ixgbevf_mbx_process( ) to process mailbox message from PF. > > So it is in ixgbevf_mbx_process( ) where the SW stats registers of VF can be fixed. > There is more than one line to send ping message to VF in kernel PF drvier codes. Thank you for the explanation. Just to be sure I correctly understand: 1- the ping message is properly sent by ixgbe pf linux driver 2- the ping message is not yet sent by ixgbe pf dpdk driver 3- the ping message is properly received by ixgbe vf dpdk driver, but it is not used yet to stop wrong stats accumulation > I am studying it to make it clear how to identify the ping message due to PF down. Are you saying that you are currently working on a fix for 2 and 3 (that would be great!) or are you expecting that I work on it? In any case, I can help, at least to test the patches. > So can we defer this patch first. > And another patch in above way should be submitted. I'm of course ok to defer the initial patch, I agree it's more a workaround than a proper solution. I was stuck because I did not know how the VF is notified by the PF when it is reset. Thanks Olivier