* [dpdk-dev] bug in LPM handling (16.04+) @ 2017-03-29 12:25 László Molnár 2017-03-29 12:38 ` László Molnár 0 siblings, 1 reply; 3+ messages in thread From: László Molnár @ 2017-03-29 12:25 UTC (permalink / raw) To: dev Hi, While testing the LPM implementation of DPDK (16.04+), I found that in some cases prefixes are not added correctly to the table. This problem seems to be caused by incorrect casts. See attached patch. L ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] bug in LPM handling (16.04+) 2017-03-29 12:25 [dpdk-dev] bug in LPM handling (16.04+) László Molnár @ 2017-03-29 12:38 ` László Molnár 2017-03-29 14:41 ` Bruce Richardson 0 siblings, 1 reply; 3+ messages in thread From: László Molnár @ 2017-03-29 12:38 UTC (permalink / raw) To: dev --- rte_lpm.c~3 2017-03-29 12:19:06.146933973 +0200 +++ rte_lpm.c 2017-03-29 12:19:06.000000000 +0200 @@ -1034,7 +1034,7 @@ */ struct rte_lpm_tbl_entry new_tbl24_entry = { - .group_idx = (uint8_t)tbl8_group_index, + .group_idx = tbl8_group_index, .valid = VALID, .valid_group = 1, .depth = 0, @@ -1080,7 +1080,7 @@ */ struct rte_lpm_tbl_entry new_tbl24_entry = { - .group_idx = (uint8_t)tbl8_group_index, + .group_idx = tbl8_group_index, .valid = VALID, .valid_group = 1, .depth = 0, ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] bug in LPM handling (16.04+) 2017-03-29 12:38 ` László Molnár @ 2017-03-29 14:41 ` Bruce Richardson 0 siblings, 0 replies; 3+ messages in thread From: Bruce Richardson @ 2017-03-29 14:41 UTC (permalink / raw) To: László Molnár; +Cc: dev On Wed, Mar 29, 2017 at 02:38:13PM +0200, László Molnár wrote: > --- rte_lpm.c~3 2017-03-29 12:19:06.146933973 +0200 > +++ rte_lpm.c 2017-03-29 12:19:06.000000000 +0200 > @@ -1034,7 +1034,7 @@ > */ > > struct rte_lpm_tbl_entry new_tbl24_entry = { > - .group_idx = (uint8_t)tbl8_group_index, > + .group_idx = tbl8_group_index, > .valid = VALID, > .valid_group = 1, > .depth = 0, > @@ -1080,7 +1080,7 @@ > */ > > struct rte_lpm_tbl_entry new_tbl24_entry = { > - .group_idx = (uint8_t)tbl8_group_index, > + .group_idx = tbl8_group_index, > .valid = VALID, > .valid_group = 1, > .depth = 0, > Hi, this fix looks reasonable. Can you perhaps resend as a proper patch with signoff, as described in contributors guide doc? See: http://dpdk.org/doc/guides/contributing/patches.html#make-your-changes Thanks, /Bruce ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-29 14:41 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-29 12:25 [dpdk-dev] bug in LPM handling (16.04+) László Molnár 2017-03-29 12:38 ` László Molnár 2017-03-29 14:41 ` Bruce Richardson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).