From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EEEFA377E for ; Wed, 29 Mar 2017 16:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490798482; x=1522334482; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5avpeoslQ3qrBbQmtCBuQEKJtdckYWKGljB9mej1mEA=; b=AI9t1SdQLW/rGn9kh6sS112s2QZ+yZYItFaSPQCxW28TFM8Tw32LBP0z hfn6GYz5zMLVvUswvTcRZjK0izSPEg==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 07:41:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,241,1486454400"; d="scan'208";a="80601536" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga005.jf.intel.com with SMTP; 29 Mar 2017 07:41:19 -0700 Received: by (sSMTP sendmail emulation); Wed, 29 Mar 2017 15:41:18 +0100 Date: Wed, 29 Mar 2017 15:41:18 +0100 From: Bruce Richardson To: =?iso-8859-1?Q?L=E1szl=F3_Moln=E1r?= Cc: dev@dpdk.org Message-ID: <20170329144117.GA10824@bricha3-MOBL3.ger.corp.intel.com> References: <20170329122534.GO2871@elxafv3bk32> <20170329123813.GP2871@elxafv3bk32> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170329123813.GP2871@elxafv3bk32> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] bug in LPM handling (16.04+) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 14:41:22 -0000 On Wed, Mar 29, 2017 at 02:38:13PM +0200, László Molnár wrote: > --- rte_lpm.c~3 2017-03-29 12:19:06.146933973 +0200 > +++ rte_lpm.c 2017-03-29 12:19:06.000000000 +0200 > @@ -1034,7 +1034,7 @@ > */ > > struct rte_lpm_tbl_entry new_tbl24_entry = { > - .group_idx = (uint8_t)tbl8_group_index, > + .group_idx = tbl8_group_index, > .valid = VALID, > .valid_group = 1, > .depth = 0, > @@ -1080,7 +1080,7 @@ > */ > > struct rte_lpm_tbl_entry new_tbl24_entry = { > - .group_idx = (uint8_t)tbl8_group_index, > + .group_idx = tbl8_group_index, > .valid = VALID, > .valid_group = 1, > .depth = 0, > Hi, this fix looks reasonable. Can you perhaps resend as a proper patch with signoff, as described in contributors guide doc? See: http://dpdk.org/doc/guides/contributing/patches.html#make-your-changes Thanks, /Bruce