From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 3751510BA9 for ; Thu, 30 Mar 2017 10:51:52 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id w11so49369447wrc.3 for ; Thu, 30 Mar 2017 01:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tCJUyB6hgd6rThMaSJ0k3BQyQUxUQrNDhoVpK56cw3I=; b=V3zGHxhJ3mZtFf1EXVaTK79qPGIfstvs7TUO5eSXxix95181+vKLUOB2OgA5Z/r0pi 4YjL2UrIk09XTOG3dvOsJ7V2khQYpJS9638vzLqk7SzI0+SHe+C8ltf22DE3Ne/pxjX5 6d66IzzaVHxMbE514N0kfsuVFgkRC3E003o+eI4dm8bDxhU4POm8ZNNfYJEEtQcKufYq k81RrQnb5IH2MAuSRlGAJhDnILddBiGmnYhgusrrWSsnWEXoHBxOCRuWbFFmoNQ3gXBN +h2DS80o7ANhmxSGqCNOoa8TwTM6p4Fut2B831DIofBHsw31R87nxikvD9nF6pTaaAtu Hu1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tCJUyB6hgd6rThMaSJ0k3BQyQUxUQrNDhoVpK56cw3I=; b=Igg7OHwUHkC/fCmZHTryF0NkjCx55gfLc0zPwzgxeGSvg5xV3T0tfbAFNxvYt0oSXT 2GW1kb4GTcZR0curknGUeRXw+ZV2I2wGy3O0gMwjeJNmBWRDpXLn00QqztAQKQYxran4 avddSO++vsOwgMWO335BushfAi+eWF1+/+SZ/McYJ7CxhT6euK2M2aWGslWg3CegDZ1G fNlZJFtouOSN9UzEOmctEQycwrbcx/59nBykS+E0lFbMOfzeDRlBh1ZlVbttHkN7EXfd TSbBJIn+YLTByXe0LyyGqpRSh9g6gPFsWBaobJG92NgCWNLLim8+hL3kShy3FvBmTzQg fljA== X-Gm-Message-State: AFeK/H2mXwkuQHCNXnoEMwyNKvqO2OJm/Vwwn+nZ34YMzu+FcPHj90891N/KIbS1JyAUFxKn X-Received: by 10.28.113.12 with SMTP id m12mr2391151wmc.18.1490863911716; Thu, 30 Mar 2017 01:51:51 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id z79sm1927846wrc.2.2017.03.30.01.51.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Mar 2017 01:51:51 -0700 (PDT) Date: Thu, 30 Mar 2017 10:51:48 +0200 From: Olivier Matz To: Ferruh Yigit Cc: dev@dpdk.org, thomas.monjalon@6wind.com, robin.jarry@6wind.com, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com Message-ID: <20170330105148.2d8db736@platinum> In-Reply-To: <2c512b48-b791-7072-1b73-3ee07fd11a22@intel.com> References: <1489770822-27539-1-git-send-email-olivier.matz@6wind.com> <20170324132131.2187-1-olivier.matz@6wind.com> <2c512b48-b791-7072-1b73-3ee07fd11a22@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mk: optimize directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 08:51:52 -0000 Hi Ferruh, On Tue, 28 Mar 2017 11:34:35 +0100, Ferruh Yigit wrote: > On 3/24/2017 1:21 PM, Olivier Matz wrote: > > Before this patch, the management of dependencies between directories > > had several issues: > > > > - the generation of .depdirs, done at configuration is slow: it can take > > more than one minute on some slow targets (usually ~10s on a standard > > PC without -j). > > > > - for instance, it is possible to express a dependency like: > > - app/foo depends on lib/librte_foo > > - and lib/librte_foo depends on app/bar > > But this won't work because the directories are traversed with a > > depth-first algorithm, so we have to choose between doing 'app' before > > or after 'lib'. > > > > - the script depdirs-rule.sh is too complex. > > > > - we cannot use "make -d" for debug, because the output of make is used for > > the generation of .depdirs. > > > > This patch moves the DEPDIRS-* variables in the upper Makefile, making > > the dependencies much easier to calculate. A DEPDIRS variable is still > > used to process library dependencies in LDLIBS. > > > > After this commit, "make config" is almost immediate. > > > > Signed-off-by: Olivier Matz > > Tested-by: Robin Jarry > > Tested-by: Jerin Jacob > > <...> > > > DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port > > +DEPDIRS-librte_port := librte_eal librte_mbuf librte_mempool librte_ether > > +DEPDIRS-librte_port += librte_ip_frag librte_sched librte_kni > ^ > ---------------------------------------------------------+ > > <...> > > > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile > > index 44fa73520..76629a13a 100644 > > --- a/lib/librte_port/Makefile > > +++ b/lib/librte_port/Makefile > <...> > > -ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > > -DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_kni > > -endif > > This check needs to be reflected to new method, otherwise causing build > errors for i686 target. > Did you notice an error? I see no error it with: make config T=x86_64-native-linuxapp-gcc sed -i 's,CONFIG_RTE_LIBRTE_KNI=y,# CONFIG_RTE_LIBRTE_KNI is not set,' build/.config make -j8 I think it is not a problem, the DEPDIRS-* variable only gives an ordering directive, which should be ok even if kni is not compiled. Regards, Olivier