From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 260EF100F for ; Thu, 30 Mar 2017 17:30:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490887809; x=1522423809; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qSrW7bdsRfYDZiuPl+U+gPWamJG1G7v41TbBoXrtqko=; b=jJ7OCaQKSml6NrUQwtrhhswcDuqcM2UX3RooK1y4a8AY8DfkwMWY1Byc n+bN2363GJxguFkweA5B+TZoddOj8g==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 08:30:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="1148876808" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by fmsmga002.fm.intel.com with SMTP; 30 Mar 2017 08:30:04 -0700 Received: by (sSMTP sendmail emulation); Thu, 30 Mar 2017 16:30:03 +0100 Date: Thu, 30 Mar 2017 16:30:03 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Message-ID: <20170330153003.GA14552@bricha3-MOBL3.ger.corp.intel.com> References: <20170329140419.27149-1-bruce.richardson@intel.com> <20170329163856.10932-1-bruce.richardson@intel.com> <20170329163856.10932-4-bruce.richardson@intel.com> <1632639.Ait0E45soG@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1632639.Ait0E45soG@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 15:30:09 -0000 On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote: > 2017-03-29 17:38, Bruce Richardson: > > Since performance-thread example app is now built as part of make examples > > we don't need a special case line for it in testbuild.sh script > [...] > > --- a/devtools/test-build.sh > > +++ b/devtools/test-build.sh > > @@ -237,9 +237,6 @@ for conf in $configs ; do > > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > O=$(readlink -m $dir/examples) > > ! echo $target | grep -q '^x86_64' || \ > > - make -j$J -sC examples/performance-thread \ > > - EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > - O=$(readlink -m $dir/examples/performance-thread) > > You are missing the x86_64 check. That's in the makefile in the first patch > > This patch should be squashed with the first one. > Sure. Doesn't matter to me! /Bruce