From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id C016D2B92
 for <dev@dpdk.org>; Thu, 30 Mar 2017 17:33:26 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga104.jf.intel.com with ESMTP; 30 Mar 2017 08:33:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="1148878310"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140])
 by fmsmga002.fm.intel.com with SMTP; 30 Mar 2017 08:33:23 -0700
Received: by  (sSMTP sendmail emulation); Thu, 30 Mar 2017 16:33:22 +0100
Date: Thu, 30 Mar 2017 16:33:22 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
Message-ID: <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com>
References: <20170329140419.27149-1-bruce.richardson@intel.com>
 <20170329163856.10932-1-bruce.richardson@intel.com>
 <20170329163856.10932-5-bruce.richardson@intel.com>
 <1851186.Q5rVaVkRzi@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1851186.Q5rVaVkRzi@xps13>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.8.0 (2017-02-23)
Subject: Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build
	script
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 15:33:27 -0000

On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
> 2017-03-29 17:38, Bruce Richardson:
> > Since the test app is no longer being build by default as part of a build,
> > we need to update the testbuild script to take account of this.
> [...]
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -229,6 +229,9 @@ for conf in $configs ; do
> >  	echo "================== Build $dir"
> >  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > +	echo "================== Build tests for $dir"
> > +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> >  	! $short || break
> >  	echo "================== Build examples for $dir"
> >  	export RTE_SDK=$(pwd)
> 
> It should be added after the "short break".
> 
You have no idea how many times in preparing the patchset I moved the
addition above the break, and then back below it, and above it again!
You pick what you think is best. :-)

> The test-build target rebuild all.
It rebuilds the libs, but not the apps, which is why we can't just
use test-build target, or we will skip testpmd.

> I think it should be standard apps like the examples
> and not re-link the libs before building.
> The other way is to merge it with the above command (default build).

I tried merging the two into a single command, i.e. "make all
test-build" but that failed with parallel builds because the two jobs
try and build some things at the same time and interfere with each
other. [The kernel drivers seemed to be the main problem]

/Bruce