From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0081.outbound.protection.outlook.com [104.47.33.81]) by dpdk.org (Postfix) with ESMTP id 299E2377E for ; Thu, 30 Mar 2017 19:11:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Z0EkgAqTcawgxWp7cmwiga5Y0ZUIbg4wESiofs0HJqU=; b=eXQTrDnnqQAD09IlfSOySClbYSnjFXpHIIUAuwjniiUpsF0AHAkotYf/nBpc0RAMI7GmJmUNPsSAGAmuB5dzGl38J9HntermEuAcNoIIMbA6Kq2nae7yiL5oKP/GuYpDpS15FCY7gFnEYIy8cATN7Dj+oraVLc5Oy4aIeNtzanI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by CY1PR0701MB1725.namprd07.prod.outlook.com (10.163.21.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Thu, 30 Mar 2017 17:11:47 +0000 Date: Thu, 30 Mar 2017 22:41:33 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170330171132.kbwpsnukw5sr5frg@localhost.localdomain> References: <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com> <1490829963-106807-1-git-send-email-harry.van.haaren@intel.com> <1490829963-106807-2-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490829963-106807-2-git-send-email-harry.van.haaren@intel.com> User-Agent: NeoMutt/20170306 (1.8.0) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0080.INDPRD01.PROD.OUTLOOK.COM (10.174.208.148) To CY1PR0701MB1725.namprd07.prod.outlook.com (10.163.21.14) X-MS-Office365-Filtering-Correlation-Id: 285fe234-ddbe-478d-5dc6-08d4778fd9ef X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CY1PR0701MB1725; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 3:zy7Zk/jj7pBHGx7isYzWWx6N446A5D9EEQZMl9blcgARYD8V2ikMGvGOn2yLiJMICAH5+VgCON87342vr207ZUYcUXerlZYxkAZKqmVnPsNyLfDe0N6nTLuxDDp5PnplzvsEXWpHHov05dhRJb/Q8PGyNuldLhwpbq8iayyGTbhy1DLuml1uFyeWnfkQm55vmP0ithGZY0ZTufDA2N9RC2lh+vF/YZQ2xsYmacseTVXAisBEjwu8QaiL7pM6Nqgqx8Qs7ljU2eO0IIpIUcuxIg2NPhFrMU3V5oU5b15cKUoKReyfart1tE4aReKm813z1ID2+BCivrSRnYZTl08nAA==; 25:WoNLTTZCcPveZr/Nu50mQmHfnQ4V6dqnA2n+KuXKceUy+2GLGL7uGJ8i8ppxgdyyRODetbRNRkm7qzNyQ1y+GpsK3ucBHiSCnKc5XtWERi+whKyR7hGps8kIp+lY8rr5rQFwObYr7aeOLRgNFFFSKmQBFmGx33xNtzEiYI8KO6mVyCoBff3rf0tuOgrr/VrloUqRneBl0AE3JI47o3lh1Bvzdnw6HV1D0TCRF03jUjecQUoEH6gt9k9RMGq28ihce/L+hJfd5CQb0IHNXfO8pu8KAVo8hh1bb+HBzE6IXNtelgq4iU83QK6ztZog0uQX6Srq8DOvw0exfDknCI/ULWnj7OCDLU4t5rKE7RPtvihLsU7yR25vOdmXvSbkmVVrqtEhaIT8BUzDUr9HhKCjXv8Y7xFyy7Arr5UD5o1s5Q+fYO/1SKMcj1n+t5Vz8Ygj7JS9WbetBhKXhiyN3xnMsQ== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 31:OFD9mN61laeK/jAuxhka7109UEHuJ9w+nTDp6zH6Hz3t5cgpCwXzZ6Ug1dukS5VTR74bh4E2DlQk/EsSeBZxuXdX76GtqYQgUNlot7rY8+rc00zLOM9xwc7xK5CSxDHwm8TBa9O7REO70ZG8wPstsTSkNnYrk5UPUOXHosDfLsQ8F3YWHYxn73xyCENwqtFfgXlG71d6UbrMCfLQCMVgajzDXwGiSQQYJrf4V8OgiliE9X/m3o2wwFs3kTd38G0bat94nB9cFnNKjodm5Mu1IA==; 20:tI8oZNRRF5FDvViJ6HGvdcxSJ3yM6lnEoSWI2RxyfBCLNGuvbCH/PRhvjTZIp2lJJN+kNXbHK49AVsvgggO1L3R9RPrUnO2ViklYeSHnhLMws2NuUUR6zIAYodAxELKAxzuOc7rNZhQNNJTi3Satw9cH17gW2+Z9O49xRJiMzLyLess0ZUL95vFd3X+f1W7g9NEL2BaSU/CQlJtUtg1d/kOi7O4RSdETGw7SAMx0LM9iPf6kXS5CTKEyo+caI7l0sh+1xune3zDdmia0DFPpjmI03NiiWJPOEbVjYP06tGThGlemEACg7L1EgTlXVLhILSxRfdcsEak+YSDZh8j9+pERBABNfQz1DjOp2J7Wj1oBfrbGZ56cl4poxwrfWSeTHWvQ5x2+7eHyTUj+UapDrvG54iW3SgwEuAzYjIjlGH3aAZzqRVkEsw4hQZE8p5n/WucL2LzMsvKu/JJCrqNN3c51ld4YSQsvdiMqr+YhgdcPtgH0lLQqZblt4VFMj13aSt6BgFE8wmh3fcBGJYutEwTXtmS/xGLeALxuIamti53/6xO+dpWoJjt5DWodwoIt2E1PP47hzcDxK8YIO2t+Yqu6q0u5dl3l5y7RoC294fY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006067)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:CY1PR0701MB1725; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1725; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 4:F1He0yFo/nRwZUwx7OIQDVHiES5XsQujlFiVZRRxcvdiIza9qKT7MKAaFlNDIQfotFHTgMIcuiH+E6lFh1nUs7W+nhw8BmthZQuS2badxWrvoAS8RWluTuMtcarxPeKr4hqcqhWXeRBNcWFZ/qouJn6FsWa9SUQrLRZPsvbeCC5EM7IfHSNROW8S3ZChJIXcHxdPjTUIAG6eaoD2wkgRdbDx/eoQCu7rwZTFiFF4FkXtge7JpvCMZzaJSVTHW+Ud/49D9Q/CObW1dhqdz7m5+0tGllXanGrA99qbG3r23qaYcy+wnUWptnR+VHajnH/rDygCGY7CTdJsrDEhCDExL1BPYaKLnn5uwQectL3y1U+gGnNjaVyfasYyX9K572qWOjHY3HTWhDkJnwX+N8V2NJF/I+Amz7ksmlGXLP5Efqn6eevfqisiXxz3ePNUnmvo/DK/QwBeupod9rX4UHwFgG9UP4d22yb8DJCu3WH1nzfRC45HJQy0KKbOsUND6Nsp0Kw2HUir/TtvJyIfAIqjr2XtMMMofaAmjesYpbPy93qebO7SIrC+JC7gBqFnUqVNB6Szt70lb5Z70zFxHbQZSkcRRYo8XcOxP9DBHdDrIh5heTVFXJQTQkgUnSTYOKGa1sOfkGVamvCPqlXv6GIH3FGGWxSjCqW71C8s02iF5R4uZx9ZSd4wy2GV+YIzj+OejHrG4qrRqjjJQiZcnz3bbdKTW0V15ab4TdavKjo+OnQ/3KlVlNMGfzamyKJ3Zu+I X-Forefront-PRVS: 02622CEF0A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39850400002)(39840400002)(39410400002)(39400400002)(39450400003)(24454002)(50466002)(9686003)(1076002)(55016002)(3846002)(6116002)(23726003)(4001350100001)(81166006)(83506001)(8676002)(189998001)(4326008)(5660300001)(53936002)(6246003)(47776003)(5009440100003)(2906002)(33646002)(6666003)(38730400002)(6506006)(66066001)(25786009)(61506002)(7736002)(110136004)(42186005)(50986999)(2950100002)(76176999)(305945005)(6916009)(42882006)(54356999)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1725; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1725; 23:/w5fZ8AdV/OdpyiN8x3B+dtZpD5eFCEhZi7M2xO?= =?us-ascii?Q?QT8g+PE0g4AyxDh44yGhsk8uf6H/7s7P258SHL0B9vPtBqUnYWqrJHNEHaTU?= =?us-ascii?Q?KWY7rpRGKgZUB0GBCrWpGu3R3sFAhzOXZ6KFtydq0Zw2sGbl65N775Cxtx32?= =?us-ascii?Q?GwI3Yo7jQ+6zoDh2ZgW8bK0E5pNiZCYdlCERcNPeA5Mm8nZbeiFBtoyPmW4a?= =?us-ascii?Q?IXuWXBdDaTJo3novsXhl8rNifnOoBVYZfzH2lrj2UQkwaXNw1HTJyBsgsMpC?= =?us-ascii?Q?Q1VW0ijUlQm944AfbaFqA6LbqPDU6cJdtOsGnaZ5BfXxfGU1eg4XMoYuNT3J?= =?us-ascii?Q?/TrgPSD3ViAGxj7o2DutNIxjrETJsVtW9Qwjfn/BZQd06u1rmGd/arCYT+HV?= =?us-ascii?Q?frKdnhmDcEV8QxA5Tt3RDqlfbk3X4ovP6yAw5swxKBpsH4+hNh2gpT/daxy2?= =?us-ascii?Q?OZraeGyV57+SIS3aY4BXl/xCGjGO4Tb+tH7idbOirzHut/3Mdhl5VDUsAAEa?= =?us-ascii?Q?fylkH1REs4DDMx15L9EjaLDpLm+BHH1LlEhaO6fxzfA4YKY3nYE8hazW1Ziu?= =?us-ascii?Q?tsrrmNgXQRLQM66+nZw/1w/c6thk1OP41C0SiaU1jdChCMHy//Y7AXJ0WoHu?= =?us-ascii?Q?alcYxgnOdlPCe+V/3OlcxEczuCh/o4tuzAefoeo7T7QMXSa2ymnKe7q4FC9j?= =?us-ascii?Q?64gfeF+VzWlZe7PrRXD8PtZUa1kzQpVBLkalo9iziL/15P11FEKycJafxJBP?= =?us-ascii?Q?psNFdGa4F/q6GjpjQKSxDld9FXIDWT8MzZBe/35yhU09V93SWWL70vrq0t1k?= =?us-ascii?Q?FoFX/SS0IZFh1oXxttVLjzUcaq/Ov/VJnQjV3jW0i9AMuncjYINjAgGImqz5?= =?us-ascii?Q?CuV0YhdANCx0ugzeoQ314eq/1A2RzK0VCqPjhi7CU0H1V5dFjkbQY/NcTnT2?= =?us-ascii?Q?npqvmDkpECINfS2VS/lpmyr4x247J9Ib+KHrovNFxD2DakCcySo9T1LolTXV?= =?us-ascii?Q?8oj6G0pFLgS3aclw8Iwo0oGJmczRvP1WreTFmR3vYBr9R8beI/1trP4ya+D1?= =?us-ascii?Q?9hdW0vBy+BRQNA7Cc2cmJtoRKtKaVatyR8LTU9ZAo1dgpeRQ4ZPwTPpDyVcA?= =?us-ascii?Q?yhFRPTtKfyYRrkGf2wE7H8qWNBnktenZh?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 6:hRMlcKeM1wKEoX67wjOABHdDpEVA5kKpfu1m/QzJ6BBzGgUEWhgogo41Bw8Q/GqD8IhgPWs2yTSPPCKcTDLFo2CY0kWFLrsjietTwS7CfnswYyVzrVuNIU98VwfvMTMNYy7VdLvKBqMzHwl9ulBgmxkM0YulmQrq55DO6kNEOcJ4w9ahvD4Lfv7gbv6wF1GtQi4VC9NXVqN+/2I7GWkyXLeZm4HhqQGEtRLoBSXQLKNzffWRvYsOQn9MlUhgha07WM9vKJ1EbtHNpMgcZF7+bBS3s7vTEYb7lNUoFh2iRFeC33Y7lo7HhbhLI9XUUNGjQpoVPniy+oKX/nX9lSAoW8YKsPrlbQecGfWKRJXUFIHROIxDf8IRPLdR9M2tJrth3Oc4N7oke2oddinnWJj1QA==; 5:MFvGkyxaJiVUshaV2oDrnX5hn6jO3LGEHFtIDwg01m1TeePEHy6vFIiPMt0lsQe5AaaSpqdRREDWLW/usjVZtzXhOn5mLJIQE1xOm+CMteSr/b+V5r68gJdfelJMGlE0DXjJrR/HJ28e+toU1sgIkg==; 24:cwNXXp3SwlrUcCqK1p4urSjiUExMKV/b9K3H0BDBnD1nrjkCR4/CjDlUbb7w6k6C5ZCK8H9IXlwJ9qypd1gtLQIZahabtSpxhhOcCRzrD+Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1725; 7:BOv76XhEnK5eli7njWDOl/GmyFYzSUkgIwkQuBy/apK3/fbiC7IhwYYlZtzgLOWDRD5uILK38heeIqGiwyrJAHlW9UUHKcBWxhAXKyeBMWVz3nO2ci69dVxy6FYD4rQ912qGDfwUryqENK4p7Q1flJRSzqNvkTkh1GliF8ISl4M16Vp8OxtL2eq8DVdPvf0KV+b5SZ1J0qwFodpllv4AVSDAnRekyPuc9eoM/2GU3ZeIEqvMEQ8BoDsPCn4uGbGqgO8jBxbIE+O1Vih8FR0XwnW9aBtn/pz31Q2NKyqGZ+4b3GNDUpjO0kfUKhj3L/FOGky35mKEjvq/NZXvhZs9YQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2017 17:11:47.4934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1725 Subject: Re: [dpdk-dev] [PATCH v6 01/21] eventdev: improve API docs for start function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 17:11:53 -0000 On Thu, Mar 30, 2017 at 12:25:43AM +0100, Harry van Haaren wrote: > This commit documents two error return values for the > rte_event_dev_start() function. > > -EINVAL indicates not all ports are configured -EINVAL returns in case of an invalid dev_id. How about -ESTALE or something like that? > -EDEADLK indicates that not all queues are linked to ports. If an > application enqueues to such a queue it can lead to deadlock IMO, Deadlock is an implementation detail all the PMD may not result in deadlock. How about -ENOLINK ? IMO, If you want to enforce this rule then the detection and check has to be be in common code to avoid all PMD duplicating the same code. > > Signed-off-by: Harry van Haaren > --- > lib/librte_eventdev/rte_eventdev.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 9971937..dc8dacb 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -757,7 +757,8 @@ rte_event_port_count(uint8_t dev_id); > * Event device identifier > * @return > * - 0: Success, device started. > - * - <0: Error code of the driver device start function. > + * - -EINVAL : Not all ports of the device are configured > + * - -EDEADLK: Not all queues are linked, which could lead to deadlock. > */ > int > rte_event_dev_start(uint8_t dev_id); > -- > 2.7.4 >