Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> 2017-03-30 16:30, Bruce Richardson:
> > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > 2017-03-29 17:38, Bruce Richardson:
> > > > Since performance-thread example app is now built as part of make examples
> > > > we don't need a special case line for it in testbuild.sh script
> > > [...]
> > > > --- a/devtools/test-build.sh
> > > > +++ b/devtools/test-build.sh
> > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > >  		O=$(readlink -m $dir/examples)
> > > >  	! echo $target | grep -q '^x86_64' || \
> > > > -	make -j$J -sC examples/performance-thread \
> > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > 
> > > You are missing the x86_64 check.
> > 
> > That's in the makefile in the first patch
> 
> Sorry, I mean you should remove the above check:
> 	! echo $target | grep -q '^x86_64' || \
> 
Oops, yes, you are right. Do you need a V3 of this set, or can you just
fix it up as you like it on apply?

/Bruce