From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9D07CFE5 for ; Fri, 31 Mar 2017 11:15:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490951714; x=1522487714; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lHuMqRbO5LuPT34poxdR5AN37PwnZLGTgNqhgTRFP+4=; b=xiXDZ8HlVra/RepoT+PV/tBIvSjsDFP5y7PhGS+53cj9EullAqugVoi7 4TYcx9wwqapU7GdefWmn1+VT2Fp76w==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 02:15:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="950119036" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga003.jf.intel.com with SMTP; 31 Mar 2017 02:15:11 -0700 Received: by (sSMTP sendmail emulation); Fri, 31 Mar 2017 10:15:10 +0100 Date: Fri, 31 Mar 2017 10:15:10 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Message-ID: <20170331091509.GC7668@bricha3-MOBL3.ger.corp.intel.com> References: <20170329140419.27149-1-bruce.richardson@intel.com> <1632639.Ait0E45soG@xps13> <20170330153003.GA14552@bricha3-MOBL3.ger.corp.intel.com> <1775524.8P82GFJXp7@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1775524.8P82GFJXp7@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 09:15:15 -0000 On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote: > 2017-03-30 16:30, Bruce Richardson: > > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote: > > > 2017-03-29 17:38, Bruce Richardson: > > > > Since performance-thread example app is now built as part of make examples > > > > we don't need a special case line for it in testbuild.sh script > > > [...] > > > > --- a/devtools/test-build.sh > > > > +++ b/devtools/test-build.sh > > > > @@ -237,9 +237,6 @@ for conf in $configs ; do > > > > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > > > O=$(readlink -m $dir/examples) > > > > ! echo $target | grep -q '^x86_64' || \ > > > > - make -j$J -sC examples/performance-thread \ > > > > - EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > > > - O=$(readlink -m $dir/examples/performance-thread) > > > > > > You are missing the x86_64 check. > > > > That's in the makefile in the first patch > > Sorry, I mean you should remove the above check: > ! echo $target | grep -q '^x86_64' || \ > Oops, yes, you are right. Do you need a V3 of this set, or can you just fix it up as you like it on apply? /Bruce