From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1A87B2B91 for ; Sat, 1 Apr 2017 10:37:55 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 01 Apr 2017 01:37:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,256,1486454400"; d="scan'208";a="72479253" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga004.jf.intel.com with ESMTP; 01 Apr 2017 01:37:54 -0700 Date: Sat, 1 Apr 2017 16:35:21 +0800 From: Yuanhan Liu To: dev@dpdk.org Cc: Maxime Coquelin Message-ID: <20170401083521.GX18844@yliu-dev.sh.intel.com> References: <1488434385-7605-1-git-send-email-yuanhan.liu@linux.intel.com> <1488435367-22170-1-git-send-email-yuanhan.liu@linux.intel.com> <1042e46c-733f-929d-b299-9ac7abf174cb@redhat.com> <20170322085612.GP18844@yliu-dev.sh.intel.com> <20170401083258.GW18844@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170401083258.GW18844@yliu-dev.sh.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 08:37:56 -0000 On Sat, Apr 01, 2017 at 04:32:58PM +0800, Yuanhan Liu wrote: > On Wed, Mar 22, 2017 at 04:56:12PM +0800, Yuanhan Liu wrote: > > On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote: > > > > > > > > > On 03/02/2017 07:16 AM, Yuanhan Liu wrote: > > > >We used to allocate queues based on the index from SET_VRING_CALL > > > >request: if corresponding queue hasn't been allocated, allocate it. > > > > > > > >Though it's pratically right (it's the first per-vring request we > > > >will get from QEMU for vhost-user negotiation), but it's not technically > > > >right: it's not documented in the vhost-user spec that it will always > > > >be the first per-vring request. For example, SET_VRING_ADDR could also > > > >be the first per-vring request. > > > > > > > >Thus, we should not depend the SET_VRING_CALL on queue allocation. > > > >Instead, we could catch all the per-vring messages at the entrance of > > > >request handler, and allocate one if it hasn't been allocated before. > > > > > > > >By that, we could remove a hack. > > > > > > > >Signed-off-by: Yuanhan Liu > > > >--- > > > > > > > >v2: add missing break > > > >--- > > > > lib/librte_vhost/vhost_user.c | 61 ++++++++++++++++++++++++++++++++++--------- > > > > 1 file changed, 48 insertions(+), 13 deletions(-) > > > > > > > > > Reviewed-by: Maxime Coquelin > > > > Thanks. > > > > Applied to dpdk-next-virtio. > > Reworked, as there is a silly error that cause crash. Re-applied. --yliu > -- >8 -- > >From 269ba9b3a6a1671f463b9f9d4cc0d51954f7a2f5 Mon Sep 17 00:00:00 2001 > From: Yuanhan Liu > Date: Thu, 2 Mar 2017 14:16:07 +0800 > Subject: [PATCH v3] vhost: remove a hack on queue allocation