From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Eads, Gage" <gage.eads@intel.com>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"santosh.shukla@caviumnetworks.com--thread"
<santosh.shukla@caviumnetworks.com--thread>
Subject: Re: [dpdk-dev] [PATCH] doc: add eventdev library to 17.05 release notes
Date: Sat, 1 Apr 2017 16:52:46 +0530 [thread overview]
Message-ID: <20170401112245.6op6bqgx5q7hwznq@localhost.localdomain> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA612A27AC8@IRSMSX102.ger.corp.intel.com>
On Fri, Mar 31, 2017 at 02:54:10PM +0000, Van Haaren, Harry wrote:
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Friday, March 31, 2017 3:20 PM
> > To: dev@dpdk.org
> > Cc: thomas.monjalon@6wind.com; Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren,
> > Harry <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>;
> > nipun.gupta@nxp.com; santosh.shukla@caviumnetworks.com--thread; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] doc: add eventdev library to 17.05 release notes
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
>
> Nit Pick;
> Title in past tense (correct)
>
> Some sentences in body in current-tense "This API introduces ...",
> which I belive should be "This API introduced ..."
>
> s/ "Eventdev library adds" / "Eventdev library added"
>
>
> Content reads well, perhaps fix above on apply;
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied to dpdk-next-eventdev/master with s/"Eventdev library adds" / "Eventdev library added"
Thanks.
prev parent reply other threads:[~2017-04-01 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 14:20 Jerin Jacob
2017-03-31 14:54 ` Van Haaren, Harry
2017-04-01 11:22 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401112245.6op6bqgx5q7hwznq@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=santosh.shukla@caviumnetworks.com--thread \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).