From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Legacy, Allain" <Allain.Legacy@windriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "YIGIT, FERRUH" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/avp: fix build with non x86
Date: Mon, 3 Apr 2017 19:52:05 +0530 [thread overview]
Message-ID: <20170403142204.jj3dgw4xxfc4pv4i@localhost.localdomain> (raw)
In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968FFB96@ALA-MBC.corp.ad.wrs.com>
On Mon, Apr 03, 2017 at 02:10:41PM +0000, Legacy, Allain wrote:
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Monday, April 03, 2017 9:59 AM
> > To: dev@dpdk.org
> > Cc: YIGIT, FERRUH; Legacy, Allain; Jerin Jacob
> > Subject: [dpdk-dev] [PATCH] net/avp: fix build with non x86
> >
> > sys/io.h is an x86 specific header file and AVP driver is not using any x86
> > specific IO operation. Hence removing the sys/io.h reference to fix the build
> > issue on non x86 platforms.
> >
> > Fixes: 5567f9689cf8 ("net/avp: support driver registration")
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> In addition to this, since we do not support AVP devices on anything but x86_64 perhaps it would be appropriate to avoid compilation altogether on other architectures. That is, by disabling CONFIG_RTE_LIBRTE_AVP_PMD by default and only enabling for x86_64 on icc/gcc/clang for linuxapp?
If that is the case then Please send a patch to fix it appropriately.
>
> Allain
>
> Allain Legacy, Software Developer, Wind River
> direct 613.270.2279 fax: 613.492.7870 skype: allain.legacy
> 350 Terry Fox Drive, Suite 200, Ottawa, Ontario, K2K 2W5
>
>
>
>
next prev parent reply other threads:[~2017-04-03 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 13:58 Jerin Jacob
2017-04-03 14:06 ` Ferruh Yigit
2017-04-03 14:10 ` Legacy, Allain
2017-04-03 14:22 ` Jerin Jacob [this message]
2017-04-03 14:23 ` Ferruh Yigit
2017-04-03 15:47 ` Legacy, Allain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403142204.jj3dgw4xxfc4pv4i@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=Allain.Legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).