From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B69DC282 for ; Mon, 3 Apr 2017 16:51:43 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 03 Apr 2017 07:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,270,1486454400"; d="scan'208";a="951172692" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga003.jf.intel.com with SMTP; 03 Apr 2017 07:51:40 -0700 Received: by (sSMTP sendmail emulation); Mon, 03 Apr 2017 15:51:39 +0100 Date: Mon, 3 Apr 2017 15:51:39 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org Message-ID: <20170403145138.GA676@bricha3-MOBL3.ger.corp.intel.com> References: <20170403143944.17719-1-bruce.richardson@intel.com> <20170403143944.17719-3-bruce.richardson@intel.com> <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove option to disable offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 14:51:44 -0000 On Mon, Apr 03, 2017 at 03:45:46PM +0100, Ferruh Yigit wrote: > On 4/3/2017 3:39 PM, Bruce Richardson wrote: > > Having packets received without any offload flags given in the mbuf is not > > very useful, and performance tests with testpmd indicates little to no > > benefit is got with the current code by turning off the flags. This makes > > the build-time option pointless, so we can remove it. > > > > Signed-off-by: Bruce Richardson > > --- > > config/common_base | 1 - > > doc/guides/nics/i40e.rst | 5 ----- > > drivers/net/i40e/i40e_rxtx_vec_common.h | 8 -------- > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 11 ----------- > > drivers/net/i40e/i40e_rxtx_vec_sse.c | 11 ----------- > > Should this patch also update powerpc vector PMD (i40e_rxtx_vec_altivec.c) ? > Yes, good catch. I based this work off the main tree rather than next-net as I was looking at the mbuf changes primarily. Once we get either next-net or the mbuf patches merged in, I'll do a V2 with all updates included. /Bruce