From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam01on0075.outbound.protection.outlook.com [104.47.32.75])
by dpdk.org (Postfix) with ESMTP id F093A2C2F
for <dev@dpdk.org>; Mon, 3 Apr 2017 17:13:41 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=MsCDP422em9+RLvlYbtw/Vr1wM67ck0IXpwDUdrqueE=;
b=iFCot5mbBtMyv7+OIIZiexf2Xds1vESn8X4Xh4j1bW70bEtxL6Ra86PcWg7PhREcxTVeaP+f4l8Uo65SGgJmLhh1uXMwCxe3hFwV+IZPl05Jdxew9Whi4uQuce9eCESkHC7ZddCGtyXm2QCFgWKjak5FiwtoKh4YBbtvohno/TU=
Authentication-Results: caviumnetworks.com; dkim=none (message not signed)
header.d=none;caviumnetworks.com; dmarc=none action=none
header.from=caviumnetworks.com;
Received: from localhost.localdomain (14.140.2.178) by
BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
15.1.1005.10; Mon, 3 Apr 2017 15:13:38 +0000
Date: Mon, 3 Apr 2017 20:43:17 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
Cc: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>, dev@dpdk.org
Message-ID: <20170403151315.2yrchyh4fgpjn3ha@localhost.localdomain>
References: <1490968669-9161-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1490968669-9161-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
User-Agent: NeoMutt/20170306 (1.8.0)
X-Originating-IP: [14.140.2.178]
X-ClientProxiedBy: BMXPR01CA0018.INDPRD01.PROD.OUTLOOK.COM (10.174.214.156) To
BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141)
X-MS-Office365-Filtering-Correlation-Id: 78172af2-2b1c-4c65-7e16-08d47aa40270
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1715;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
3:BpUupXualvPMjz5n2TVyYg4oh/QwcQuDMdDM3NjTZIOuxIqcUkzsg5ixLdpltZqhRBp6WM1EJnWKU3cnd1HM7ITB/CqI0riUWZMV/h9SXDcvyJ9fG2a6J2vwMYfwKmbcjY2Fp0+QQr37vNcg/ewMCbBYwTWBVJUb7mSESPowDpM8Gsy2UHOPNck3QQY0pltF3WRJLlW5Yak1kAQ217B63/YQ/KoNKPtVpw7VV/F6zPSgeexF3s54b/PwxqhaLNMWfnEwy/YFapURTVj9Wge0OriQWgAE+9TdtBOeqQ3b6F4B2bF/GsjPWc0d2j53tcn3MOvGq7bYi6jjt3ejyaqxzA==;
25:VjBktvmGyvWdo7xvYb1rSFbCc6WOh/2rU6//1NbrBemcAlN2nsy1tfqR5/HsWDCsHiJjmUKDOMdEBqjG8ggI6dAAvnBhNFvPzPqd/GvHz8NfeYo84tPoa3OexQr3nBFugmp939dSOLZJ2qZqfHeBYtKJnp/1uLIQLJ/gAi5Lxuc2Mb3rQgRucsCwjpW6ZxBffKBIgtMD5pqX5GJg7NYEejWmB5yW2Bk7R7csayyjxrQ8x2OHKnjSzhJp1NGRmKpn0+aV0wTl72936pN+x5R7HAxmEkYx6WP28iDVhWIGhm3ztu0E+1I5sGw9SpxHYfWyFwwMAmbZk9oh1Yk1ff+ulDUML2uTWStM/x+eqbg5RbfCB3VRGkhmk0mHyTnB3a1o7zjJgmUqdV0k1HzwLRw9gGcaJYoWduhoNTosctTOz4/jiF3dVybgG9OOdwDrk8VUl6PcHo7lkGiKn1aD8W3MqQ==
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
31:XmhQnk/TgaPybPKpDMfFg/J9Wz0AplpgUo+2ugGKOkmTdTJPr3Tp2uPfFjmaAWpjoVzhhv1FVrjH0TdzRQhZlH4ZhIC3EcsAP2zqtYDegY/tq33Yho681DA3kA7YH9IhSXh7v/N9sQWQZ6Kb4z32weuvuvcWKTJj1XvGtSvN2X96y9y8fWab9ibCQxXdcBNlyvg9K7mzzIZmn4MVwAhidnigU3ugJGX6wd7a9Xzrc0SJImarAGCGQNIQNu3xD9ke;
20:xoU5a6EIovoJT6prvfMKSd4Hjb2voROgWxnWX5NSNU9JFMMk4Ook/eOaHevl7DZitv5qaMNMD/1vE/FgKjYvz3NYd8zNa0uxylAPoupm+vWzT2NPa00IHAj47s0voKmL27YKDH25gXkGwsM1yvr3uq9raUplwOJAqn2wZnA6/jbxWBa2Cjp7XMRUR2xh316LBDvvJ3dtR4Y33QLgZ3d8LDBWm1pmFrej3TtDw4JxJWmqzlQ0w1a0IRtz7wrhv/Pd0dumuwnpBWgc3MO2vhwzSo5UCO9+iJ9d/9crBlqErxHgobfq8EAXKo/w5ueSq+8k4nkHP69IQZGVbKLhOZdYraaXAzxxlLxRDZjDOx+aZVQgd4CmOa2/Z9fZubVBh72iwIvpBm9u9jObwuCSPDzdnKwiybSaFxv6TuPjmAhUETZo4nArNfDP6d1b7Vq11KjpOgDN3NeOXPPgr0tfOSzYd/xfYBFLBbSBsWu59osCYmtvjy61JM1eSE0B4UVeIXAg87TxG2wH9I+PAcNMkLi3uqJ6TpatVzcVZVquz0tbCRFHoKtfcrN46A1qvVvftrIjiaIXdxTqTo1xHEdCzVRCiScqJv9x5gAWFqjubZ96Ioo=
X-Microsoft-Antispam-PRVS: <BLUPR0701MB171550564A163A66B9707A21E3080@BLUPR0701MB1715.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(278428928389397);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148);
SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
4:KDlf7sd3ILQlB5LcHnMHr15EwJtORigJ8X6Wa3hFZKqssOhmcXqorg/sUcHpwwvqr+mJUcE/9uzsu9+fupzzG9lFdyseesvQyznIVUq0Fn2IXYSyrflJwWx7wPatbZMGZcof09e4Lc51cbrIuQI+eS8LajWG08f4pT8JV5TaGV6PrgsfQcdaUGRe2eShdfGRAx+E2IGiJeoDmHLUgrjJAu+XxpWARmXRu7cL7+LhHGaNUeqU0O+wygwEco66OoRprkhV/1YtcpExpRFNDhDcPHtaRSg5ToVi+mYCU14Pr2Y7AjhoSUAEzfbuQ3nSJgiNJDuYu62hb9moxS/hCJP1AbBvNlQl5eJryxg2OAB5xcr3u65ldyGPQHIyDYLielMbMArhgQhPn9hyq+TQlAe+4K9cRdcSyQgW5gjSiWEuheVefKhC2njZIeZLBqK9vGUG3hgz6hkG6SuQ4mdO7eYAIzDsT0cvGOPflO80nxpa8aDcw2Qb7e2nkVHer858r13wbf05zhzKogdwcALRKcpOvAt9lOjyxHwmaekT0ryiOzcqgQfEb0zOxHTTmbkiDTK/N+hOr5HTk1n0TkD8/uFijX+uqCqeBJ1ceBY5tCGpONg/BlDvaQDJJa6F5usbvUm7Ljj7xB8WQg1h25SvMq9923zqrXm9nHBcS+rjE3PlYQ7xM32YhHfMM6ctAnVbYme1SW1FscE03VUHn8IS2hN4zi0ajmCBZbfQKKBC5geX5E6Dqm+Mvl/GU0ChKdqppPCg
X-Forefront-PRVS: 0266491E90
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(4630300001)(6009001)(6069001)(39450400003)(39400400002)(39840400002)(39850400002)(39410400002)(24454002)(50466002)(9686003)(4326008)(6506006)(83506001)(6306002)(25786009)(6862004)(106356001)(53936002)(5660300001)(33646002)(4001350100001)(1076002)(23726003)(3846002)(55016002)(6116002)(6666003)(54356999)(76176999)(50986999)(8676002)(2906002)(42186005)(5009440100003)(47776003)(61506002)(6636002)(110136004)(53376002)(38730400002)(966004)(305945005)(81166006)(66066001)(189998001)(229853002)(6246003)(7736002)(42882006)(2950100002)(110426004);
DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:;
SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en;
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715;
23:ISFaJnB+WVc+G+754KOsSkWgI8vYaUe6SDu6aVe?=
=?us-ascii?Q?HXmHxiser8r1V8WoDjh6rNDmD3ogHSeeANWxLapcc28N4Qdotjyg0Da3tYQS?=
=?us-ascii?Q?ZRboY14xRUSaG1difWWkx67PkdihP8/KoXskCC0vX29RgLhbxDS1qCMzK6dQ?=
=?us-ascii?Q?uqxaPsBcQE2UWPa03HVnOCEJryPMevuYjGF3SZ7qgi+jowqpcJ101krpawHT?=
=?us-ascii?Q?XwYX7PpA+WcY72S9aWf9Kmf4RN/QgMvCHmyVPMl1/tNyfFbumQVrpVx/0YCi?=
=?us-ascii?Q?3Y4limeEMVSTo8NgL8G7MkK+PFFgn1d8TM5Mf1IG3DD41OrRpqxsrzizjAMY?=
=?us-ascii?Q?d9VUR/iEWN87UfDYJNHwKMj0uJOWV0YQWM2IEsnhUP3UykmRWY/OWlvswZgB?=
=?us-ascii?Q?x1A4S89iTD+dzTMV3cHfv5j9ZOvRffHoCsY14+9OWkm2X+NdnzcBPswSNlyp?=
=?us-ascii?Q?9cX1pQ8/tMYo+yuQLZ+7V3ssyaQ89/7JJMP5300ONapjs6I70enaLfBLVKtr?=
=?us-ascii?Q?XKjy2nammYL1VAlZ/nW/nDZGtrYKRBRLw4RQ6XYTkcozkapn5mzrZoHEMpIA?=
=?us-ascii?Q?D0pEulqRJP9pSoZZPe635owiWQEq3fJyecRnlRPT2MG3bu4tiCwjStjPoFdf?=
=?us-ascii?Q?/sCn8Uzoc4lAB9nw1SA4DTMZWVM+C08C5G9OMfBz3ckFZ0HZuVR+Z565C6bu?=
=?us-ascii?Q?ANgbF+p6iJdfRcIvwrhBzJBrJTjFuYGalBYbKwJ+iBX0bhi6HyAme9+j5ksQ?=
=?us-ascii?Q?Zx4X0DnFmrhZTcPgyCkFHak1XygG54aIMKIGI0OPfrJ4qGQOHHH+jUIyhCDd?=
=?us-ascii?Q?+9CdAFyj78gFylgyCq8s6xsSjq/XRgfllAroLrEo1Ih9njZaqV7Zd5shL9d7?=
=?us-ascii?Q?tZ/yBPe7q3nkO2y0qlCKVMGyrSYpaf/lDQEzHknqPRecXN6ZpiFbhpL41nbt?=
=?us-ascii?Q?2CrMVGywIHeXaCzsY1cUcpEkg0L3xFL5iL4nKIWxzIzsoVmvD2/80ErBcN1k?=
=?us-ascii?Q?f1XIcy+/U2FyfBk5uOHSsBjHzEHPzuGODMfWkxpAeGwe0+5mtnkiOp4pZ4wF?=
=?us-ascii?Q?iPyDSi3k6QDhbOZ4Q21992a5965OwrfJ8RXtLoLCDYRPtZDnk6Q2rg+VYTPM?=
=?us-ascii?Q?hggP6Q8I3L88QaDSiOKD10Fv06/K8HfGy4t7MscRwtpDwwNiYllFdFGbAUdk?=
=?us-ascii?Q?DE61Ph30wkhBMPifoWDihMp6VhD2mjoeorG1nEs+pXkSU7i7yMlMILjN+mxe?=
=?us-ascii?Q?N7s0viAprlUaEzeFksK5hPx/w+iYXeCafJz+GyrTp?=
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
6:Ri7dsXupjTrtk5yh2cUx/uiZNauNqhTAhTIWR1iFEkr1sZadqPqphRXN+v0dz5dbPgt+JkYn76/5iMGsBXNy71Xhb4QDyTCxO6VakZRN5BQ5+UjS0jzY63IJChgHa8XaeJxeUna4N12cvH1ZrB6DEwIA2aaT+mEx10HtNs4BxJatAkFP5F1fy8IWTUXg0sSx2U2uEd9IOpcKsmYQopaS/gJKabfgidlk1ci3TGUcsuVT6X2PRJ8CVYdGS7VnrmxagKTh4XICQP8LRjVGqf4BNzPeorI3nf5gTgQWUJQg4kjRy2khdQe4y0fgIYCR21FJwCzQtbb1OPBhmDeJf9cgNbe/Kxc8Qga0ZH/OR3gqtazcKEomoaUSAyWutmL0gdDfju1m0+Mp1/69jauri1U8LQ==;
5:7CP/iL8VNqIqgYL9zOe3WlwkZ0z+fpFggsL6m1ni/XYeAKMl4cBp32PL4bGLFeGZldQGC9RDLqmV7cy9Cr587MmL1+ft9lx0AzDWYopzzXwBzZf0wcOGw8foRxU0fFRaYmndQDnVakQR0lUjfrVHHQ==;
24:+0LqdEd6aykXk4TN2wh3ZWPBXlZng4W6III7Vj2z6nta2ym0Tg9K6ynqjWyoHT3GSwd1gUQu5pG65p1Ux5QJirpn09NZCohUPmxdXPxiGGI=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
7:LejG/VDQ1ep2qEA3cWNqptTHPeMDCTHJxjBBHlEvFuT+e8RjAeyZWu/11PFJ7tLzzfMd/osfiqPZLxS2YmA5e59FblIcPg7KOMn7a20ShODQct9/iNyXSucm8RiJsA+g73tgMjARZpXbj9fyZyttH7RULoebev7ybs9hm+S0eGejg0+zYalbqw92UL95KFG242JBfLHyzVDVKt7Las2TMFmASl2KdeNNCBRTLo3MrcoqyjJx0W+qv5x4F23RQGxI8+N9a4iX5yAKNg+zhWhcmSsbZ+A5qMvTOgJt76r9Jv3fZFcdXZOjB0+l74t77g0k2gkRLsmaUaE8b3uyIrX+bQ==
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 15:13:38.0389 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715
Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: add empty link up/down
callbacks
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Apr 2017 15:13:42 -0000
On Fri, Mar 31, 2017 at 03:57:48PM +0200, Andriy Berestovskyy wrote:
> Some applications and DPDK examples expect link up/down
> functionality to be provided.
>
> Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
> ---
> drivers/net/thunderx/nicvf_ethdev.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
> index 1060319..984c218 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> @@ -1924,11 +1924,25 @@ nicvf_dev_configure(struct rte_eth_dev *dev)
> return 0;
> }
>
> +static int
> +nicvf_dev_set_link_up(struct rte_eth_dev *dev __rte_unused)
> +{
> + return 0;
> +}
> +
> +static int
> +nicvf_dev_set_link_down(struct rte_eth_dev *dev __rte_unused)
> +{
> + return 0;
> +}
Since the VF drivers can't really initiate link_up and link_down and
other VF drivers like i40e VF is not setting this callback. I think, it is
OK keep it as -ENOSUP(which is default).
Since Christain Acked on the fix on the usage of examples/ip_pipeline
application. Probably we are OK without this change.
http://dpdk.org/ml/archives/dev/2017-March/062704.html
Any thought from ethdev maintainers?
> +
> /* Initialize and register driver with DPDK Application */
> static const struct eth_dev_ops nicvf_eth_dev_ops = {
> .dev_configure = nicvf_dev_configure,
> .dev_start = nicvf_dev_start,
> .dev_stop = nicvf_dev_stop,
> + .dev_set_link_up = nicvf_dev_set_link_up,
> + .dev_set_link_down = nicvf_dev_set_link_down,
> .link_update = nicvf_dev_link_update,
> .dev_close = nicvf_dev_close,
> .stats_get = nicvf_dev_stats_get,
> --
> 2.7.4
>