From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
[209.85.128.175]) by dpdk.org (Postfix) with ESMTP id BB3AA326C
for <dev@dpdk.org>; Tue, 4 Apr 2017 09:48:07 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id w11so200865523wrc.3
for <dev@dpdk.org>; Tue, 04 Apr 2017 00:48:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=yejowa+Ri8wwoiWoThU42EzJbQhqo4BxHSM1M4RHndA=;
b=IV4Iid4+E0bUiu42y3IJi0/tIVGa2pm2k1wYz6KrhFE8BQhD1mLA+IX+0+tQLxdgyP
XHyCz0wGy9bSoV5JV7XK/bNspGlkUiJ4uh+eAskAPaQcA2/6aTgTxxHtLZY0VSNM2EWo
XqjuLq+c/cnRCDHX6vZpaUV8O7KswIuhXaF521ofwx+qexOiz5GYoQxOymoWOrSPy5lr
qpNi5+WNQA0ZpvdABawJw9rOmlYgOkSOfMPA3080mvAdElPYQ+IX3Zy5/F1NUOPgY7zs
nagIqpkhkg7EpTsnPP52Bt/XwGFZA28UlFHax5BLsKEvF/27xcBE/PXQvjsvFlJo74D7
0xZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=yejowa+Ri8wwoiWoThU42EzJbQhqo4BxHSM1M4RHndA=;
b=DGE+7w3JYJvizWbTbwus0UDnMxkgGX27mCtukQpT0ilayrJLWloaneE+OQswYsPnHy
VPUFZyFKYJm73ROF7HcsbZvWSWzkAsoKN1t26F/yo/g50XfLFhaN38Vs/0TIfQfKPk+W
1hG5l8jmEaYPatpYBuJt5cgXKtzG5H8m3JyZIg0g1zASjhB41NR418bGP0Lzce1vq1EF
BsBlb3VaA9bM9sZLbmfwFteUMETP9Lkxf7JNbKAlhHNwxJjrEwm27iVJ+XfJzjPY3Dsf
kOmyl/j6o92kTHiTNeaJ1be/SJQyiKz1Jw9qKEvZ7ziSeyTucHDLreViRsF7gOoHoXZa
6vgw==
X-Gm-Message-State: AFeK/H1bDQnAe+D4bbVH3ooFKaWfF+m45Jw2Bb9B4JM+Jz8DVH6lWaAdxhtkHHQ72facfyzI
X-Received: by 10.28.13.65 with SMTP id 62mr12796386wmn.1.1491292086634;
Tue, 04 Apr 2017 00:48:06 -0700 (PDT)
Received: from neon (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id w10sm17316290wmw.14.2017.04.04.00.48.06
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 04 Apr 2017 00:48:06 -0700 (PDT)
Date: Tue, 4 Apr 2017 09:48:05 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org,
shreyansh.jain@nxp.com
Message-ID: <20170404094805.4520f2a0@neon>
In-Reply-To: <6998997.LVRpf6MECD@xps13>
References: <1491210729-9755-1-git-send-email-hemant.agrawal@nxp.com>
<20170403171958.5ff2f3ab@platinum>
<3c18f62b-252b-5184-07e0-0b4cb136d467@nxp.com>
<6998997.LVRpf6MECD@xps13>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mempool: introduce flag to indicate hw
mempool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Apr 2017 07:48:08 -0000
On Tue, 04 Apr 2017 08:58:40 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2017-04-04 11:05, Hemant Agrawal:
> > Hi Olivier,
> >
> > On 4/3/2017 8:49 PM, Olivier Matz wrote:
> > > Hi Hemant,
> > >
> > > On Mon, 3 Apr 2017 14:42:09 +0530, Hemant Agrawal
> > > <hemant.agrawal@nxp.com> wrote:
> > >> Hardware pools need to distinguish between buffers allocated
> > >> using software or hardware backed pools.
> > >>
> > >> Some HW NICs may choose to autonomously free the pickets during
> > >> transmit if the packet is from HW pool. While they should not do
> > >> it for software backed pools.
> > >>
> > >> Such flag would also help when multiple pools are being handled
> > >> by a PMD, saving costly compare operations for any internal
> > >> marker.
> > >>
> > >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > >> ---
> > >> lib/librte_mempool/rte_mempool.h | 5 +++++
> > >> 1 file changed, 5 insertions(+)
> > >>
> > >> diff --git a/lib/librte_mempool/rte_mempool.h
> > >> b/lib/librte_mempool/rte_mempool.h index 991feaa..91dbd21 100644
> > >> --- a/lib/librte_mempool/rte_mempool.h
> > >> +++ b/lib/librte_mempool/rte_mempool.h
> > >> @@ -263,6 +263,11 @@ struct rte_mempool {
> > >> #define MEMPOOL_F_SC_GET 0x0008 /**< Default get is
> > >> "single-consumer".*/ #define MEMPOOL_F_POOL_CREATED
> > >> 0x0010 /**< Internal: pool is created. */ #define
> > >> MEMPOOL_F_NO_PHYS_CONTIG 0x0020 /**< Don't need physically
> > >> contiguous objs. */ +#define MEMPOOL_F_HW_POOL (1 <<
> > >> ((sizeof(int) * 8) - 1)) /**< Internal:
> > >> + * Hardware offloaded pool. This information may be used
> > >> by the
> > >> + * NIC or other hw. Some NICs autonomously free the HW
> > >> backed pool packets. */ +
> > >> +/**< Don't need physically contiguous objs. */
> > >>
> > >> /**
> > >> * @internal When debug is enabled, store some statistics.
> > >
> > >
> > > One thing is still not clear to me: in your driver, you check
> > > this flag:
> > > - if it is unset, you reallocate a packet from your hw pool, you
> > > copy some metadata, and you send it to the hw.
> > > - if it is set, you assume that you can call mempool_to_bpid(mp)
> > > and directly send it to the hw.
> > >
> > > I think this is not correct. The test you want to do in your
> > > driver is: "is it the pool that I registered for my hardware"?
> > > It is not:
> > > "is it a hardware managed pool?".
> > > I think what you are doing here prevents to use 2 hardware
> > > mempools at the same time, because they would all have this flag,
> > > and mempool_to_bpid() would probably crash.
> > >
> >
> > No, I am only trying to differentiate between hw and software pool
> > packets. I don't see a possiblity of having two different
> > orthogonal hw mempool types working in the system. At any point of
> > time when you are running DPDK on a particular type of hardware,
> > you will only have *one* type of hardware backed pools in your
> > implementation. The number of mempool instances may be many but
> > all will able to work with mempool_to_bpid().
>
> No you could have different HW mempools on one system.
> Please imagine PCI NICs which provide a mempool.
> (other argument: never say never ;)
>
> > The application may send packet allocated from a *ring* pool
> > instead of using "hw" pool.
> >
> > So, it is sufficient to just check if the pool is offloaded or not.
> > HW can take care of all the supported pools.
> >
> > > Instead, can't you just compare the mempool pointer to a value
> > > stored internally in the driver?
> >
> > There can be more than one instance of mempool, the driver is
> > capable of supporting multiple hw offloaded mempools. Each dpaa2
> > PMD port may have different mempool instance registered.
> >
> > So, pointer comparison is not practical unless I start storing the
> > mempool driver pointer.
>
> Is it difficult to store this pointer?
>
Another idea which looks even better: what about comparing
mempool->ops_index to a value stored in the driver at init?
I think it describes exactly what you want: the mempool type is *your*
hardware mempool type.