From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F3F3F2A6C for ; Wed, 5 Apr 2017 10:23:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491380593; x=1522916593; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UkkBYkYIcLkaKtwtqhpR2W3mPy/nSTwnUsf0hw83nfU=; b=DYOuKtUBhJ5kPw3/gd7+x9ItUW8OcBzh81Vv15OrSBueEIkWGoykJZap QBnhyMQ/+F2Sk7ufsPC+6OkC2QAgmA==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 01:23:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,277,1486454400"; d="scan'208";a="1115709589" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga001.jf.intel.com with SMTP; 05 Apr 2017 01:23:09 -0700 Received: by (sSMTP sendmail emulation); Wed, 05 Apr 2017 09:23:09 +0100 Date: Wed, 5 Apr 2017 09:23:08 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Allain Legacy , dev@dpdk.org Message-ID: <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> References: <20170404163654.86100-1-allain.legacy@windriver.com> <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 08:23:13 -0000 On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote: > On 4/4/2017 5:36 PM, Allain Legacy wrote: > > The AVP devices are only supported on Intel 64-bit architectures so > > adjusting the defconfig attributes accordingly. > > > > Fixes: c5ab4707ba97 ("net/avp: support driver registration") > > > > Signed-off-by: Allain Legacy > > --- > > config/common_linuxapp | 1 - > > config/defconfig_i686-native-linuxapp-gcc | 5 ----- > > config/defconfig_i686-native-linuxapp-icc | 5 ----- > > config/defconfig_x86_64-native-linuxapp-clang | 5 +++++ > > Right now compiler config files only have compiler and architecture > configs, although it is OK to update them, to be consistent with what > other PMDs did, what do you think: > > Keep AVP config enabled in "common_linuxapp" > > Disable AVP in following configs: > defconfig_arm64-armv8a-linuxapp-gcc > defconfig_arm-armv7a-linuxapp-gcc > defconfig_ppc_64-power8-linuxapp-gcc > I actually disagree with that, and I think the approach proposed is better, given that it's only one target type that is supported. However, I think we should have an AVP config option in common base, set to "n", so that we at least there have an entry to indicate it exists. /Bruce