From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7397E68F7 for ; Thu, 6 Apr 2017 07:53:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491458029; x=1522994029; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kqDUTIAwO9OR4kl6G8F1FUs9c1l6O1fkK2BkrOaCQCY=; b=dYux1h7EXq9zTs8c5qHGt5oPPY2fA+SUAkGBheea8Pb9hTiDqiJIVOGR WFJDUrEsKZ++iKyir5KG48+MwF5jqg==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 22:53:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,282,1488873600"; d="scan'208";a="1131668884" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2017 22:53:47 -0700 Date: Thu, 6 Apr 2017 13:51:12 +0800 From: Yuanhan Liu To: Sagar Abhang Cc: mtetsuyah@gmail.com, dev@dpdk.org Message-ID: <20170406055112.GQ18844@yliu-dev.sh.intel.com> References: <1491000430-9884-1-git-send-email-sabhang@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491000430-9884-1-git-send-email-sabhang@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/vhost: move device stop call in close function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 05:53:49 -0000 On Fri, Mar 31, 2017 at 03:47:10PM -0700, Sagar Abhang wrote: > Moved the call to "eth_dev_stop" inside "eth_dev_close" because > "rte_eth_dev_close" calls 'close' operation of device, and in existing > code the close was happening without 'stop' operation for vhost device. > Moved code to free rx and tx queues inside "eth_dev_close" because the > "rte_eth_dev_close" function calls the vhost's "eth_dev_close" function > In that case, the memory allocated for the queues is not freed up > before we free the pointer of rx and tx queues causing memory leak. This patch looks Okay to me, expect the log is a bit hard to understand: you don't have to explain that "rte_eth_dev_xx" calls the vhost "eth_dev_xxx". Also please use whitespace lines between paragraphs. Will you try to reword the log a bit, so that I can apply? Thanks. --yliu