From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0082.outbound.protection.outlook.com [104.47.32.82])
 by dpdk.org (Postfix) with ESMTP id 63311108D
 for <dev@dpdk.org>; Thu,  6 Apr 2017 14:34:12 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=JAeQkK5ZTGlxfLvd/catYv6u9vXSe7rvOhmbiNldRO0=;
 b=TA282RA3NXMd3bb/vInz+uoXWT5CK3YWFTq+RR/zT9M38o8JlBWMxVyPaHFjMonD6PYTCjAIppiEgt7jHmWqhccVxSdSyIW9ZUepJHy+szcTHufUgMyZUg2grr9j08CVVDVExh+8dGlSXY5RVr6M/I+qfM4zKvj8IQekf/Wa6qM=
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none
 header.from=caviumnetworks.com;
Received: from jerin (111.93.218.67) by
 BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.1019.17; Thu, 6 Apr 2017 12:34:08 +0000
Date: Thu, 6 Apr 2017 18:03:52 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Harry van Haaren <harry.van.haaren@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Message-ID: <20170406123350.GB18255@jerin>
References: <20170406121428.16883-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170406121428.16883-1-ferruh.yigit@intel.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: BM1PR01CA0075.INDPRD01.PROD.OUTLOOK.COM (10.174.208.143) To
 BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16)
X-MS-Office365-Filtering-Correlation-Id: 35c93788-b019-4855-d8ac-08d47ce939dc
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(22001)(201703131423075)(201703031133081); SRVR:BN3PR0701MB1717; 
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717;
 3:9ytWa2DfbE83YBCOGRSMlwz2/+2aL6wIqob06/96/QDdBinZ4z/Z4VDub96YxLBblzjOAJSz1rgo1pzB6PMWcTAjwx8eYRR98afdDzEsBeIecM97xshVoywYrn7WVvBQDICnOJUBi8EES6DOJ8Ign4nYtfCez8F59armRhauij+UMapYwk3Jyyv5QIZ26oQO6q4vFbEgEeNM/X0R0J3i3MPrK49FF459fNs5KLoS81Jw9AskfdHUc8Ev54rPy1Z0R/MfIT5BOZ6zzUjvjA3yuw7peA087lhu/3ZwUCNLOs/1jb3r9jXMUf9HKowun9AiiPnqGEq3EwzYyLL6o83g9A==;
 25:s1RT5PeZqWSGYLQxwixafyVpqUufvpFtMl26wMbcgyr923dvxqWlQLEWC9bhJCateraXgA/flIHvJi+9v/FYfZTHTwAQS+e8wmpKkepbWlC4jRwDen9qgedKtkPT+fhoPn6dsQ5O30p2RX80LDoqLYQVF8QuMn/PAjBMcyimbcH3fS7TmJCSBvIS1PkTUjVLrb+UZCQSzOPxYKm8h0eukill/QgCnEpwMpczJsFFzi9Ur/MH/YpHMeg+q8Kr38Zox7/i59yYSbUrbSBIVtZB6IIYU69+XBixn6o37j7QX3xT/t/OCiJDDOyEYmxNNX1Z9vQ3cxBlgAcv2pP+cGMoyHS20XIonytmfE4/ocGAlKvjm1YEF1lcPDVYbcipDvGVn1uhuA7tD19WIKXYk9xoWCSfXGpI8v28pYJsOAJFDcVRrSGj6i8+Pv12evz996qzBQPAQRSycyvpgObizZz+iA==
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717;
 31:8i8iVH122CXlNbGThWtHeoxqBio9ktE3QFOBDZZuKuoxHlH9FfmTBDiLvT16xbJdOVZ7vi70xobhZ4xWLK8mrk2s/CJQJhOB1Gb/m1vpEjrJ3/EoZc5P78HOtv69Zt1bhcclqNz7m3Z3rAKqXxOI79Y7WXJaphtOKNSEx9+Y2eqtPI3beqRop2LidotzPtnZmTfgIVAgwsmN31FNnwCZnIMObNJLW3deO4bE/JpJf+z/9+URMUpv5DS2LWRitpl6LthKaaNU96k+iWPK+DWagw==;
 20:sKDBb5ZpeuK5Wmhw+oYBgcQuyTQP1gga02aUxOjQJn1X+frsxnmLh3rMg4PAIMm4xPUenZn7JGqA6HidcxlgtFjwWXu1vG04ajDf0AzoQ9zHhLYG0/POVN1o5bK0w/FZ/O51OSb8jjlb8Raoj4g4x0KH6hfNe7WcffNw36sY67RaDXzDhZIflxzK6nk1vogb1FsHgHn58tA8yHcDdfhBJWJZx+3JmEw/UQv2XX1m3KVRMr6lgf7AZjer/Xe47LEu1Hb6jKr3xgAeLFm3W4VWZ2/iHoUoNmVB/XBKnnpWIzSrORhGlTy/d9/DKyZTcjmV2mHZl8N+3a076dRoBB6uh46bud7TgWmB9n4n/ACasyRILIvsWQ8/e8CgiizRp63iZdg74x4viuBoN/R92chqsy4cdiliq/6JZ6L31Fx8rRyboTuzukDDYUeVhSo2eJqVdLq+/Sl5ZT/bSIKmvbBl44icegDaCcU/KxYZv1nF/xcNuOmxsnuXtYfckIOKiJ3eIZ+tDpW18Z8uH8ig3lvjc83Ns4eHgV9eAigIyh0/WeIK6IAarbdw0hoZI3xD4nUCmHRGpYeVB9TOaNi3V6i7TYTud67oWQvMj+MiyPBy5iQ=
X-Microsoft-Antispam-PRVS: <BN3PR0701MB17176632957A6D999E484BEBE30D0@BN3PR0701MB1717.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148);
 SRVR:BN3PR0701MB1717; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1717; 
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717;
 4:f0u3mCevjqV1XZeN9S1+ZjhisXpUIbkByjhhWc8igEEbMqDS2Wimksaccavh2btD4jHGreA1ZELdcMb9JBmrVA8snxps/bhzPvUD7oLWw0vC9v3goxU+ZtyTSxwry1LxZpCAHsNUHkPQWoSn/N1NMeDAOcqxDi38nf3tchO15RclKxfWCucsaA/b9rC8xtgP4LkiF8T1CbXhn8KwCeCpLO2iuBMWAxvKOrLYfP8W/8PYEsAV6gcpkdcBGwRWKrTQRi/hJ/uccgMsN4Lj9Axj4xm2gupJrnXpxVx9A/VgNGS5xWGn4xvn78qvmpPRgaKIjT0fstHNDfbi35Q5lR4hyk5YVbS4DaY/MjvuEiiv4meh6+mcvVVn37dLuK9bG+0MtM1PMALqFDL73skGTJL7ZHqKBy0H7ma6oJQNJ9ORT7QPEKxPNbhXueq1PiDsngaaYYvQC513oJ3eF3R6LQGpBm+Xxogq1pUu6BG6gJkSjCa4892KZyANg417EaWk6m0gIyQmde3q8Bf9bn2OlR2MZRCUP8cCO7bCO0IiuK6mq2Ovw2fPJIJbYsGYOAtZYK/pMvtcWavFIB53UpkkYAzcW2Wp0cZ73ypNwkV00sJM9vbWb5Q4LcZRQ5RFzCnhijmNjuabvq8LfCP9S/UWW5EDRgLsJvJEONqQehrqdXrPduaXACdwYameWw3U64AyqNDHTQG5M+syU0xyUotiJJrlr1tilQiH4+xh9wogfhMkdHUcsjqpVXIpyL89FCjXQjjG
X-Forefront-PRVS: 02698DF457
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(4630300001)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(13464003)(5660300001)(2950100002)(110136004)(42882006)(6916009)(76176999)(9686003)(50986999)(38730400002)(53936002)(33656002)(6246003)(66066001)(6496005)(3846002)(42186005)(47776003)(6666003)(5009440100003)(6116002)(229853002)(54356999)(4326008)(4001350100001)(8676002)(23726003)(83506001)(81166006)(25786009)(2906002)(575784001)(305945005)(189998001)(54906002)(7736002)(55016002)(33716001)(1076002)(18370500001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1717; H:jerin; FPR:; SPF:None;
 MLV:sfv; LANG:en; 
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1717;
 23:HnfXmI+IYuyt6vQpYZwvOxqkTgYTslvo5E3YMO2?=
 =?us-ascii?Q?SUbrZV6okpzCVJFCScXPFScjevyQzM5RBuYRtfhOmcpF0/FQn7UYuuyoAEqe?=
 =?us-ascii?Q?DwF+tBTbSelFZ6bOcGUiWBf2Dl2l/PBx8G9Nm1N+Q4sAF87UVKWEu41Tn51y?=
 =?us-ascii?Q?mxIRrr+Z3Cx69XBb+AGgUQ2wUrNIKVIl+11M+mzJqvKLliXWPjLzHGCb7yFH?=
 =?us-ascii?Q?sTtMZ0Yq7p1zoItjogBWfmBO3xXzF0y/JxK7Ju3eOgZFcczokMEnc9rZzAIk?=
 =?us-ascii?Q?lamLLSCOpVLgtbfNH7iQPG50Y5sUmwHbnJepBYmq2YFL0u1g72gPTH5iLIpK?=
 =?us-ascii?Q?/LocrxhZaRlr1V8LAgFhfdVKXVIZY+3gCt+Aui1I+pE52LJxxJALxT2uqhpS?=
 =?us-ascii?Q?2sULRxXjFfIVCqfGKmCKieFbEt7yRy8/Q1p6p1PZUUrOKXD2DfZSCoR05N0C?=
 =?us-ascii?Q?FAtfRz8vYfPL77jhi2kYQSsAh5LvkqHejTP1x4HB1c7s0TKaswDZbtk2gWUt?=
 =?us-ascii?Q?1LHZ01bHAryNlC51HrVoGQ9skjvBgVHKIzExMCTdYWYOZgej0IpjANoh0Dow?=
 =?us-ascii?Q?YQnc65nZMWGFzuYVNMqQJWrROdASxCA5VA6+W6QPx/V/3aUiKyC3p7vmAxZe?=
 =?us-ascii?Q?GVYAF83GMQDMPPz7jII2Fd1xNmDWhuKgJ9tOk1uj/z2vTYreH/m5mOjbeVuu?=
 =?us-ascii?Q?/3eR3PSyIPjMajjp1n8AWHRxVMGQDTyDRdnKyYh+7nh4vurjuDh+hnFhFyvd?=
 =?us-ascii?Q?Lz68X2MO5mgKhWipm64KjWp+l5cN/j6rrs0ty9r65wWmT/iXAfA7ocEaf9wm?=
 =?us-ascii?Q?F4DH7VZkGr4U4klcrzld0ripPrMdeuDjCdBOywNrPCOl2Hwk7o+quU0EepnO?=
 =?us-ascii?Q?Q5Z+ZzU2obUFE9SNOQ075d4QQaKPoVMkzGWdlX0/xwSVr8eGHd0f1Y+NuN/9?=
 =?us-ascii?Q?VL0BkGvXE5dkgJZuGVVMAYSWYzwPzb2LqdXbnev/KZD1PoAhSt0zktk2jMcY?=
 =?us-ascii?Q?GwcGGt6/1dLaDI4Jk8M5/i7sj4N9puc+C50QbKH1CQQTKxfcbT0ZpIn6zYeX?=
 =?us-ascii?Q?fWTxV4ea3N7LFW6WpGnezcUr/4Hf/mhxzG5RwWdavqJxKQWeh720Dxxz/4fM?=
 =?us-ascii?Q?HhRZW163yxhixBEfjQs5u6FZ1sc8TbBIGxg2PecyUD45pfJBQavlX0GjbicG?=
 =?us-ascii?Q?z6Jv0Ki4JdH+iEpg=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717;
 6:N8zeU2ItDM+VbaSD7Rj8Ku1pBUeficQx0b9lSC+9i/l7jn6k1PPr2DG/Bubj1ComHFpwXdUYQ0PalodmtZwuMRvF0/52nhqShCwo/bnXJ7tg2XhcclRvXAZCd+34D7lIKRWz2nJzWc5G47Fv4O1YSo7GdvBKdEq4tDIxjkmPbYauPHAX1eaCmXh7/42w5y6hr1HWYVJ0bluNl77PgyR787VzYHRK71c0aE1pkAjL7K+VtOy5LmWL2st711QjntEK5fR3H6s2LAe1JeLTau5EOjL/Nd6m/MhcPExARzZ4wu2BvRiCoOQi3CBbhFQ1OaMOVXw3FQQ/mWPjK2ZRwXTFIuqU0UBrX9qU4jI8gtkbH8jLeEgkNZmT0wHLNVFrJ5jmYkZ+unm5+T21yKk9YCoC8w==;
 5:i756GMPMk7n24sHsebmm0bUVXLdmLRRijmWo8ujiDBH0wKYteRnJZDJ4u34PdGKIcT7Z3/d271P61dXrabXYrenFWHCNK1G29ikGhVkDaWh+GL+JLe3UYX46hJK2kJ9SJTdapSdHfxENZ0So54KNeA==;
 24:iaF2dBEbaLYMMeurRtT5Pi/QVJiPoMNwn+ysfM84QEHt272A/yLPWtXYQHby4A5l7KgqksJ7dI6Bv86CQhzrlU17t14rVble+uo6NQqRswg=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717;
 7:ZIFoj62U0+hczKbtCiZAVPK/wtkEirdOu5jBV9VQ4kq8fq8TWnrbq6YmDD8y6/M7elUaia/C4zmbOihEyLsPOgnjAq0mBahab4Okd3YjsemBM63MuVEgG+IS0QT1ssXFWD4nmwng5g/OILCIV3JR0B3vut4I35dpI4Zj9pZt74IQ87IKFPPZfFKpTp7JCwMWGyM22X0mZhZKIJOtYyxnje3gFFvAtJNLDIUrAjTXrNlWbd59mLMROxeTo9MDNQb9OG8VIVcwLZabTx6kUqAhYgVhGgXaGdSR/YswllUHAlaz/x2NGdoWRsUfRPLGK+KOhFMPeKLz3sR/zynUN0f2Lg==
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2017 12:34:08.3893 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1717
Subject: Re: [dpdk-dev] [PATCH 1/3] net/thunderx: disable pmd for gcc < 4.7
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Apr 2017 12:34:13 -0000

-----Original Message-----
> Date: Thu,  6 Apr 2017 13:14:26 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Bruce Richardson
>  <bruce.richardson@intel.com>, Harry van Haaren
>  <harry.van.haaren@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com>
> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH 1/3] net/thunderx: disable pmd for gcc < 4.7
> X-Mailer: git-send-email 2.8.4
> 
> PMD uses some compiler builtins and new compiler options. Tested with
> gcc 4.5.1 and following were not supported:
> 
> option:
> -Ofast
> 
> macros:
> _Static_assert
> 
> __ORDER_LITTLE_ENDIAN__
> __ORDER_BIG_ENDIAN__
> __BYTE_ORDER__
> 
> __atomic_fetch_add
> __ATOMIC_ACQUIRE
> __atomic_load_n
> __ATOMIC_RELAXED
> __atomic_store_n
> __ATOMIC_RELEASE
> 
> It is not easy to fix all in PMD, disabling PMD for gcc version < 4.7
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/net/thunderx/Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/thunderx/Makefile b/drivers/net/thunderx/Makefile
> index 706250b..0b9f0a2 100644
> --- a/drivers/net/thunderx/Makefile
> +++ b/drivers/net/thunderx/Makefile
> @@ -62,6 +62,14 @@ SRCS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += nicvf_svf.c
>  
>  ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
>  CFLAGS_nicvf_rxtx.o += -fno-prefetch-loop-arrays
> +
> +# Disable PMD for gcc < 4.7
> +ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
> +$(warning thunderx pmd not supported by gcc < 4.7)
> +LIB = 
> +SRC-y = 
> +endif
> +
>  endif
>  CFLAGS_nicvf_rxtx.o += -Ofast
>  
> -- 
> 2.9.3
>