From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E2BA02C5 for ; Fri, 7 Apr 2017 10:24:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491553453; x=1523089453; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2m1Th6QqXgwxyfsfCh23exVMatf0CAFchMA9CBe5ck0=; b=gI4wmHKps79+rAnDOwuPjApyQBfQ6fCQbbI6zrtbKHN7z2J1H4nN3ZRy Gra8+W7A2lpnRH0bgSOPfwEsyrk1jA==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 01:24:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,164,1488873600"; d="scan'208";a="84611487" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga005.jf.intel.com with SMTP; 07 Apr 2017 01:24:09 -0700 Received: by (sSMTP sendmail emulation); Fri, 07 Apr 2017 09:24:08 +0100 Date: Fri, 7 Apr 2017 09:24:08 +0100 From: Bruce Richardson To: Andriy Berestovskyy Cc: "Yang, Qiming" , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20170407082407.GA11816@bricha3-MOBL3.ger.corp.intel.com> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1490356325-15434-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> <189fbba9-f97b-9bb6-e9fa-9669fd0ffa0a@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <189fbba9-f97b-9bb6-e9fa-9669fd0ffa0a@caviumnetworks.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 08:24:13 -0000 On Mon, Mar 27, 2017 at 10:38:13AM +0200, Andriy Berestovskyy wrote: > Hey Qiming, > > On 27.03.2017 08:15, Yang, Qiming wrote: > > I don't think this is a bug. Return errors when configure an invalid max_rx_pkt_len is suitable for this generic API. > > It is not a bug, it is an inconsistency. At the moment we can set > max_rx_pkt_len for normal frames and if it is out of range a default value > will be used instead. > > IMO we should expect the same behavior from the same function for the jumbo > frames. > > So at the moment we have: > jumbo == 0, max_rx_pkt_len == 0, result: max_rx_pkt_len = ETHER_MAX_LEN > jumbo == 0, max_rx_pkt_len == 1200, result: max_rx_pkt_len = 1200 Is this really the case right now. My understanding was that when jumbo == 0 max_rx_pkt_len is ignored. At least on Intel NICS, I believe the max_rx_pkt_len is always 1518 unless jumbo frame support is explicitly enabled. [Perhaps the driver maintainers can confirm this for me.] Regards, /Bruce