From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 1C18C2B9B; Mon, 10 Apr 2017 04:22:28 +0200 (CEST) Received: by mail-qt0-f196.google.com with SMTP id v3so8320353qtd.3; Sun, 09 Apr 2017 19:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bwvp1LCP8M83Lcxx8gfXptTrB0BaCYYHDfgQDOfu5Rg=; b=dWAgxpN4K/DPPhdJyGHt7zZyZJlg7llefCBkbEliRmPrmwxHqCwhwt9hN8UW/iwCUe 3F+ybqIkrA838ej8+EHTPPxp6l0dR1lWnuCZBOOiQQWFXHVlzcAREGWvztN4o+twEOZ1 LvvnNOa2yFemSskOmub3Eagj1VsJ5HUjzkwNHkbOAeZEkoz9co52EQjBwt5v1DFhuIND ThmOa0JX/a3aaDJU6rIIY9qg4aaDXlHbS2EGp+SWf4QAmzt3GIVj5awbOiEIq8vufHoE iJhG4tR/83WjVQmgZsuBufW+I2dP0S6+rskqAbSGqmIe5gNr9I3Vr3dGdl9MDQeDqPdk Nw0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bwvp1LCP8M83Lcxx8gfXptTrB0BaCYYHDfgQDOfu5Rg=; b=epk0e3ZVOCHM3MKlVLzTnNV7g3ZUUYpwxTKYK65ew3+c1cT3P4y09hbQTTTTqKQgio wZkAEoQCpBFahQ2PFT5vGmVho6J1ta1klJJOqBbm5ZA93iWodh9aY0g+FlnQoDzneztq K7KvH5TVHQWWgyxDHzBlJV4FTEPTN7uMbE/GMXvY6pEXRaBh6pTznSycD7E1eaTqEoBN tmWT0VDvsw0a3J9GA5nYhfxv7UVuibL1a4CK5bO7Z81i2h18PzeqSK/r6uzqAL9Smc67 TMcxQw4YTA1l3fe07RMvs1ozQFa7iPTL0W8sqk0YOtOmoOnP6rR+6eYMEfnSDq+c/NeP Yhog== X-Gm-Message-State: AFeK/H0L6pAA8hFv/lozWjMc1/bRYyIjsbdwTZQyTKfhbAlwH9L5ibX4JjPQBbTQaC7Bug== X-Received: by 10.237.32.238 with SMTP id 101mr50236410qtb.162.1491790948425; Sun, 09 Apr 2017 19:22:28 -0700 (PDT) Received: from gmail.com (pool-173-73-178-112.washdc.fios.verizon.net. [173.73.178.112]) by smtp.gmail.com with ESMTPSA id r60sm7914844qtd.53.2017.04.09.19.22.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Apr 2017 19:22:28 -0700 (PDT) Received: by gmail.com (sSMTP sendmail emulation); Sun, 09 Apr 2017 22:22:26 -0400 Date: Sun, 9 Apr 2017 22:22:26 -0400 From: Eric Kinzie To: Ilya Maximets Cc: dev@dpdk.org, Declan Doherty , Heetae Ahn , Bernard Iremonger , stable@dpdk.org Message-ID: <20170410022225.GA5162@roosta> References: <1491577632-31289-1-git-send-email-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491577632-31289-1-git-send-email-i.maximets@samsung.com> User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH] net/bonding: allow configuring jumbo frames without slaves X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 02:22:29 -0000 On Fri Apr 07 18:07:12 +0300 2017, Ilya Maximets wrote: > Currently, 'rte_eth_dev_configure' fails on attempt to setup > max_rx_pkt_len > 2048 if no slaves was added to bonded device. > > For example: > > rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id) > conf.rxmode.jumbo_frame = 1; > conf.rxmode.max_rx_pkt_len = 9000; > rte_eth_dev_configure(id, 1, 1, &conf) > > Result: > EAL: Initializing pmd_bond for eth_bond0 > EAL: Create bonded device eth_bond0 on port 4 in mode 2 on socket 0. > rte_eth_dev_configure: ethdev port_id=4 \ > max_rx_pkt_len 9018 > max valid value 2048 > > It's expected that slaves will be added to bonded device inside > 'rte_eth_dev_configure' and proper 'max_rx_pktlen' configured > for all of them. > > Failure happens because of hardcoded low value of 'max_rx_pktlen'. > Increasing of this value to ETHER_MAX_JUMBO_FRAME_LEN will allow > above scenario (attach + configure). > > It is important because it is the way OVS wants to work with > all DPDK devices (including virtual). > Changing the default hardcoded value makes no harm because > all the slaves' related code uses only 'candidate_max_rx_pktlen' > variable. > > CC: stable@dpdk.org > Fixes: 6cfc6a4f0d61 ("net/bonding: inherit maximum Rx packet length") > Signed-off-by: Ilya Maximets > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index c398fdb..0c8cc40 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1689,8 +1689,9 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > dev_info->max_mac_addrs = 1; > > - dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen ? > - internals->candidate_max_rx_pktlen : 2048; > + dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen > + ? internals->candidate_max_rx_pktlen > + : ETHER_MAX_JUMBO_FRAME_LEN; > > dev_info->max_rx_queues = (uint16_t)128; > dev_info->max_tx_queues = (uint16_t)512; > -- > 2.7.4 > Reviewed-by: Eric Kinzie