From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4B8E82C23; Thu, 13 Apr 2017 03:42:20 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 18:42:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,192,1488873600"; d="scan'208";a="1134723726" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 12 Apr 2017 18:42:18 -0700 Date: Thu, 13 Apr 2017 09:39:24 +0800 From: Yuanhan Liu To: Stephen Hemminger Cc: Xiao Wang , dev@dpdk.org, stable@dpdk.org Message-ID: <20170413013924.GC7333@yliu-dev.sh.intel.com> References: <1491907468-68207-1-git-send-email-xiao.w.wang@intel.com> <20170412143925.0916e609@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412143925.0916e609@xeon-e3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix queue notify X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 01:42:20 -0000 On Wed, Apr 12, 2017 at 02:39:25PM -0700, Stephen Hemminger wrote: > On Tue, 11 Apr 2017 03:44:28 -0700 > Xiao Wang wrote: > > > According to spec, we should write virtqueue index into the notify > > address, rather than 1. Besides, some HW backend may rely on the data > > written to identify which queue need to serve. > > > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Wang > > --- > > drivers/net/virtio/virtio_pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > > index ce9a9d3..b767c03 100644 > > --- a/drivers/net/virtio/virtio_pci.c > > +++ b/drivers/net/virtio/virtio_pci.c > > @@ -504,7 +504,7 @@ > > static void > > modern_notify_queue(struct virtio_hw *hw __rte_unused, struct virtqueue *vq) > > { > > - rte_write16(1, vq->notify_addr); > > + rte_write16(vq->vq_queue_index, vq->notify_addr); > > } > > > Yes, this looks correct. It is what Linux and FreeBSD drivers do. > > Reviewed-by: Stephen Hemminger Applied to dpdk-next-virtio. Thanks. --yliu