From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9244D2C23 for ; Thu, 13 Apr 2017 03:48:37 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 12 Apr 2017 18:48:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,192,1488873600"; d="scan'208";a="73325374" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 12 Apr 2017 18:48:35 -0700 Date: Thu, 13 Apr 2017 09:45:42 +0800 From: Yuanhan Liu To: Sagar Abhang Cc: mtetsuyah@gmail.com, dev@dpdk.org Message-ID: <20170413014542.GD7333@yliu-dev.sh.intel.com> References: <20170406055112.GQ18844@yliu-dev.sh.intel.com> <1491524797-27299-1-git-send-email-sabhang@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491524797-27299-1-git-send-email-sabhang@brocade.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] net/vhost: stop dev in close and address mem leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 01:48:38 -0000 On Thu, Apr 06, 2017 at 05:26:37PM -0700, Sagar Abhang wrote: > Move the call to stop the device inside the close routine because close > needs to stop the device if it isn't stopped. > > Free the allocated queue buffers in close instead of doing so in remove. > Original code had these clean ups in remove which was causing memory > leak. > > Signed-off-by: Sagar Abhang Applied to dpdk-next-virtio. --yliu