From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 037805587 for ; Thu, 13 Apr 2017 11:43:02 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 02:43:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="1134955747" Received: from sivswdev01.ir.intel.com ([10.237.217.45]) by fmsmga001.fm.intel.com with ESMTP; 13 Apr 2017 02:43:00 -0700 From: Bruce Richardson To: olivier.matz@6wind.com Cc: dev@dpdk.org, zhihong.wang@intel.com, Bruce Richardson Date: Thu, 13 Apr 2017 10:42:56 +0100 Message-Id: <20170413094256.6442-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.8.4 Subject: [dpdk-dev] [PATCH] ring: fix return value for single dequeue function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 09:43:03 -0000 The error return code for rte_ring_dequeue() function should be -ENOENT rather than -ENOBUFS (which is the error value from the enqueue() fn). Fixes: cfa7c9e6fc1f ("ring: make bulk and burst return values consistent") Reported-by: Zhihong Wang Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index 6642e18..d4d61b7 100644 --- a/lib/librte_ring/rte_ring.h +++ b/lib/librte_ring/rte_ring.h @@ -841,7 +841,7 @@ rte_ring_sc_dequeue(struct rte_ring *r, void **obj_p) static inline int __attribute__((always_inline)) rte_ring_dequeue(struct rte_ring *r, void **obj_p) { - return rte_ring_dequeue_bulk(r, obj_p, 1, NULL) ? 0 : -ENOBUFS; + return rte_ring_dequeue_bulk(r, obj_p, 1, NULL) ? 0 : -ENOENT; } /** -- 2.9.3