From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id C6A3C316B for ; Thu, 13 Apr 2017 14:05:16 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id c55so34338982wrc.3 for ; Thu, 13 Apr 2017 05:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7tNcsFFzRqJEXjGY03XMOmdkFSAuqO37WTKS5u4OIyc=; b=JzIWGPajMgpGmCEq6PWVOs3aepusR6KtQ2/DEVC4iVnGkdiDo9MIyx1h3t87NZve0w 2X2uTO45annhjHKsIXjU/sT3ZU6U5/OhH//y4AcLWcBnc1iDjDGJRREjwbodzJjCDPNt 49rp6J8LelX+pkdh3mrTcWN00WBY71Sfwv48zSsFrO0vbUe18gWOZfRc/H1afCECYMzG UoV0X7e5teGEeOStk445VtVUqEC3SLQ4dZp3qfVAoNpvj0O/rECgwZSKQ97b8nWj3c+s XpgGT4fD1VpjFr09hZM9hJTE9zPWqqpjHjnN4BrFxWs8W6EKeIbn4CE5obxYUzxqQPFJ exxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7tNcsFFzRqJEXjGY03XMOmdkFSAuqO37WTKS5u4OIyc=; b=ixxAJOG3GFkIuwigMJUNhnWtZq+gBc+E9ucfd3O/K4EuQAwBzqFqEBE4ykkmOpOCPt +pAo9ftKR7m7OyzMczXtztFg9nEBYWwqMC/6UgGcSK20SHao6ihWTkp21saXqSFYBm6j 4tyWtI3pBblrlCdaymCcyzU/cqxZmZSojFrK8xNvMLDhncJdIQvFDNPecfOa0sUtkPUq ljvpZvvzSgGiPDbmgQTRxuMU+uYOCStSIVmRe2rVPJz3ztLAhiAlmFntWBhhdafcAT+6 hsdQkFkAmbDY7FYkJst/muxjg4NAb3/Q5AqKmLZFUK3Kousj6L9Y0tc+l9MNbD/dtIdm mXtA== X-Gm-Message-State: AN3rC/4kTEZugcMkzurqtsEuc0k2xw5oLTk4WIBAiQLCseQXGQ9mZOL+ FzDuisSrnzxezJDS X-Received: by 10.223.155.134 with SMTP id d6mr2430577wrc.113.1492085116413; Thu, 13 Apr 2017 05:05:16 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n5sm8214063wmf.32.2017.04.13.05.05.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 05:05:15 -0700 (PDT) Date: Thu, 13 Apr 2017 14:05:08 +0200 From: Adrien Mazarguil To: "Myers, Charles" Cc: "nelio.laranjeiro@6wind.com" , "dev@dpdk.org" Message-ID: <20170413120508.GD3790@6wind.com> References: <1492069426-123358-1-git-send-email-Charles.Myers@spirent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix rx not working after mbuf alloc failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 12:05:18 -0000 Hi Charles, On Thu, Apr 13, 2017 at 07:52:34AM +0000, Myers, Charles wrote: > I ran into an issue where the mlx4 driver stops receiving packets when mbuf allocation fails in mlx4_rx_burst(). > > This issue appears to be caused because the code doesn't recycle the existing mbuf to the sges array > when mbuf allocation fails as is done in the code right above it which handles the > (wc.status != IBV_WC_SUCCESS) case. > > Copying the code from the above case before jumping to repost fixes the issue for me. > > Signed-off-by: Charles Myers Thanks, this addresses a very old bug present since v2.1.0. As a fix, the subject line should contain the word "fix", something like: net/mlx4: fix Rx after mbuf allocation failure And since it's a fix: Fixes: acac55f16412 ("mlx4: use MOFED 3.0 fast verbs interface for Rx operations") Cc: stable@dpdk.org Please also make sure the commit log is formatted according to the submission guidelines (50 chars max for subject line, 75 chars for the rest (except for the Fixes line), yada yada - see check-git-log.sh). > --- > drivers/net/mlx4/mlx4.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index aff9155..59d26fe 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -3169,6 +3169,9 @@ struct txq_mp2mr_mbuf_check_data { > /* Increase out of memory counters. */ > ++rxq->stats.rx_nombuf; > ++rxq->priv->dev->data->rx_mbuf_alloc_failed; > + Another nit here, the above blank line is unnecessary. > + /* Add SGE to array for repost. */ > + sges[i] = elt->sge; > goto repost; > } > > -- > 1.7.9.5 > Otherwise, Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND