From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EF203316B for ; Fri, 14 Apr 2017 06:27:21 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 21:27:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="248799692" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 13 Apr 2017 21:27:19 -0700 Date: Fri, 14 Apr 2017 12:24:23 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20170414042423.GI7333@yliu-dev.sh.intel.com> References: <1491551860-15005-1-git-send-email-jianfeng.tan@intel.com> <1492078287-138040-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492078287-138040-1-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix cannot get initialized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 04:27:23 -0000 On Thu, Apr 13, 2017 at 10:11:27AM +0000, Jianfeng Tan wrote: > The feature negotiation in virtio-user is proven to be broken, > which results in device initialization failure. > > Originally, we get features from vhost backend, and remove those > that are not supported. But when new feature is added, for example, > VIRTIO_NET_F_MTU, we fail to remove this new feature. Then, this > new feature will be negotiated, as both frontend and backend claim > to support this feature. > > To fix it, we add a macro to record supported featues, as a filter > to remove newly added features. Yes, this is much better! You now don't have to worry that virtio-user will be broken every time we add a new feature. Applied to dpdk-next-virtio, with the title changed to "fix feature negotitation". Thanks. --yliu