From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A0A62DE0 for ; Fri, 14 Apr 2017 10:41:11 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2017 01:41:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="74048245" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.17.245]) by orsmga002.jf.intel.com with SMTP; 14 Apr 2017 01:41:08 -0700 Received: by (sSMTP sendmail emulation); Fri, 14 Apr 2017 09:41:07 +0100 Date: Fri, 14 Apr 2017 09:41:07 +0100 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170414084106.GA45668@bricha3-MOBL3.ger.corp.intel.com> References: <1492072587-121343-1-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492072587-121343-1-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v1] lib/distributor: fix segfaults in flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 08:41:12 -0000 On Thu, Apr 13, 2017 at 09:36:27AM +0100, David Hunt wrote: > A segfault when flushing packets has been revealed by further testing > when using distributor in single packet mode. This patch resolves that. > > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > > Reported-by: Yong Liu > Signed-off-by: David Hunt Hi Dave, I think you could do with giving more details in the commit messaage on how/why the error occurs and how exactly this patch fixes it. With expanded commit log message: Acked-by: Bruce Richardson