From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0054.outbound.protection.outlook.com [104.47.36.54]) by dpdk.org (Postfix) with ESMTP id D409629D6 for ; Fri, 14 Apr 2017 14:38:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5W3rQKErlw7ZZOgAKxfdfQY7tRrgwYkUw3JgGP8pQ8s=; b=Zuplubq918DZ1U8eg4ZYfNjoMdGJza3mf4P0y/Lt3sAYHeEHTpZe7hGiBuAIMnS/NDxObCbkd40c44mkqJdaC/+RbdjzOGmjvxd38HrlmZdE5kF8TXut0m8TniWqIyouDAjB+P2EAwaqhRx7RjXIDfT55lfGbxF6kZFexd9JiiQ= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (111.93.218.67) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Fri, 14 Apr 2017 12:38:17 +0000 Date: Fri, 14 Apr 2017 18:07:56 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Andriy Berestovskyy , Maciej Czekaj , dev@dpdk.org Message-ID: <20170414123754.GA16532@jerin> References: <1490968669-9161-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> <20170403151315.2yrchyh4fgpjn3ha@localhost.localdomain> <49a27795-e6b8-7510-beda-2eb4c533b874@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49a27795-e6b8-7510-beda-2eb4c533b874@intel.com> User-Agent: Mutt/1.8.1 (2017-04-11) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0058.INDPRD01.PROD.OUTLOOK.COM (10.163.199.30) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: e84175b2-4823-45fd-ea0a-08d4833321b9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:VGoa0SPLZT21YvRNulizRQw4nnjlPbDLEmZdVUENQPI8GG/H4aqJAze6P21kHLfeIuH9VAc45azfxzVHjVdjmSoWcyXwDZhMJZ6iXouz7+MUmU6bS6toI25dVbtcGT4vJ/+/0LrZ0GCOcV60JYTirssGb9aH1zeW/QghUUZyesWS9EQEJcj8Zh1UZ2FSbDcab1qUl7av2ry1FXvliakLQ+EHe3f3geAhi0OLObK+ddHXmCvvJsOMR9+amggspqqu1jMdJl1jTmf2c7z0UfKST9xuz3NGufnYddWfGdic258HmJczww9hrTKbx4KuDTaZ2J57vZNMq6ZvbwKneBYVkw==; 25:wmsoXwl1SH2xUxOBIZZhsdJ9SFaeKVx8Jqtw8aVMJ+IwwAGnV8yvN0p2KS1lchmNbAmXRbkve2RkrfsMstIB/64Sly8VjnVPZj+bNSpIT9JD45M0nk61wMHhCoEnyFu12dJh0luuPvwT/3diW19Hhycawacq7ye7WSVi48R45QGMwD2EfbQGmAui6we9hFy8wlROZGWfSxeoXXlGbmwnrisoZUxFWLz4lW010bKDabBBtLjMZQSgPupj8d0qVgrF1c4bB1VgfZb4HHImKQrrXefwio27cSj16fRc1GmQtWuoFPYTRS0sWM8IILnyx1LZZ517AthI2h4iEpxKZ4zDy5RDR/Jhj3n8wqf/ZjH2RPObiGPn79N2zYMezeU9/gjNhvhwsCr8CdbtfjBnTUIH8yV34mFDb+yhiZnGumankxbJyaf3WouZe83NCgTQED5kSTR1rTUAvUVI4yYTty8GXQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:I6Osz+gHls5EYeAPFV0BJk52piQqtLebyMhJh3CmfDyFD+Hj46v3CLQExIweKyN6viBbMv96k0WrdUBWb12XRPvCdZRHtYO+lbqGo0kvBVbcNPX/7Hj5ucLSioBVeNDmZm9fJXDGPOhTd0raBvAGptbwxNPAM3x4imiwn0Xr7Go65THkkzJMhJy6kCckDD3bCJcljkTnpzfd2wUncbmET356Tj9P4PXpi0I/UYI6Tas=; 20:KGmwz2/GZCzz2+O64LwSl9ijD/5ooLw7dhggJeZio4EMcNPBHV0euNp1IGS+QLYb1Xue585nIzotrYK+pNk0UxQIt8KnDivKSsiriC71vh6u2tY90lIgAk7MeopaqK2tsR3SRRPf7sLwvXJ30wAoXolsbWbPY4GLrv/PSFoOeetAeUlMvyr+5LFEAEm+bQli+KnO8v7k8BGhqh6X4c+ygZvMtcLWK3EDFRk8aQJyBBSxjuqZQMCSd6B6AlfThkfFOo8dY+iOEhPU+R2AuJHkgLZC273f1kwD/jo2RuCP5KHP+kxIQWY46Mc6Kp14BQKplZAMVws5YNtTmMCWAJ+FkmYQlJ6Oo42Q9U3mnBqR5MxtzwpC9u+YGzWMcXkB5A8mX3cXTOKcrMn27k07SZt34FBirTdcj5EIjRvHFxSNnKzDOdE5DpLy5yIyXlNJPIW7tMv2bg0xMNTZzQ2/s6bYZ4gqecrzw9dQ0rAxjp11YIAeBOUK5Ya4uVO3gnoRAvOugghZT+9U71ik1nzQ0fNiGa1MuFv6B8c1xSN5I1Ybx/S/A/WolO1+9ttMJZ9+b5nmaTnfBX446K1M3d2QzilqaH4IhtQgw4Jspki9oEYIeBQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:lHO9cpbNWsPyVS7MuuUWn1S8UQSd6SRYq5701OkfTFcbp5AnEMxgniKHm8wzgIEkC93wBq6XFx38smzquMDZYQDmNqLpkckgcbkTnSFSw/OgWnEows86Q3GoDO94lZahnWvm7noFfpWYmJFcMi8flNwLAsb4o9f6uZuUjKoZoIyysGI40+NrsHZUXjje6PGaRROsZloFZndmLVDcPM9axchwXtwCVlUtjJ8d1/eUqO1IYMs/nNPw3qL01AnM0O93/QS5D6tem8++lLbLK607EMoJFoWMfFe54jNh3ynnvSTMuXJaexcwpohzruxqav7DImoy5CB3XdFdznqX7Q1SA8P48WhsggWEywV8v0OmauLpDOCrWBb1uBjDlKg4cyzuxvbYXa5lP7pttUrPtj/yAXWRBHMSXcLN9HgsKflq+fVHOTsIZ+2BBNknw4j2MVf5z8drrrnek8wazZVtqpHqb1Mwjom1gY3RfT8w155QGy/lT5dX2Scss3wdw9QM5WtHzRAJYUwu2JLtSgBkCiRqDO6AYguJp/1SocqSubqM05C6z31tQH5b2UJqlWwJzZwpcfA98XiIlF7VzEuINaU7BLCckA74iKel4LShp4PVeOEs/XRE4A6/vGEgG8cpsgzBJDZca4wqeFkhoTqSmJZlbvpxSe0y81lXmJTFFRFgTVdvyZJF6ZklNGxO9/n4pKtBrTfKuL2a5wtvL983AU6ilEQKL3Z9uYSlCQYuJSPbc5d0KAlSoXaTP6ADT+02T1yDTALSIUdA+yqrkK/oLxSEMQ== X-Forefront-PRVS: 02778BF158 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39850400002)(39450400003)(39840400002)(39400400002)(39410400002)(24454002)(13464003)(377454003)(6246003)(6496005)(6306002)(966004)(55016002)(53936002)(9686003)(229853002)(23726003)(54906002)(1076002)(5660300001)(33656002)(7736002)(6916009)(6666003)(5009440100003)(2950100002)(42882006)(3846002)(2906002)(305945005)(6116002)(4326008)(53376002)(81166006)(38730400002)(8676002)(110136004)(66066001)(68736007)(25786009)(47776003)(53546009)(42186005)(189998001)(33716001)(83506001)(54356999)(76176999)(50986999)(50466002)(4001350100001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:jerin; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:+2YVVSvjrIkNwku0B469x7n7ygYMhKetHCSaJH3?= =?us-ascii?Q?fvEAhZhA7C+UigJaVioZfoALLy1R2fzOtHMXeVkCNYBjLDDiWOQgxDFKNUyo?= =?us-ascii?Q?o5VC722TOVsPTySnh8ZDTdqri1sD3OAjSxcKlpwHRIR7VewCYNmsnt9XZ2qJ?= =?us-ascii?Q?1ll4CQ+YxFlIQUUyCJwEj2XlzEzqzXYHpm5xKjq8zVpooJjeg5hl+yJYWjd8?= =?us-ascii?Q?bBO27VQvxmzPkjhSh0+g54elrwAo8V4tNDdRX4uyI+sgGTnJmWIWpNoRh5/7?= =?us-ascii?Q?TW2RmVupAa1JFCFRHqKVySWlPfRWXuhDiZ8C5l3DcJ0YAk78TS5pLubXHBM6?= =?us-ascii?Q?GGZApZpHLieMfNNCoNP99f0Ny+BQ+z/dOYREGNaAGzMpAAHP7e71muM4hj48?= =?us-ascii?Q?tfGuhTa42vIQbYEQqaXlBoPoPoy2jFhCxzfvFVfTUUrI1KBTHYIQIubzCk/y?= =?us-ascii?Q?Mu3c43E7UqnGPT7knPKycWVe2ys9CmX8hc3+qRU34T0kO9DbDhg+kh6dqCO5?= =?us-ascii?Q?zxtup2Jw9t+fDTga2MMgaWkrOO3ZBTvsHtrDILAqZkMJOn4qxt0TQ8tphXJl?= =?us-ascii?Q?0/znHK509qYZ07P6ZVx8uGQ+OB/IqmHzk27LCqg/cULZk3lOcOnDGNmxFfzP?= =?us-ascii?Q?TUbLzID5uw/58Qzp9ZwxcAcrBHYHlswYyLg9maxHF3cPVDa/TPiI8hY6bUjI?= =?us-ascii?Q?A2rLblROJh/f0JHBCjDCZy3booRszvEGv/zmXq+xkZQMNdm2A2eYkDUrUSmo?= =?us-ascii?Q?V5Nd47oXY0yD/jFU/Pk7+HK2djfJxAKptOVeWjYFu082EgHokngW3k+GLXzj?= =?us-ascii?Q?JMJeKes0GX8N194h0Owze2692HxUSZ4VNBOyBoZgq/kuqnYl8aO1bX2l5rFI?= =?us-ascii?Q?3BrDfbACiMWHTAbZ6EXNetrMyImB22GEidG1gUhi/gnSkJ468LBC4KRCYLAI?= =?us-ascii?Q?y4ha73ht1u82Ptatu5IMK0mvQIks2INd5i46ICsv9zgvR51MJQexhHhWj9F6?= =?us-ascii?Q?Jgmr7oxj5os1jcA+QaZVixzGbYW3ujfnIHDYcdr7zPH3Hc8ut/12YRXtHQN3?= =?us-ascii?Q?3vSutENGem/qo57R3zTkZqsie2lq8iBjebD6EqHtF9UJ+Z2tUrWspoJkTj/i?= =?us-ascii?Q?PefGgsASiNi+O0UASjZZkkzIrXBmLHyzju5H6JZjJaRbZDkqxSt9yibk7/BM?= =?us-ascii?Q?1mwIqolFlqvtFT3fLN80/ObMc2eZierAB7kUKDxurCzwmik9SvNWOsunnsmF?= =?us-ascii?Q?KCW7PpjmxGnUjR5Xc5tEe2EotC9L38vS98bZT5MIFit9XfDmZJBY3Na/mSYl?= =?us-ascii?Q?fGJ0i2Kb/gbgTmCBAyPW1ru316ICSiOvhznFlzB2CTBJY?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:sZQxep665swjZhX/ztHulYaKSQnpalPfEG+ELC8IWEIBcO4z2GsBnSTkDiy4RMFzx/ZxjuLr6aBvtKrEwL6flkXwZjOzsStnxiOHON28LNUqNx6HUQ+urgPiWAy41JNHWSOnoQWTRzdc5hept2MH9zagjydq6BfY9mR+/exQ/81N88FZDs/FZHZeN9nFJ3W+iBA/uhOPhViY4z6jYG9qFKlIcE8Gd3EcqJ9y1p9fMtQVcv0flQTgO5V5AxthK/Bm6sJKMEnJ+D0a3l2cANKyMSJEL7/jEAuVnO67+Ta5FguRNowqraM4TpGcPYCWJmoAZiathFRwu2L7Ivfas+cPJIZJR3+e0f9uI6kwe4A2mxTN0HRWe5tBReyr44yoVjCePgsND71aOPRxCgcfsrsZi/yGGdV8PkdDvWD7uWn71n8v96btq0b896ISmjL8VTzypx/ndMWxpQFhqnw0ciPqHA==; 5:XXNB8DLOaAIGgxwQva7L9F5/mgFNuCfDxAkuhSAQoVtmA/KXt/viTmMyk3cYK24TKVoVbBLA9qrNtzc2t3GPR8e9MadqwgOSDzBO7s+aIqmwrHmFsUtyRL9qdPhcxZo1zMIRtm3SejhN3XQNBGMzBw==; 24:cMK6qz4KFR5T6BlQOgFNaKB0zRJfUmF+uvzgTLlWjmbZk3xPiuxTQtf0AMRXM6+/U3shz7ow726MMy92TskE5heZ93XxU8u7OXXr8m4bKOo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:ND0UULDC+dyO7pd7Pyw/sBHH74z/7kV8DoB0GL5eeMN+31Ea9o8hkL3uJaTpDVNigBerzWnBQmacCxa8kn8mJD+dRX652xWYP5ZRcPAN8xnVRhJtxZNGvr8EjBF+Xp+glHKzn9uxilR/OyVZHA9xhuur0mWA64JeJUh4dSFXIe2+8OWUB+5FUdPsag1CTMMUBtMmFP+e/ko3whLm7swAD2YxHHlecxWr8mF0X2oWP1kxNH9KYgctPLgzlBa4JYjGT6kj2aSEwun3iagHZZ0WG1VpX26ANEo4JwGPK5PvI3rWAoSV5gKsPRcBS4C9d0R209hQh7ZQIm7P2qmQjJIKzw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2017 12:38:17.6005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: add empty link up/down callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 12:38:23 -0000 -----Original Message----- > Date: Thu, 13 Apr 2017 12:04:51 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Andriy Berestovskyy > > CC: Maciej Czekaj , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: add empty link up/down > callbacks > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.0 > > On 4/3/2017 4:13 PM, Jerin Jacob wrote: > > On Fri, Mar 31, 2017 at 03:57:48PM +0200, Andriy Berestovskyy wrote: > >> Some applications and DPDK examples expect link up/down > >> functionality to be provided. > >> > >> Signed-off-by: Andriy Berestovskyy > >> --- > >> drivers/net/thunderx/nicvf_ethdev.c | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c > >> index 1060319..984c218 100644 > >> --- a/drivers/net/thunderx/nicvf_ethdev.c > >> +++ b/drivers/net/thunderx/nicvf_ethdev.c > >> @@ -1924,11 +1924,25 @@ nicvf_dev_configure(struct rte_eth_dev *dev) > >> return 0; > >> } > >> > >> +static int > >> +nicvf_dev_set_link_up(struct rte_eth_dev *dev __rte_unused) > >> +{ > >> + return 0; > >> +} > >> + > >> +static int > >> +nicvf_dev_set_link_down(struct rte_eth_dev *dev __rte_unused) > >> +{ > >> + return 0; > >> +} > > > > > > Since the VF drivers can't really initiate link_up and link_down and > > other VF drivers like i40e VF is not setting this callback. I think, it is > > OK keep it as -ENOSUP(which is default). > > > > Since Christain Acked on the fix on the usage of examples/ip_pipeline > > application. Probably we are OK without this change. > > Any update planned to this patch? Should I update this as nack? > You can mark as "Not applicable" in patchwork. Thanks > > > > http://dpdk.org/ml/archives/dev/2017-March/062704.html > > > > Any thought from ethdev maintainers? > > > >> + > >> /* Initialize and register driver with DPDK Application */ > >> static const struct eth_dev_ops nicvf_eth_dev_ops = { > >> .dev_configure = nicvf_dev_configure, > >> .dev_start = nicvf_dev_start, > >> .dev_stop = nicvf_dev_stop, > >> + .dev_set_link_up = nicvf_dev_set_link_up, > >> + .dev_set_link_down = nicvf_dev_set_link_down, > >> .link_update = nicvf_dev_link_update, > >> .dev_close = nicvf_dev_close, > >> .stats_get = nicvf_dev_stats_get, > >> -- > >> 2.7.4 > >> >