From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50085.outbound.protection.outlook.com [40.107.5.85]) by dpdk.org (Postfix) with ESMTP id 9249A2BB1 for ; Fri, 14 Apr 2017 18:52:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=N9LsaFcWi/ySLlqcozoRxSZw5vJahMNL7oRSw6ChhNQ=; b=c8qvqkpT49tavnTcnD/zm3e8PKQUVC6zxeziRdn1MmVHQlm7AaXlnTfvFncUs6bEscxluhHRbe3HMBuxJ+V5PQ42D8ByQFGr7pMDYFevCKtBv2/FYENeqTIdxQm8F8ntr2Pssao9SAP64nbPwiryimxoY21qKRAPP4JF5vvXHkQ= Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=mellanox.com; Received: from mtidpdk.mti.labs.mlnx (12.250.235.110) by DB6PR0501MB2456.eurprd05.prod.outlook.com (10.168.73.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Fri, 14 Apr 2017 16:52:37 +0000 Date: Fri, 14 Apr 2017 09:52:25 -0700 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro CC: , , Message-ID: <20170414165224.GB11566@mtidpdk.mti.labs.mlnx> References: <20170413174651.27860-1-yskoh@mellanox.com> <20170414065139.GD14075@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170414065139.GD14075@autoinstall.dev.6wind.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: CY1PR03CA0029.namprd03.prod.outlook.com (10.174.128.39) To DB6PR0501MB2456.eurprd05.prod.outlook.com (10.168.73.137) X-MS-Office365-Filtering-Correlation-Id: a371231f-4eb2-4b7c-cdc2-08d48356a8d2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:DB6PR0501MB2456; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2456; 3:t11YXUoi0dhGeeCugrmz6sIS8TZEaTdEH1xt8WJAuSAcFFxvCCQ9fvezUoonIH3K5a+qLqMC1o9rOneJ7sl2wztFNSsPEM4+qr4phWFJEHvUSTTR1+v5oa7AVlaE6ZffvGsziCCN4iPiGfY/9y1Uz/SCF9W1qz8H0+IwfpC8YHQhMl1A+IpxgcmB81sGJ9tw975NfzIo5i1hy1u2rzzhegHzWfcmveKtgvf02V5u0Je5PAH7ke8oo6RPcpIOoR0dQW03wEO75ApeZy18KNJNbURxbN0WToOv9o6W+mLKP7QPpHfkIO+Lk0lxTmcIE0bnXocW7W/3Bfdy0+BT1h8HpMwuFBkWEVcXEZ5WEZ2ah6A=; 25:NeDqWqhe8cOJ8aW8kJP1zMsAO8Ft2e1Seluq89wl5w3A5WBJPuKN3cRpGn1vzuxXLS3ADYDhcwi1esV6mLvUK+tSwjyV8Ge2yZC+fWtn7MjFMJDtTTljnsmwGrC+Qunop+UKCzeTOczjL1uq/bIyMsDcqI00vCHUebL3TPt2QsLwAHqS6CdlBY9XKUUfw2F+65+IqVHzm2h3uXGvmxF8xsRskANI+0wzgHMiq29skWSCCAgqBIGAdmttbcvLm0LAf6o2DqesLD+oWtcTA/Teglw+5h+fuGd4XMRX7t3A8lkWGD4nJUasPSDKC+5xGpRU9wCXdmYngV/23pfv6ssFUCse4lDbfCi3XWFG/n6BEtVyUnJQmS4eg3Bbu8s3BngzfcNuZ9vf4CPVV3kIiv82yVadZuXaftiMOv+g2Y6ZSjAovfMfdzCM21XxGk4w2B+ZdI/y8yOEHI4UYsl7GBOfug== X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2456; 31:gOQNOunNLEnQCT5nqeQ5+DOriSABrtTA49fDtS/TU0P/jqVnQx2YM3K2+gpcK6CkhO2hBH9ztUxXgveM6NCWoTv+2Q5nhEDYBRODMBh2GWzOYgMiDf12U/IAAerbh9tPDhfG34wyZ88mJMlp52UJ37MYJdetdLuBxu8ctatiDsWpxQvehSMJRJo1wFnlfpi9JQ5sZ7VTmYQUasf1+rXtzR/NK2nPDKJsid6wyPhtT3ci5z/TYEM8LubbJNANYtK9; 20:xF/II08qVDWhdyi2+sLKv0pXa57iD2anPOpO5IVHGISO5hzG5PKwAH6Q2dN2ql+8FUKL7qHEzaE4ZjVFq5OUVNEhVG/7b8tGCgnYyvVV2quVgPIETLldZ7mR6X/idxwufG6IdeXK+/J8qFjsXYnLc4DqfJMR4c4s6T+8Cd+QizDfPtbGcVbsmgUA7ubE3M3UFCR6YhOvPAqKMSUzMZLwRGMkVvXpY0xUTSm+3Jkny+6VkCeFrx0nej1UQ2GzAo/jiE6CepOQcuHsBrvW6EM2B17qt9uRdFR0bTOtR+l6tMJe2/6WehVysoUomoTWO9AI53ncasTFL01zbdprcObukG4swXuf780Ut2KIINiIcfXZfvdQiCsfQsE/QUBxZmSlUh2vVoQPO8dJXDPEg9gNamxODg797OzzwROY5L0f+Y4mLG2M9Jm0gzYR8owhN8tpr3m6GPdR8AON3liCButHs1iBuByrXkb9U3CciKCW0qGZiw/acyJcXfxoabzzSl+J X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(6072148); SRVR:DB6PR0501MB2456; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2456; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2456; 4:ipr7NR3ffMkwlVw8Xcr/MOpt0AZpgaG9w6GN21K2wmd8aLubObPorZAfN8Yz6G1cI2+vUK+gESsygW2Oui/bJX+HxLx0P8kMRIUqB4NpdeExx5ZExCs16BFWdJZ9PurAx/DbKWHx9C15EeIHYmls623pMtyUqM1Qb6fJGwOnBQoJ7WAwXZSdtCy3vxa3H/KRscETuZqF32uiMR+YypNZuf6uHpaP7t1jTAd2RJ925TBfKlmRPZ2uFWYd4Zj7ExNhjNI+IsmwMMnE7IiXqQh8D66Axgj1ZEfC3bGPwotVjLfuGzont4F9SHP2pacL17PH0D/GjL6VL+RHS7hbpt1K2IX/gBukPlX+N7WEv5hLKmi/l45ZZo0jlyCjVlnvJYrgV8sbieDVzEcjBCjfT9Oda1wqOKS5JnzlXElKn5l8hFcLq27v0EGpne6X03rU/G858375b+aXWZa7QyRundvFeAwBRQk3brgp2RqrdnJMQSQur8hgE3+oIcwDovsvkLRYV+ifjR4AMZeyS96/o6Kyg9cqWtoB1XzY8Xx0wnCo8pXZK2ZMWMEOJG5WC5b3kFgJ9JYqxZGfKlm2mnzTJbM+W372QQS6LJPm+UameK/uc8j0XyxV3QpDO+tuKuBAfZ0Gpk7E3xWuURuCU/gLr3fRT/zU5gc66l+WnLDIwymJKpsHq1ldAbXQ6xqECDyCdBFe/6n5ZNy/LKgsrTNWvVlLHYJyLs5TxqzjqeXTxXo7FFs= X-Forefront-PRVS: 02778BF158 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39850400002)(39450400003)(39400400002)(39840400002)(39860400002)(24454002)(22813001)(229853002)(6916009)(6666003)(9686003)(6506006)(83506001)(54906002)(25786009)(5660300001)(86362001)(50466002)(55016002)(4326008)(2950100002)(2870700001)(53936002)(1076002)(4001350100001)(189998001)(50986999)(76176999)(54356999)(110136004)(2906002)(66066001)(42186005)(47776003)(8676002)(3846002)(305945005)(7736002)(38730400002)(33656002)(81166006)(6116002)(23756003)(6246003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2456; H:mtidpdk.mti.labs.mlnx; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; DB6PR0501MB2456; 23:1OW3VgSMgbQ5l7v7MCC691ixrOXwz1YB5Njpy?= =?iso-8859-1?Q?CIVIbVThMCXP82UOyIyhFNdEeVr3n0HLv7yqrL6TtA0Sn0UQVSMmWnvRBq?= =?iso-8859-1?Q?qFOJjJaFCOgjRHphSPRAp8ISo5j0pOEctlFWvvhFCpiWqkr8JXQYRBRhID?= =?iso-8859-1?Q?bdJob7T+Ced7WrcMe0Jym0cTBEIZ9HlHCo9PjzYc7bAkYyAwEaLOfT/cjI?= =?iso-8859-1?Q?Gj2eO6NJvxjt1vE+W+VMMoTOhvQDtjmbvJsJBXYpbnstAZNBhwiReur2I9?= =?iso-8859-1?Q?QVcPIGm8HAeqtAZqv/1RShozALIrziqoes8Bt2YB0MW0k2H8bkr8p5sryj?= =?iso-8859-1?Q?G6KIK4TP79N5ykmAvNnOSlx44iw4jGGTLR/sp6OBzlKLN/jJOQJGCnaqMy?= =?iso-8859-1?Q?W5fYqw86mt4tMFM4xUFqErt1+2+PBVVY0RbEfs4YVsk7nLwvo4YScJnZ6B?= =?iso-8859-1?Q?Uj04GsqWtc+/78cwyUZavFjpLW4gKvgjo4C8E2FY6lGIPvHQgT+hn/a3/x?= =?iso-8859-1?Q?hHRBi4D7M3CFFh5Ntb6Qbk+oavNcRLOaQYg2FAzop3FJlAvOqUF7RkKm4d?= =?iso-8859-1?Q?+Mzh69VeGAY9AinnJgLdigi+WUBsadIjzVdJU8orZoXyV9BsrsbrzIwK9r?= =?iso-8859-1?Q?lKBXWcQjYF6xE+8TdqEyZYIKWqkhP1tpqjUIWJo6NV4LiYiSKO5XFIB3ow?= =?iso-8859-1?Q?G2KJb5Fg9XbWfCGrQM8mXs+5/7AbDvdXtAYuGPqh7gCrAmyibpBAEgNLvn?= =?iso-8859-1?Q?wrwRVPLg8gZXXBswlePBXEvUaUsJKTUexLGkS8hfBUSj60HNcm0yEJ2pke?= =?iso-8859-1?Q?YWVhcbBw/b0nvKpApoYNP7zrlp7zG6miPlkv/vlCJABDuPv3Iy1cmXV7OP?= =?iso-8859-1?Q?6QNK5wvBaoUjkKaBre1Jcb+oxDvLW/dJVVULw3gWm5GE2DfF3awRvEoOsV?= =?iso-8859-1?Q?r6g6i2fKdOB4Hluz0QjvCK4eRtUkrRIRUCCtzMRjsxRd1CNOFRM00/rOLX?= =?iso-8859-1?Q?Xam7yfndfsfFdA9O+fpqYlZ6iKJcblm43JWNsSNBis1yBxOo91XRRBwyTT?= =?iso-8859-1?Q?xrGdkjcghPGOD0oEiW7KMQEVwlccpkN0DE23XrX7XehfUULbdVcimwGGii?= =?iso-8859-1?Q?WnbzQqJQPi3yXU14cgq62+8TGm5/c9B+jel2gWnsIM5MpddvBhZpIX9tjz?= =?iso-8859-1?Q?E25pFKxQg52paguPTeCu8GENJk/7VSgoKa5DkUyGy4C6Jl/0pJ60WevS8j?= =?iso-8859-1?Q?hUpyArUGLbKIYtvaPCk?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2456; 6:ymMrbCtJBBDXuY+3WgkNe1+cunAhSm3Vr0AMFlUvQYaCjsmF55gq7CN2peYtjp7Veu3NsPJUU12SCpMZyVF268JJeXcQm9XldJsnYg3pLU/KBxjGvL5KvniAxumrHXFnKfDPafftn1qfwNWZzh2Yd2a9BsjM/PKJ2ux7gGZcWi7vavrCqBazYXtberkTuzDoG7V6+92xAI8nMEIsTwTi0RzEzbMvS/qKppgNR5cH2Abe2hd7YC/5Ckk6hM91K9m1OwIXNA7bzYhZKz9uuq8rB7UufQ0Eh+o2nk82chR+FDCbOEZUZ91VVV132IcRTI0Z726wwbv+m4nMA00sAalWBlmwFPKqro/r/U/lU5zXSkYUUhVdZNwyKVVJvdLW3z0oQrTjEOCSwjDZstOPEGn1Ou8dyRgac32WfEux6OD9tDgwZk9dL06sFIW/Dt1+Tj09Ls9UwwGKfOPb0wRjkSfWITMXvppk0yd3ZbGkIxlADLs=; 5:5D04uhk6ehX6qFv+3ER6WvpkHCdR42VwEueuPDMUI0EAoASFpoFClQaDuNhN9j6ayM+ODQ/Otmfg1EFSHAWRT+eCuQ3DukWDP1OQE3QS7+ROnzRV89JSMrHuohmEL6m+BjsCo/RBySGj/BwoTYunrQ==; 24:euKnv9GJIcNkZ8s15FS0NKfB9KROfoCFwJHCgbzgYDt2qU754e7IC61pBlzGewHkly5tyu1au9iS5Kjg+xwBYF0x1gPVywVClCo3i6Q11Ds= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2456; 7:qDbu4CiX36G7rdv1Sl/9pkYEINfnfmm5KTG7Fd7E9m/I1scTRT6yQ4reI4Ln2cZEU5n6vcvZINzVqz7rzxND/6qbY5U2DFiA32sE5bnoYtv0ItUQz/b8oxxOz817LEpconm6mnXyhs4c+fHG+NVzRV2lv4JcFYUEqy2BJkmvttca/VgQM3TGICcVg/sdujsrPLyHkQlD0qSC1lyJ/Sn2zbIbRt/ZRCN49lGD7HKcn56pB/2WDXjhdSuFNzmycYXLOQi26TAVo/LV0EU0/A6SmcbdHhiW+jl+TVPr5ZIcDZ5rKZ1StCN36V5yJ6tIHrmPG/pGgZBVIU1pVo9ocBJPug== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2017 16:52:37.7126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2456 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: change calculating inline room for Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 16:52:39 -0000 On Fri, Apr 14, 2017 at 08:51:39AM +0200, Nélio Laranjeiro wrote: > Hi Yongseok, > > On Thu, Apr 13, 2017 at 10:46:51AM -0700, Yongseok Koh wrote: > > Current implementation is error-prone if the max inline size > > (txq->max_inilne) is decoupled from txq->inline_en and becomes zero. If it > > becomes zero, HW can crash due to WQ overflow. > > By reading this log, it seems more to be a fix, no? It doesn't fix any existing bug in the code but to protect from potential disaster by adding new features in the future. Also, there's a customer who wants to change txq->max_inilne in runtime. > > > Signed-off-by: Yongseok Koh > > Acked-by: Shahaf Shuler > > --- > > drivers/net/mlx5/mlx5_rxtx.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > > index 2e208bf96..6254228a9 100644 > > --- a/drivers/net/mlx5/mlx5_rxtx.c > > +++ b/drivers/net/mlx5/mlx5_rxtx.c > > @@ -499,6 +499,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > > unsigned int j = 0; > > unsigned int k = 0; > > unsigned int max; > > + unsigned int max_inline = txq->max_inline; > > Cannot it be declared as const too? Seems it is only read in the whole > Tx burst function, as it a chance to be update in the middle? This is used just for calculation not for conditional expression. So, I didn't think this makes difference. Thanks Yongseok