From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 270BC2C5 for ; Tue, 18 Apr 2017 10:01:56 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id l28so96440319wre.0 for ; Tue, 18 Apr 2017 01:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UtW2g5qayjGjt4iKI+cXnIYEwc+y9bVQPXUHCGGRkrM=; b=vYqGNFJLTwMQK89x1i/XVha0mJaP/zwoOM+6TCB0OQ0jAKSNThOAze9yNVn5AZfWkl GJ0jjIeq42c+waIlH/82l/lscAgwoxwvxnHSq7rwkb5pLNwYtjnykGCgMoGz+ULxWHJO h4PS/UG5dsjkcV7MXkQyrcYb3w5DThI98YjHpEExHijOyLwU35+hMER1EN7TmqeUcaeg VwB+leA8qOcLANv0slJbXURvkKnYBayAkLtoXaU1Jx3Cc4gu745UbakhY0xRn8GT9A41 4B3hmVyVU7UP+rx5JLTewAEnbm70cHn3pOErXabBcBPnhJaHQ77qALVgCCffEdw9YdAD 3pgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UtW2g5qayjGjt4iKI+cXnIYEwc+y9bVQPXUHCGGRkrM=; b=PC2M2Sxiqkp+dX8ggjEghVKn6OIPcksFrt9hI+JpqtZ44xr+IPZcWlQrBaFFrLsP0U fP+eo+KpXqT5hcWYGT1WvriTPJjE+I/KDuNqYibLPRnrCMJnLlnx8umaSU+1o+Bh1+ro pJbN3uv0HI6nwyyN8kFNitEkLtTFX6mHUhQJWEVm6/cOdckIgb9bajqiJac+CQ5qrwxh pwHKARvAzRb40KzDQzfSAsC0BhtHoCuwSlRqAACcCoOYIUtJwT6Z9+lPsM1kDs0xRQqa hjKFRA91OfiHximvJevhc7lHrT89D7P6IVPTQFRppEOOt9rsIUjSMkBfo+F9LfQphbI9 gRSQ== X-Gm-Message-State: AN3rC/7BwA8K/3N/B6bupJ/quNDIBk1GMf4tpDBQ3mYgfeNHid2tCOMQ F2jxq1PUFoSzwbIO X-Received: by 10.223.153.18 with SMTP id x18mr21399195wrb.55.1492502515890; Tue, 18 Apr 2017 01:01:55 -0700 (PDT) Received: from glumotte.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k90sm13822348wmi.26.2017.04.18.01.01.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Apr 2017 01:01:55 -0700 (PDT) Date: Tue, 18 Apr 2017 10:02:22 +0200 From: Olivier MATZ To: Ferruh Yigit Cc: dev@dpdk.org, david.marchand@6wind.com, bruce.richardson@intel.com, thomas.monjalon@6wind.com, keith.wiles@intel.com, stephen@networkplumber.org, "Tan, Jianfeng" Message-ID: <20170418100222.417c286a@glumotte.dev.6wind.com> In-Reply-To: References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> <20170404164040.24132-5-olivier.matz@6wind.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 08:01:56 -0000 Hi Jianfeng, Ferruh, Thank you for spotting these issues. I'm on it, I will send a patch to fix them asap. Olivier On Fri, 14 Apr 2017 16:32:57 +0100, Ferruh Yigit wrote: > Hi Olivier, > > On 4/4/2017 5:40 PM, Olivier Matz wrote: > > Example of use: > > ./app/test-pmd --log-level='pmd\.i40e.*,8' > > > > This enables debug logs for all dynamic logs whose type starts with > > 'pmd.i40e'. > > > > Signed-off-by: Olivier Matz > > <...> > > > index f0ded185b..d98d56d2f 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal.c > > +++ b/lib/librte_eal/linuxapp/eal/eal.c > > @@ -776,10 +776,8 @@ rte_eal_init(int argc, char **argv) > > > > thread_id = pthread_self(); > > > > - eal_log_level_parse(argc, argv); > > - > > /* set log level as early as possible */ > > - rte_set_log_level(internal_config.log_level); > > Removing this line prevents using RTE_LOG_LEVEL config option. > > When there is no command line argument provided, I think it makes sense > to use config option. Currently config option is set to INFO level but > app shows DEBUG level logs, this is confusing. > > > + eal_log_level_parse(argc, argv); > > > > if (rte_eal_cpu_init() < 0) { > > rte_eal_init_alert("Cannot detect lcores."); > > >