From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3A2F62904 for ; Tue, 18 Apr 2017 15:42:20 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id u2so55355263wmu.0 for ; Tue, 18 Apr 2017 06:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Um62cmoBZk+OvOwflOlcWSepzDS3OJ/s9Ra3OmXQUx0=; b=rBiUMlQZiKb9pkbcmpnr7xOhnD+ZF4vSHBpxkkAVvlfcmiu5yDt9fvErs2zjgSlMXJ 8uCiFc61OaWWeiuvQF3wQ+5Q4gVGs3B3YsUrQKmyiE8K/Xs0qOcGMz97IfJzXknDAbA3 sjEB2JCu3LVTssWwjlU2v8pqe8I4cd5g9L8viGHDoHIeQkWSC8I2sw6rl2iplLkQ1Qs8 hjG/2gwYyv6IsNdZ67DVbz4Ai7cpjnLOaP3FI4i/jVA6TSTONuMLY6GRNL5leEG9U1mF nBJfCwyK8AU9KeVpZ5lYP52nmoSvTcVm4nz4YhuKrtUqp+ONrdcZzBUMMcdCP1BylxWM 721w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Um62cmoBZk+OvOwflOlcWSepzDS3OJ/s9Ra3OmXQUx0=; b=Ifw9STc7sZ4bWWqJVq+8mTZQBxZCaK5vG13yRCA3xLWNg2KLyVtHJ5N2tNErtNFMym HBfaYiX1QXVRhhZuIYVr1VAiYYD+/dB/ViSBeB70yxd5C0V+g+Ja+Mec3V2dVMCaLLOF ywLzxrMgy4P3cyPaxlXqUWeyq8Kt7U3CqRD5lqg9NCYoPNE9P8rHq6bU3TRo4UY1dTLe 3v/Nwn7eWgbsLd3sl4qOGCUqPdJZWr92afRdBZXuDLRlimDwnbeMBcFSWhThly9WwaR9 sd+bhePEKv4ymRB8sx42ofy2tQya3auv+QgeHGREqdnZCeYd4/ok7Cph4d+dS1hW/JzX VjKw== X-Gm-Message-State: AN3rC/6SIWADysh7BQ5fBffzdqzcn/wveiuC3u8jzGOwlkImpNlI6ru6 Ab2fVQPcWux+sPSx X-Received: by 10.28.169.15 with SMTP id s15mr13087621wme.2.1492522939927; Tue, 18 Apr 2017 06:42:19 -0700 (PDT) Received: from glumotte.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x20sm18753935wrd.63.2017.04.18.06.42.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Apr 2017 06:42:19 -0700 (PDT) Date: Tue, 18 Apr 2017 15:42:43 +0200 From: Olivier MATZ To: Santosh Shukla Cc: dev@dpdk.org, thomas@monjalon.net, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, stable@dpdk.org Message-ID: <20170418154243.4ec32620@glumotte.dev.6wind.com> In-Reply-To: <20170418083448.24743-1-santosh.shukla@caviumnetworks.com> References: <20170406064549.7966-1-santosh.shukla@caviumnetworks.com> <20170418083448.24743-1-santosh.shukla@caviumnetworks.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 13:42:20 -0000 Hi Santosh, On Tue, 18 Apr 2017 14:04:46 +0530, Santosh Shukla wrote: > Cc: stable@dpdk.org > Signed-off-by: Santosh Shukla > --- > v3: > - Cleanup code change as per discussion in > http://dpdk.org/dev/patchwork/patch/23262/ > > test/test/test_mempool_perf.c | 61 ++++++++++++++++++++++--------------------- > 1 file changed, 31 insertions(+), 30 deletions(-) > > diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c > index ebf1721ac..213fcba5d 100644 > --- a/test/test/test_mempool_perf.c > +++ b/test/test/test_mempool_perf.c > @@ -109,8 +109,6 @@ > goto label; \ > } while (0) > > -static struct rte_mempool *mp; > -static struct rte_mempool *mp_cache, *mp_nocache; > static int use_external_cache; > static unsigned external_cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE; > > @@ -144,10 +142,11 @@ my_obj_init(struct rte_mempool *mp, __attribute__((unused)) void *arg, > } > > static int > -per_lcore_mempool_test(__attribute__((unused)) void *arg) > +per_lcore_mempool_test(void *arg) > { > void *obj_table[MAX_KEEP]; > unsigned i, idx; > + struct rte_mempool *mp = (struct rte_mempool *)arg; as a nit: the cast is not required. > unsigned lcore_id = rte_lcore_id(); > int ret = 0; > uint64_t start_cycles, end_cycles; > @@ -221,7 +220,7 @@ per_lcore_mempool_test(__attribute__((unused)) void *arg) > > /* launch all the per-lcore test, and display the result */ > static int > -launch_cores(unsigned cores) > +launch_cores(struct rte_mempool *mp, unsigned cores) > { > unsigned lcore_id; > uint64_t rate; > @@ -249,13 +248,13 @@ launch_cores(unsigned cores) > break; > cores--; > rte_eal_remote_launch(per_lcore_mempool_test, > - NULL, lcore_id); > + mp, lcore_id); > } > > /* start synchro and launch test on master */ > rte_atomic32_set(&synchro, 1); > > - ret = per_lcore_mempool_test(NULL); > + ret = per_lcore_mempool_test(mp); > > cores = cores_save; > RTE_LCORE_FOREACH_SLAVE(lcore_id) { > @@ -282,7 +281,7 @@ launch_cores(unsigned cores) > > /* for a given number of core, launch all test cases */ > static int > -do_one_mempool_test(unsigned cores) > +do_one_mempool_test(struct rte_mempool *mp, unsigned cores) > { > unsigned bulk_tab_get[] = { 1, 4, 32, 0 }; > unsigned bulk_tab_put[] = { 1, 4, 32, 0 }; > @@ -299,7 +298,7 @@ do_one_mempool_test(unsigned cores) > n_get_bulk = *get_bulk_ptr; > n_put_bulk = *put_bulk_ptr; > n_keep = *keep_ptr; > - ret = launch_cores(cores); > + ret = launch_cores(mp, cores); > > if (ret < 0) > return -1; > @@ -312,26 +311,28 @@ do_one_mempool_test(unsigned cores) > static int > test_mempool_perf(void) > { > + struct rte_mempool *mp = NULL; > + struct rte_mempool *mp_cache = NULL; > + struct rte_mempool *mp_nocache = NULL; > + > rte_atomic32_init(&synchro); > > /* create a mempool (without cache) */ > - if (mp_nocache == NULL) > - mp_nocache = rte_mempool_create("perf_test_nocache", MEMPOOL_SIZE, > - MEMPOOL_ELT_SIZE, 0, 0, > - NULL, NULL, > - my_obj_init, NULL, > - SOCKET_ID_ANY, 0); > + mp_nocache = rte_mempool_create("perf_test_nocache", MEMPOOL_SIZE, > + MEMPOOL_ELT_SIZE, 0, 0, > + NULL, NULL, > + my_obj_init, NULL, > + SOCKET_ID_ANY, 0); > if (mp_nocache == NULL) > return -1; > > /* create a mempool (with cache) */ > - if (mp_cache == NULL) > - mp_cache = rte_mempool_create("perf_test_cache", MEMPOOL_SIZE, > - MEMPOOL_ELT_SIZE, > - RTE_MEMPOOL_CACHE_MAX_SIZE, 0, > - NULL, NULL, > - my_obj_init, NULL, > - SOCKET_ID_ANY, 0); > + mp_cache = rte_mempool_create("perf_test_cache", MEMPOOL_SIZE, > + MEMPOOL_ELT_SIZE, > + RTE_MEMPOOL_CACHE_MAX_SIZE, 0, > + NULL, NULL, > + my_obj_init, NULL, > + SOCKET_ID_ANY, 0); > if (mp_cache == NULL) > return -1; > > @@ -339,26 +340,26 @@ test_mempool_perf(void) > printf("start performance test (without cache)\n"); > mp = mp_nocache; > > - if (do_one_mempool_test(1) < 0) > + if (do_one_mempool_test(mp, 1) < 0) > return -1; We could even do shorter: the mp variable can probably be removed, and directly replaced by mp_nocache or mp_cache in function calls. Thanks, Olivier