From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0D3742C08; Thu, 20 Apr 2017 07:34:19 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 19 Apr 2017 22:34:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,224,1488873600"; d="scan'208";a="1121601220" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 19 Apr 2017 22:34:15 -0700 Date: Thu, 20 Apr 2017 13:31:06 +0800 From: Yuanhan Liu To: Wei Dai Cc: thomas.monjalon@6wind.com, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170420053106.GE31523@yliu-dev.sh.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 05:34:20 -0000 On Thu, Apr 13, 2017 at 04:21:04PM +0800, Wei Dai wrote: > some customers find adding mac addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++++-- > drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------ > drivers/net/e1000/base/e1000_api.c | 2 +- > drivers/net/e1000/em_ethdev.c | 6 +++--- > drivers/net/e1000/igb_ethdev.c | 5 +++-- > drivers/net/enic/enic.h | 2 +- > drivers/net/enic/enic_ethdev.c | 4 ++-- > drivers/net/enic/enic_main.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 3 ++- > drivers/net/i40e/i40e_ethdev.c | 11 ++++++----- > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++++++++--------- > drivers/net/mlx4/mlx4.c | 18 +++++++++++------- > drivers/net/mlx5/mlx5.h | 4 ++-- > drivers/net/mlx5/mlx5_mac.c | 16 ++++++++++------ > drivers/net/qede/qede_ethdev.c | 6 ++++-- > drivers/net/ring/rte_eth_ring.c | 3 ++- > drivers/net/virtio/virtio_ethdev.c | 13 +++++++------ For virtio changes, Acked-by: Yuanhan Liu --yliu