From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id BE1D947CE for ; Fri, 21 Apr 2017 10:11:50 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id m123so10767844wma.0 for ; Fri, 21 Apr 2017 01:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=30F+6oMAG7BtT9vOIHk3r4piKL/Yf9Dq4ayglKR471c=; b=Kf6RBJqhBgK1Jm7qZGNYp/f6cUOFjt1ENToyCWpNfo3raPCJGn2gESdsUTrsvCEo1Z 7hyrg2sX07pAAHuMGMR0l/EjxK14hhArcpaVty6CJWc0DH0CZRe2yeOjqEZYQRKHQu+f pIQ7gOOuC2CpWxXqk+w4ks2mnKd8+nUqpIiOltrNeG2z2ipgGoDvTeU6hCpE5fODxfO+ XaaRL980o0jKy61fONO6gHmHrHexCVJ+UE+1kaU2wQzGcDAkYFKl9MXr3FMAjs2jAwyz YxywcSQt1mvbDq8cN0Ibmtfe+2ZPFo17BkOTf2UjbG/6zq6THfStPdCyd70909qlgVHa 6Ciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=30F+6oMAG7BtT9vOIHk3r4piKL/Yf9Dq4ayglKR471c=; b=JHmQj1Pun+HxdIhuMF9w7VPh4yc7L1TZwyZgb8q6gtUZhkABgPZJ2o9bZChfPOpa1w PYixoBHGcuogWnzZVUlcZJ/yA9q/v1d+Cdl4YpXzfrq+VzV3saLFJ5hPHJSCazTRRAUU Ibuqck58Pt8gNQs3CsAHbmZxTze8CCHPbZfYao8B2O/OVHSe+He1V5459joVkiCMEhyf N5M7UHGdk9dDOCorv9YFMTtwLXah/Ua/jclofKrw9PQ3wRkBqFB01d6aXO0ItkBQVygq xRtPxwquUSRlE7rPP6KzlQgBanC1OhihrtL+KucCKK8ukS+UjyOJOw0Re4+L2OleV7Tr pQGA== X-Gm-Message-State: AN3rC/6ludnY00xowXyooStqveAsjD4nf+/ZCbQ+u5j7TFBycaa8aas3 Cwn93ZcWkhqDvpo0 X-Received: by 10.28.54.205 with SMTP id y74mr6496903wmh.93.1492762310589; Fri, 21 Apr 2017 01:11:50 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z38sm10738781wrc.36.2017.04.21.01.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Apr 2017 01:11:49 -0700 (PDT) Date: Fri, 21 Apr 2017 10:11:43 +0200 From: Adrien Mazarguil To: John Daley Cc: john.mcnamara@intel.com, dev@dpdk.org Message-ID: <20170421081142.GY3790@6wind.com> References: <20170407002300.14433-1-johndale@cisco.com> <20170420184933.27450-1-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170420184933.27450-1-johndale@cisco.com> Subject: Re: [dpdk-dev] [PATCH v4] doc: fix flow validate comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 08:11:51 -0000 On Thu, Apr 20, 2017 at 11:49:33AM -0700, John Daley wrote: > Change comments for rte_flow_validate() function to indicate that flow > rule collision and resource validation is optional for PMDs and > therefore the return codes may have different meanings. > > Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API") > > Signed-off-by: John Daley One last nit below (not sure if you need to send a new version). In any case: Acked-by: Adrien Mazarguil [...] > @@ -1360,8 +1362,13 @@ Return values: > - ``-EINVAL``: unknown or invalid rule specification. > - ``-ENOTSUP``: valid but unsupported rule specification (e.g. partial > bit-masks are unsupported). > -- ``-EEXIST``: collision with an existing rule. > -- ``-ENOMEM``: not enough resources. > +- ``EEXIST``: collision with an existing rule. Only returned if device > + supports flow rule collision checking and there was a flow rule > + collision. Not receiving this return code is no guarantee that creating > + the rule will not fail due to a collision. > +- ``ENOMEM``: not enough memory to execute the function, or if the device > + supports resource validation, resource limitation on the device. > + This new empty line should be removed. > - ``-EBUSY``: action cannot be performed due to busy device resources, may > succeed if the affected queues or even the entire port are in a stopped > state (see ``rte_eth_dev_rx_queue_stop()`` and ``rte_eth_dev_stop()``). [...] Thanks. -- Adrien Mazarguil 6WIND