From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 541202B9B
 for <dev@dpdk.org>; Mon, 24 Apr 2017 04:04:42 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Apr 2017 19:04:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,242,1488873600"; d="scan'208";a="1160028293"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga002.fm.intel.com with ESMTP; 23 Apr 2017 19:04:39 -0700
Date: Mon, 24 Apr 2017 10:01:20 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>, dev@dpdk.org,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Liu, Yu Y" <yu.y.liu@intel.com>
Message-ID: <20170424020120.GC11512@yliu-dev.sh.intel.com>
References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com>
 <1581788.2CBIGuQB5e@xps>
 <A2573D2ACFCADC41BB3BE09C6DE313CA020803F0@PGSMSX103.gar.corp.intel.com>
 <7495505.68D2QY7hX0@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7495505.68D2QY7hX0@xps>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for
 port reset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 02:04:42 -0000

On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote:
> > Maybe I should add some words in doc\guides\nics\i40e.rst to Record which
> > configurations are  saved  and restored by the PMD driver in reset
> > function. Which not list in that are recognized as not saved  and restored 
> > by default. OTHER  NIC for this feature can add similar record in their
> > xxx.rst.
> 
> No, when defining a generic API in ethdev, we must define the same
> behaviour for every drivers.

Agreed. That was my point.

	--yliu

> Please check how to make the behaviour consistent and documented
> in ethdev. We may need to document your new function and start/stop also.