From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 91F252B9B; Mon, 24 Apr 2017 14:33:37 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id E28B524626; Mon, 24 Apr 2017 14:33:31 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org, jingjing.wu@intel.com Cc: bruce.richardson@intel.com, stable@dpdk.org Date: Mon, 24 Apr 2017 14:33:57 +0200 Message-Id: <20170424123358.5959-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 12:33:37 -0000 Since commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"), testpmd is started with numa enabled by default. This highlights a floating point exception when started with --total-num-mbufs without any port (division by 0). This bug was already triggered before this commit if the --no-numa option was given. This commit adds a check of the nb_ports value before doing the division. By looking at this code, it appears that the creation of the mbuf pool is not consistent for the number of mbufs depending on the configuration. This is fixed in the next commit. Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") CC: stable@dpdk.org Signed-off-by: Olivier Matz --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 3a573480d..f61f31344 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -597,7 +597,7 @@ init_config(void) uint8_t i; unsigned int nb_mbuf; - if (param_total_num_mbufs) + if (param_total_num_mbufs && nb_ports != 0) nb_mbuf_per_pool = nb_mbuf_per_pool/nb_ports; for (i = 0; i < max_socket; i++) { -- 2.11.0