From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id CAF152BF5 for ; Tue, 25 Apr 2017 14:50:07 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id w64so21875275wma.0 for ; Tue, 25 Apr 2017 05:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BAa/nVvNWmk1FD58mHXFWWhi0YR7URtwsUCjdNzlayU=; b=SXZW/oky2G9DNIFoS7suuat2A+bGx947tQ9OOybj07lsrPqKr6MFstzn8u4PyCNu62 LCE9adPKrTnTp96721aPZ8xG8lpk6gtxITO692u3iMBkFOVAXzWk1hV366mCXHNi199A 9N3UEO/mjHy1DrqfIyYZV77Q6J8dy7gjdf5JrYWwEgwlzH9yFCLc9Av2N2XQ6+W3kGgK IQGcCe2KahNZHXo4btWPc1bagAMxe3NemMeEGaDuLZjbwKEwj+ud/hkli8vk++YfVmY4 Ee81noABFs0AellZJJvwA6CHpfEmXGbUq55YpFfylhjCK+LtAMIAYLWrcpXfkf6synXq w3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BAa/nVvNWmk1FD58mHXFWWhi0YR7URtwsUCjdNzlayU=; b=mqQsGuAFXxtPG7imCE8uLpH1SqM0sIsbrE34zjaq/VSJVtrXRj2Oj4+zYMU8DZK2ip V1u+11Zwt9LCpxYbLsW/8/QLJvPvChgLqGb255kIfiEP3VdTQP3R2B6t+41jJVi14EcT g+oVecB72SE6mHI1e1j/YYBq3qW0HQhN4/A+zm/uL0IYkch+lBjCXaTnxnT82QLNQNoc Jp6DI2Q8qEAYGrhSM97jYHhbhmHxNpJmzCPXlZzG3lFfVrUyG/oToEfP8QPmfG5Z0wvP eN3wbl8qSOsDsQge3GJBu+bRxB1ZvetxerNhtV/nU4x+X02aCMUqfSqdNZWGJRoFQPan N3Fg== X-Gm-Message-State: AN3rC/6ZTn7vZQWSTXult59Sz4CLSOFRQCFeUcktxd5pxA65YGbr+/Ar p4IM5Dp3AMm/DI/9 X-Received: by 10.28.15.14 with SMTP id 14mr13254723wmp.106.1493124607467; Tue, 25 Apr 2017 05:50:07 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u145sm2081404wmu.1.2017.04.25.05.50.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2017 05:50:06 -0700 (PDT) Date: Tue, 25 Apr 2017 14:49:59 +0200 From: Adrien Mazarguil To: "Legacy, Allain" Cc: "dev@dpdk.org" , "Peters, Matt" Message-ID: <20170425124959.GJ3790@6wind.com> References: <046efd0fda00bfb5253586319fb9cfbf904a8f0a.1493108423.git.adrien.mazarguil@6wind.com> <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com> Subject: Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 12:50:08 -0000 On Tue, Apr 25, 2017 at 12:31:56PM +0000, Legacy, Allain wrote: > > -----Original Message----- > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > Sent: Tuesday, April 25, 2017 4:30 AM > <...> > > > > +#include > > #ifdef __KERNEL__ > > #include > > +#else > > +#include > > +#include > > +#include > > +#include > > +#endif > > I compiled this in our environment and found a couple of additional issues. I apologize... I should have done that on the first pass. It should actually look like this to handle both userspace and kernel compiles: > > #ifdef __KERNEL__ > #include > #define RTE_STD_C11 > #else > #include > #include > #include > #include > #include > #endif > > 1) stdint.h needs to be moved in to the #else, and OK, will update. > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. Missed that one, however I suggest either: #ifndef __KERNEL__ around RTE_STD_C11 or using __extension__ directly. Which do you prefer? By the way, is the kernel module that depends on rte_avp_common.h available somewhere to validate compilation against it? > <..> > > diff --git a/drivers/net/avp/rte_avp_fifo.h b/drivers/net/avp/rte_avp_fifo.h > > index 8262e4f..a0a37eb 100644 > > --- a/drivers/net/avp/rte_avp_fifo.h > > +++ b/drivers/net/avp/rte_avp_fifo.h > > @@ -57,6 +57,12 @@ > > #ifndef _RTE_AVP_FIFO_H_ > > #define _RTE_AVP_FIFO_H_ > > > > +#include > > Would you mind changing the brackets (<>) to quotes ("") since this is a local include file? > > #include "rte_avp_common.h" I will update it. -- Adrien Mazarguil 6WIND