From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 1267E2B9B for ; Tue, 25 Apr 2017 16:48:40 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id m123so98503054wma.0 for ; Tue, 25 Apr 2017 07:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pZ/zYKDvCFRMrmhLUrXuhKkCtOumG5ZDXDntIuPgeds=; b=wWqcRbQD8rdaIevChSzbrqyrMklTzPnEivUAE9mfqLimQ/N0NhGa/G0PnH+DA+5oxo vk0caa0kbxy2RwFiECg2CzquNrS9Sf2eNZ9Fr/J+YmrHUtpwMw2mheM/kXe5OXx69Clt 9/zLdE/2+mOuKufks1FIkBqqgbgVJ0i43zP6foE+JlG5cXRKHefqwt4DkaSJez7m+iMP ypSVFqsMT3wPUy8KvAf8YjVTD3IZGpTvjsIZxQXy4GpipzxylkaJ9Ry45Tc/lAU+uxyZ uLj8YXdsuEXQSZbrOA8RSKnxQRe5QN13RpaydqeYjIMhDUvtpKKVcrJTNPoXHeETBGM6 DkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pZ/zYKDvCFRMrmhLUrXuhKkCtOumG5ZDXDntIuPgeds=; b=PNZ5obmk60kCJE2ZnSDZ7mr1QYwLR8QYLhPcc5qkgL0uC/oHKBcd0IQKkXHM1dOP3n 7HHhJGi+ixduczmHKCLFsDys5Z4wd66qUm3TQxb+sxg2xhfCLu8p7K5DUptXdP/32fk8 /jOidkTqqWXpJuWapxiCAgctT6lqQOYBfT32dmLPMsWyQoUFkhQB/fdWITGpzSOT2WF8 051J/Z4CAqPlQOYCcUTjlyYEUVLZxI2+m90mtyyuJmqQn2Un6ue7q21gS8GJ+MKO8OQb SORVolerTvxkkuAzOBSyznh8TIFt8TEcatRRepgKRW8aMJy9n6Rf5fDizpMtezaM2z3V oBVg== X-Gm-Message-State: AN3rC/54p+DZxR2nUdizbmKforWpTTqha+RSBIFoxZXNNSB2c/T3woJq IpmOaGHEQhaAyXSA/Y0= X-Received: by 10.28.212.78 with SMTP id l75mr13674201wmg.47.1493131720665; Tue, 25 Apr 2017 07:48:40 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k4sm3643851wmf.12.2017.04.25.07.48.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2017 07:48:39 -0700 (PDT) Date: Tue, 25 Apr 2017 16:48:33 +0200 From: Adrien Mazarguil To: "Legacy, Allain" Cc: "dev@dpdk.org" , "Peters, Matt" Message-ID: <20170425144832.GO3790@6wind.com> References: <046efd0fda00bfb5253586319fb9cfbf904a8f0a.1493108423.git.adrien.mazarguil@6wind.com> <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com> <20170425124959.GJ3790@6wind.com> <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com> Subject: Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 14:48:41 -0000 On Tue, Apr 25, 2017 at 01:00:46PM +0000, Legacy, Allain wrote: > > -----Original Message----- > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > Sent: Tuesday, April 25, 2017 8:50 AM > <...> > > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. > > > > Missed that one, however I suggest either: > > > > #ifndef __KERNEL__ around RTE_STD_C11 > > > > or using __extension__ directly. Which do you prefer? > > I would prefer if it was done as it is done in rte_kni_common.h to provide consistency with other similar files. Like this: > > #ifdef __KERNEL__ > #include > #define RTE_STD_C11 > #else > #include > #endif > > ...but if you disagree then I prefer the #ifndef __KERNEL__ option. You're right in fact, I did not remember that was the method used for KNI. Let's keep your suggestion. > > > > By the way, is the kernel module that depends on rte_avp_common.h > > available somewhere to validate compilation against it? > > There is an older version of the module available on github, but it has not been updated since the AVP driver has been included in the DPDK. Since the AVP directory and files were significantly changed in order to meet the requirements of the DPDK it won't be much use to you. Until we can update it please make sure both Matt Peters and I are CC'd on the patch requests and we'll confirm compilation as quickly as possible. > > > > > Would you mind changing the brackets (<>) to quotes ("") since this is a > > local include file? > > > > > > #include "rte_avp_common.h" > > > > I will update it. > > > Thank you. Can I add your acked-by line directly assuming all the above is done as described? -- Adrien Mazarguil 6WIND