From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C9A0958EC for ; Wed, 26 Apr 2017 07:55:55 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2017 22:55:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,253,1488873600"; d="scan'208";a="1161053062" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2017 22:55:53 -0700 Date: Wed, 26 Apr 2017 13:52:26 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "thomas@monjalon.net" , "Michael S. Tsirkin" Message-ID: <20170426055226.GH11512@yliu-dev.sh.intel.com> References: <1493182371-34295-1-git-send-email-jianfeng.tan@intel.com> <1493182371-34295-3-git-send-email-jianfeng.tan@intel.com> <20170426053235.GF11512@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 05:55:56 -0000 On Wed, Apr 26, 2017 at 05:44:05AM +0000, Tan, Jianfeng wrote: > > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > Sent: Wednesday, April 26, 2017 1:33 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; thomas@monjalon.net > > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting > > > > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote: > > > Clean up LSC setting: > > > > Firstly, this patch does two things. There should be two patches. > > I just merged them into one to adapt to the name of "clean up" :-) I then could merge all bug fix patches into one and name it "fix buges"? No, please don't do that. It hurts review. > > > > > - LSC flag is set in several places, but only the last one takes > > > effect; so we just keep the last one. > > > - As we already change to use capability list to detect MSI-X, remove > > > the redundant MSI-X detection in legacy devices. > > > > However, there is no capability list for legacy device. > > When I try legacy device on QEMU (disable-modern=true), I did detect MSI-X capability. So does virtio spec mean legacy devices do not have vendor-specific capability list? Oh, right. I mixed that up. --yliu