From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 362DC695D for ; Wed, 26 Apr 2017 09:06:32 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id w50so96776391wrc.0 for ; Wed, 26 Apr 2017 00:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AA/EdXRNz/i/Uotj+SSnlNYO7th92mmSpQnatlgIoQ4=; b=ywldYae9ujPjuMKOuVvki02RNQ/VNEsgxA5SprL1zCDU9qxpwVRdZ7P3vSkM8uHv8+ 7+joKapNq1TgIMyV7aigCcxOKYy5K2Wtf41qeB9xlXetIHPaVWcCRLAZ6vtVExIiAVZK 04WeqwzvcWdbq7NjC/wUaguXPv4PXM2GRMuvFZ54wSoXupwYkoNdl6yL/HRxrj8zZAh6 wYsGFwHTYSnJN0//Z37Vq7X45oY76srLFWZVDv9AgfFpWGPZ0oBb0/kZjZfZk1zOpPoO VaVEwxq4+aX5gn2CABDTxWfT3W6Oj6UwNpB9oyM060afMBMlLUn4RF3bF8XwYA+iKpUW PGnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AA/EdXRNz/i/Uotj+SSnlNYO7th92mmSpQnatlgIoQ4=; b=cnehy14pFZlnbJk3FQwYTkEDEF1ggzDTZPSOZewaPWriOHtUiQZAHEbiEtjvypxGWR 28mJPyFiAkoIhFDGHFiQr6sB6g03Nhx5h56ALQS0OCc6+6yyvWObUuWd/bMlclRnb5Xi GFq3OdqmrUuelS4w/0oDcztDWb7ku9nUgMX+4FzMZ8QnN/Yx3OhG+1ayQhQgREzbPkiW sa8w63DZEL9GnUzhaSjpznneNpSDM5dELVftiq5avTt+x7vKzmIE7D5zkrTxkRjR4NM3 9QldyVZiAFiUuJ7aC/ZCL9yIufgrCLizl7Kyp7C3OhAC7ruNu1oDVLzxh1LZrMlOerjx uSSQ== X-Gm-Message-State: AN3rC/4gk1eXAW/lTuQ8q1ERPfD5PjyzKLk76yg5aMwv4faSqOVz8Rh+ XI/SgW3nTZo8CteZ X-Received: by 10.223.143.70 with SMTP id p64mr11527244wrb.120.1493190391910; Wed, 26 Apr 2017 00:06:31 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l27sm943958wrb.65.2017.04.26.00.06.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Apr 2017 00:06:31 -0700 (PDT) Date: Wed, 26 Apr 2017 09:06:24 +0200 From: Adrien Mazarguil To: "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , Jerin Jacob Message-ID: <20170426070624.GP3790@6wind.com> References: <743ea1c06b9307c8fc68a399244b8aeab606878e.1493108423.git.adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict compilation flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 07:06:32 -0000 On Tue, Apr 25, 2017 at 03:31:45PM +0000, De Lara Guarch, Pablo wrote: > Hi Adrien, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Tuesday, April 25, 2017 9:30 AM > > To: dev@dpdk.org > > Cc: Jerin Jacob > > Subject: [dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict > > compilation flags > > > > Exported headers must allow compilation with the strictest flags. This > > commit addresses the following errors: > > > > In file included from build/include/rte_eventdev_pmd.h:55:0, > > from /tmp/check-includes.sh.25816.c:1: > > build/include/rte_eventdev.h:908:8: error: struct has no named members > > [-Werror=pedantic] > > [...] > > In file included from /tmp/check-includes.sh.25816.c:1:0: > > build/include/rte_eventdev_pmd.h:65:35: error: ISO C does not permit > > named > > variadic macros [-Werror=variadic-macros] > > [...] > > > > Also enabling RTE_LIBRTE_EVENTDEV_DEBUG causes redefinitions: > > > > In file included from /tmp/check-includes.sh.18921.c:27:0: > > build/include/rte_eventdev_pmd.h:58:0: error: > > "RTE_PMD_DEBUG_TRACE" > > redefined [-Werror] > > [...] > > > > Rely on the rte_ethdev.h version instead. > > > > Fixes: 71f238432865 ("eventdev: introduce event driven programming > > model") > > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") > > > > Cc: Jerin Jacob > > Signed-off-by: Adrien Mazarguil > > I am seeing the following error due to this patch: > In file included from /root/tmp/dpdk-17.05-rc2/lib/librte_eventdev/rte_eventdev.c:62:0: > /root/tmp/dpdk-17.05-rc2/lib/librte_eventdev/rte_eventdev_pmd.h:54:24: fatal error: rte_ethdev.h: No such file or directory > #include > > It only happens when I compile with "-j", so it looks like dependencies have to be fixed? You're right, actually rte_eventdev_pmd.h is not even supposed to have a dependency on rte_ethdev.h. The problem comes from RTE_FUNC_PTR_OR_ERR_RET() defined in rte_dev.h, itself relying on the RTE_PMD_DEBUG_TRACE() macro without any kind of dependency. This makes no sense, RTE_PMD_DEBUG_TRACE() should be defined along with rte_pmd_debug_trace() in rte_dev.h. I'll move this fix to a separate commit to remove all duplicate definitions. -- Adrien Mazarguil 6WIND