* [dpdk-dev] Too much print of testpmd
@ 2017-04-26 5:10 Lu, Wenzhuo
2017-04-26 9:05 ` Gaëtan Rivet
0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2017-04-26 5:10 UTC (permalink / raw)
To: gaetan.rivet; +Cc: dev, Wu, Jingjing
Hi Gaetan,
When using DPDK PF + DPDK VF, there's too much print like,
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Port 0: VF Mbox event
Make it a little hard to type a CLI.
I think it's introduced by this commit,
commit 76ad4a2d82d4d72c3a7ed4675d77268b5fae3cc9
Author: Gaetan Rivet <gaetan.rivet@6wind.com>
Date: Tue Apr 18 14:17:40 2017 +0200
app/testpmd: add generic event handler
This is a rather simple handler that prints a message with the name of
the current event. It can be used to check PMD callback registration and
triggers.
Seems it's not good to print every event directly. If it's necessary, is it better to redirect the output to a log file?
Thanks.
Best regards
Wenzhuo Lu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Too much print of testpmd
2017-04-26 5:10 [dpdk-dev] Too much print of testpmd Lu, Wenzhuo
@ 2017-04-26 9:05 ` Gaëtan Rivet
2017-04-27 0:51 ` Lu, Wenzhuo
0 siblings, 1 reply; 3+ messages in thread
From: Gaëtan Rivet @ 2017-04-26 9:05 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev, Wu, Jingjing
Hi Wenzhuo,
On Wed, Apr 26, 2017 at 05:10:44AM +0000, Lu, Wenzhuo wrote:
> Hi Gaetan,
>
> When using DPDK PF + DPDK VF, there's too much print like,
>
> Port 0: VF Mbox event
>
>
>
> Seems it's not good to print every event directly. If it's necessary, is
> it better to redirect the output to a log file?
>
> Thanks.
>
I'm not convinced of the logfile solution. I'd like to keep it simple
and contained. Logfile means having to provide a name, or use a default
one with several drawbacks, and a pretty leaky design.
I will add a handle mask that will enable or disable this logging
feature. The default mask would then enable it for LSC and other such
sporadic events, while disabling it for the VF Mbox one. It will be able
to be fine-tuned and configured at runtime by a parameter and/or testpmd
command.
I'll propose it soon.
>
>
>
>
> Best regards
>
> Wenzhuo Lu
>
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Too much print of testpmd
2017-04-26 9:05 ` Gaëtan Rivet
@ 2017-04-27 0:51 ` Lu, Wenzhuo
0 siblings, 0 replies; 3+ messages in thread
From: Lu, Wenzhuo @ 2017-04-27 0:51 UTC (permalink / raw)
To: Gaëtan Rivet; +Cc: dev, Wu, Jingjing
Hi Gaëtan,
> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, April 26, 2017 5:05 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Wu, Jingjing
> Subject: Re: Too much print of testpmd
>
> Hi Wenzhuo,
>
> On Wed, Apr 26, 2017 at 05:10:44AM +0000, Lu, Wenzhuo wrote:
> > Hi Gaetan,
> >
> > When using DPDK PF + DPDK VF, there's too much print like,
> >
> > Port 0: VF Mbox event
> >
> >
> >
> > Seems it's not good to print every event directly. If it's necessary, is
> > it better to redirect the output to a log file?
> >
> > Thanks.
> >
>
> I'm not convinced of the logfile solution. I'd like to keep it simple and
> contained. Logfile means having to provide a name, or use a default one
> with several drawbacks, and a pretty leaky design.
>
> I will add a handle mask that will enable or disable this logging feature. The
> default mask would then enable it for LSC and other such sporadic events,
> while disabling it for the VF Mbox one. It will be able to be fine-tuned and
> configured at runtime by a parameter and/or testpmd command.
>
> I'll propose it soon.
Agree. Log file may be too heavy. The switches for the print is good enough.
>
> >
> >
> >
> >
> > Best regards
> >
> > Wenzhuo Lu
> >
> >
>
> --
> Gaëtan Rivet
> 6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-27 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-26 5:10 [dpdk-dev] Too much print of testpmd Lu, Wenzhuo
2017-04-26 9:05 ` Gaëtan Rivet
2017-04-27 0:51 ` Lu, Wenzhuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).