From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0050.outbound.protection.outlook.com [104.47.33.50]) by dpdk.org (Postfix) with ESMTP id 1EFF81077 for ; Thu, 27 Apr 2017 13:01:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hkO9jYknFZj81hYELEbHN243EumtJB66/ZXImBEL1ys=; b=o6QdhPOXOFzebUcMd+yCOWIudELl0OUJrOLRIF/03FzJn+n4iUlR47jcXr3JyZKFCn2jYWjfg9jonfK/eB2iC/YJaPh/ajQ6MZ7JqXnLvYz5NYgJkJ2jTymM6lfTzOK2O8J2EcCROD0vHhUTjZv2n8Oqlfe6bK8KHOAy3Aw8q5Y= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (111.93.218.67) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Thu, 27 Apr 2017 11:01:28 +0000 Date: Thu, 27 Apr 2017 16:30:29 +0530 From: Jerin Jacob To: Thomas Monjalon Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com, santosh.shukla@caviumnetworks.com Message-ID: <20170427105934.GA4375@jerin> References: <20170421122223.24194-1-jerin.jacob@caviumnetworks.com> <1937111.PEUejtoCqE@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1937111.PEUejtoCqE@xps> User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0066.INDPRD01.PROD.OUTLOOK.COM (10.164.136.166) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6c631ec-c7e1-4506-c503-08d48d5cc263 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 3:09jF2gS2xDOR1nS4gbXL1yQmcTDQ6xhBoUnf57zS1Qk9ZfjuiV5dgWQ9rSHRviFXPAvMjitF5BCz7ccgPPy+gBltOJWbhkJNJNZnk5u1/3+EWpamC5bgYna8ZnyRqwd9uFVyE9JJlD+Gmx4Wt/kT77Aq21ctKfH9IPcyshDgCW+jkxQhf9G9wi0SIgy7Lq6eeeryAsJoBoNCgTwiN7VLblRuE1STdyDoOSEZZ9z1UrVFiZzvv0JDFssaJd1+yRMAnowmG1f8bfr1qkT/lSUaatm/ZMm0IgKHQF+YDtxt6lTWotM1sowKBq9M/4tpV2zVYUmJTsovlrvPxF/+zfqsaw==; 25:j02dakI5zWJhYCjEZWwgb/KhBu/zmwQVMbAWZLR/mAKBIlTc/tgQZhjo4HGHG2uHvkNxAhweawa1i4QhU/ZwfMBchToegFqUV59ownWE5VnpJ7ktpNma39z4pISGD0Q74yiEMtZC2tZndAaPHR22EOTcQZb9q+d1CHnYDgBSNovro/5nHzZ6MFIXFmdqjDpKL2bPHEDw5iNx/eIJYihvCvNGBJxw8x8FJfyOCtA0pKzb4qVkrQOWz9IbBXk8IrTChZ1R6qd19bIUPzRkUpuuBu/cLtiEfZSetnaTVUxeYOTMtDj2wsHD+Mq6wDbseeTKtDwkII1rlE4x7Ieg6sKWerQrP+Nr/nXOkj9M6BGN1btYN4hTudlBs8erXHTzkT6lbjoJuyz3uvZagBcZl80UX+boEZerenAv9lKiN4qTe0KDtyxVrtnI+mAWeZqNyyEaxSfTHywEAOIlcxidvehRlQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:jxhmAkoG8VMTouGIUAuTB65RbfrkumvLXKMiY8T02kNcI12VGxiuSH8jrc7EAaAV3gFzcFoWStDB63kGm2iS+j3Zvb/ayAMxFL2m2LfvbJPkAqRlJwR9+Tjx64IBYqLWwhwgpJtAYI21nlwe8p47qhWnXcpPqekCQILzfJuaCIlGpo6HPSrCw9kS2WHQUEeukygSh6BQu5ltjReuVVczk/nvoDXzAdMeMDa0+n2lZb8=; 20:dnVBp4CyoynWJO2ofnzZeVSZT8rV47c2Zp/3Amr/Y1Jswd56vf7v8n0pEVnC9kSLGWiFgQ0wD20UGjSgz1fnFAFGtZhYmCrkFypbKLIRM8qXMlpdUOn0iYsnyF31mQ8dHifVfhmlMZ0QDIsPp0cmcmo/ZIy9XhOPUXRrN95PXytu5h5YBF3vWI27hkuX6jqlc4elelny23cOYD7GH+Z/iQPNMWBKegwvsN4ySd6XZUpnyvDvg/2hbHQzQvoH1msxfolPDGYzUC54IxJb43Un1GFgweqhpd8HZzEUwL0838Q7y7ASVAvuKKe21+bi6DHfBsjYoCdMn9w3YA7grKUk7oZs26qELtf8xkGMfBJPGTgceH2HKxKSRxG3wOqvW/DXawGRSCy+MT+OwERkLVRilqJPHKj9L6T6+sXE63P8lx+1hxDplBMz5+5uetKAbi35O3WmhGQ9VpT/WuvfAi7zqFDWMbu1eO8iOsnAn+V1NVBS2rNlLQgWS+8xtcwyb57HQBI13dJIDQ/HnXaRnopdYtfNppqgjFO8sv3mf1RhlQHzzocuvcwGG2SdHX5toaTEeerHXCC/0UbNHaE0zJcXdmJyZzyAdsApmO/nW7gW630= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:r/kqixKr/pMi3ctj10drnls/YQAfpaOMcL+YkZ4JHHK2mz+Z/UakgjnHAhHFgCc9QXQvtLMM88XRA9e74oylthQ5LjWdFZuPGb/W1BN66CPG2rvFXjQ8ysGLwOi6+iycxegwhtifbrs9XWmK/7yVrt20oDyb22WJmaxv5h/RgTPNaDfDk0E9LmN4dtiyeyHeJ34Ovy+8tnV/+BifdRP0Poog6iYXPP/jK+aARf7JDF8kOA/gBVKuZkmQj2Abe8zJclKVyA3La5Xr88ikFLatViQVwVui0j8w/EFuntFz9eGnIF2s+WIAKu8oCoYeFLjBJvBDwPFSeblhSW2JHD6bgrZ+AY8B4hsdDz1K3DyFbApI9ILd33PMKjvqFXBPNo8WhvxZ+yWtlBoLJFUTDhB8fBNJVyY2I2Fc/KCZAxLWBefzQiANxF9LTL5jdtU7KoY8RvP8Ff/9Zaokx+D8H7tzXxvLZYmFOrX9Jgr/v9uG/RENvGlYDSNslElpYoDBu/rlKRAWFpcHIb9DhVzVZRtPpWNI8BMNpqr/OJZrOiPQERb0D85fhHhaeFxWU0kFYNs88xMK6ZZghOVrVCN5hp4PttXQhnkxjMqZBoJbNQMACAFIuIKji1wPCwCyXrLX0GPWA+Er371d1kRyoWttCqMp0AJGPWpP/JBrn9QJ/BhWPtICkaBe7n8nIt++7eiA3J6IcnZJuIkjqUGZzKNrzu2iCeQyDl+f7/sK+wGLjjwsiTF1DVVXTxXfpdvI59Shi+gySpEKSvBNav0NF8N0ZEgrGInNft9UyMcxNVxtmYvQKpfdk5R+PJkheN8qj1b/aV1S X-Forefront-PRVS: 029097202E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39400400002)(39410400002)(39850400002)(39450400003)(13464003)(33716001)(6246003)(305945005)(6916009)(42882006)(2950100002)(55016002)(5660300001)(107886003)(38730400002)(110136004)(1076002)(189998001)(6116002)(106356001)(6496005)(3846002)(5009440100003)(50466002)(7736002)(23726003)(53936002)(42186005)(9686003)(2906002)(83506001)(33656002)(66066001)(25786009)(76176999)(54356999)(50986999)(4326008)(4001350100001)(8676002)(47776003)(81166006)(8656002)(229853002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:jerin; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:s1I7qQYB0Xx/3vzayW86VorezERFU8/2hzvN/wa?= =?us-ascii?Q?mOrLSMdIkOSRYDWIUnfZd37hY8Gd/dphVFCUWWD0jNUKlXR6luuR/BYc93oT?= =?us-ascii?Q?s0p3W3AeIUrwsrK88/nn02dmk/XPUgcwfJfLQYDE9Mu0egd4aElVEt1/OwMm?= =?us-ascii?Q?KxNaNUiPu2yautVVIj7rXV63ah1oOP+e55I9oYwAIfUomNPOZS5ks30lCYRE?= =?us-ascii?Q?Zjz+TJfobn8jq0pIFXVGJlSucpIqM4hceLRlS59M00yz72XY8VSbGQVHwQdy?= =?us-ascii?Q?NQ8eBqbDqj2bVOA1UB3kFWTlq/cuIWNE5S0VCH58Usx73khYVWT205bZlOOv?= =?us-ascii?Q?udiGtHp+yWyOZP06wb5pVkhSV3VTiFppJYFy47O0lG+/ikPP/Gziggwi6QHh?= =?us-ascii?Q?tmI1wBz7SIJ36BhcMR+ORDVWNNrhGXqHNIPPBy5ZNoiTcIlwqzw/etH91RLD?= =?us-ascii?Q?VbbpUtLN4tPlYC3gmDj6urLTVgPV90ilzg1QPiaKHq3CklDSVT8vkko5xvrF?= =?us-ascii?Q?4/dA8S8DkI3Da/r5oZ5xHgk0ADstmSYT+hNX5tuXrlDM+LMKKPrszu7cyMii?= =?us-ascii?Q?QmZ31sU4z8tD8DwIC4Jen8B/Hoq4zihrfpMrN2jpp7l1OftKPqSTGnAZRrf8?= =?us-ascii?Q?u83Ai3f/pgVp4iK4VBC3dQauhtyvJ+gGjhHMOMP/Sv3q6IGM6Xzbd8cfUNA7?= =?us-ascii?Q?MHhICKxGnfwjvuokl1RkphUD2jjSBojrwrFK+ouHhAPN1KENAGI7Y3Vgtzyg?= =?us-ascii?Q?FOm7jdfiTWbzouhQ33WkKBvQaAYIKA0W+fvx9fqz0vwZjb2AsYKmG3VLr9+g?= =?us-ascii?Q?BDRoRHAUWiGjm6PHqe4mMh6TsF6nwyoopE8grBYKS0vVVlC7fnXuYh2+nXmn?= =?us-ascii?Q?VBMU9IYAxSLqfEgc6P7CntH14nxD3VZqBEEyvpdlSFOZakE1907E+ZoPsvtE?= =?us-ascii?Q?UxXkVQyIX+m/0n98hcl59BCABmJA+l8TNjS8R2yuG15dy+OhRT+3nGqrAf0z?= =?us-ascii?Q?rThsXsBVIgViqRwyiaTSKBbqN9EPvS3LrlQObD/HZziOePKv5PpQbj46B+XQ?= =?us-ascii?Q?C0HxIPElc3maBwlKm7SmgBM0HsyDmusBSS8spYgjW+2iFUb09i7NzIgRHjUl?= =?us-ascii?Q?9BOkLykytskUzgPtWG/czNfxFMslPPyoBmqFa18ZOpVsmfEuYmRdEg7BjcC1?= =?us-ascii?Q?dSLimhXDTe+irFCC3LBxF0mvjvRvttizMysdf?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:zuhwCmjH13+vDVQLqdlBxxw3QQRod2aDwls3nvPvPZscIlQdB2VbSFUq8m8X6RR53ASay/q6g8wEY/GHSbZ9lzo9p3Y/Uf6krDTPdS/t9UKw1mbSED/7RskCCUIRVxLeksfomMYGpuiyZP5MqSPeR5eBCAzNxcK2A6rGGOEC9Lx8TAfSmYGJJly96h7gBgJFXRuTPwaJWx/EUFXjn4/5uLGB69wC7FmcQ+3Ybwn84/ojauoMFExkTIb0KhmG+PmC2HAiDXYjj2PUK3vP2LPnhEGSdw3Aw4UkUvxtYeky04YYPLYtSvV7R40U+xAbDJ7PUDRSmIDSDaEBHiEzYogTh5zGOuC3avST7++Rt75wYTF3Q0RqE/4f6qrOilDgirTzAEbfutKMQiGS11Tgm1ga+itUCHXSIORIncbVSQyWJ4Llq6PVFL+B7l/LAF/tZM55etIjwroPq7YxFgHxQy6gCHWoxaz14DZX+eRFzUMH4cPKwl+3L89lIZu8BJZ8kxtwc9TlN9HiqoqGu0kOCAdb4g==; 5:2v851HLKZ0c1XK0iSVr5tXpYyoP23dKEtniP3/YBUPTip64+Q5I57jaMSSWNd5d1WzGchPz3+/Y6l1dh+UXmboWQ/Ms9NRx0hQdU2odumQs+a9PI7vrBoI3tGEnRtXtnp60ABGifHErL2LKKUwC5NQ==; 24:hjJSq5oLn1xVfvC09po3fSjiUhVziQvJ2WaPZqDxHMaiDLfQomrz2M7qycTIIGd480XAPHziBd6Pl11C5E0GRDJU8d7qWIqxWDsnm+wv1YQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:VBWqeTxpGDAHEUGpoafkGrqBH+GrqJE1XCTsMKdjuzzfCarZYZ0533rHHAU4+ojH5xlAjeUv9PQKM2kVrzn431nNbQQBkqPlZPGFw6c5rZYb64o7hzmM49OfBbyjH//b5/LBCxD4L+PpFYhWEgOw4VA/h8cihJu12rCMgFv2wNdju/7nfhHqOLYkxCEs2Aes+x1jrGEMFfh8AL9frjsH9cljBZXFnrWOgougzCwx8yRPFDF+HOFveT+3StvgHNtFehfTrIt2T+ZVJROeMyG/nuTyHQTVTsKAfkbgFli12Lt8vSCWxraO7w5NpKKi8WBR0l//uM1bFVuifwbdRs5HAg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2017 11:01:28.0797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH] ethdev: add lock-less txq capability flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 11:01:32 -0000 -----Original Message----- > Date: Mon, 24 Apr 2017 14:34:59 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, > hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com, > santosh.shukla@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: add lock-less txq capability flag > > 21/04/2017 14:22, Jerin Jacob: > > if this flag is advertised by a PMD, Multiple threads can > > invoke rte_eth_tx_burst() concurrently on the same tx queue > > without SW lock. This is an HW feature found in some NICs > > and useful in the following use cases if HW supports it. > > Which hardware supports it? Cavium OCTEONTX Packet transmission HW block(PKO). > > [...] > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > +#define DEV_TX_OFFLOAD_TXQ_MT_LOCKFREE 0x00004000 > > +/**< Multiple threads can invoke rte_eth_tx_burst() concurrently on the > > same + * tx queue without SW lock. > > + */ > > Why TXQ in the name? DEV_TX_OFFLOAD_MT_LOCKFREE would be enough. OK > I wonder whether "lock free" wording is confusing because > the locks are probably handled in HW. Yes. Another reason why it possible because HW is not using ring like scheme(head and tail pointers) for Tx. "lock free" wording is more from software perspective. > I think the good wording is "offloaded multi-thread capability", > maybe with a naming like DEV_TX_OFFLOAD_MT. I think SW lock free is the capability here.IMO, it better to reflect the capability in the name(DEV_TX_OFFLOAD_MT_LOCKFREE). > > Anyway we should reference this flag in rte_eth_tx_burst() > and give more details in doc/guides/prog_guide/poll_mode_drv.rst. OK. Will address in v2. > > Should we wait a first hardware PoC to add this flag? If we are in agreement for method expose this feature through capability flag then should we really need to wait for driver implementation to accept the patch? Thoughts ? This flag has impact on how we handle the even dev applications if HW support available. We are in the process of up-streaming OCTEONTX ethdev driver, but there are few thing like with external pool manager and eventdev integration needs to be sorted out cleanly before that. > Candidate for 17.08?