From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
[209.85.128.175]) by dpdk.org (Postfix) with ESMTP id AEE609E3
for <dev@dpdk.org>; Fri, 28 Apr 2017 11:13:28 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id l50so30121221wrc.3
for <dev@dpdk.org>; Fri, 28 Apr 2017 02:13:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=tVW9FLDITwdpsrnAl97ijbYw3Xp7IRpst7hVGdW6n4A=;
b=LwdcwwPYl1doWRYquRrGx/1c+0lX7CDPYIjmiveS9l0FoDCJMKkteNWDVip0qpjaYA
qeAo2jgNd+oJcFD0IdTGDY53y5ZSuIL/iIvCEChRwn0TvONUVvd6onbiJnmwi9jkjEW0
95/BhKL7FtrG9d6AWDvipLPd4QZHixDzp5wDO6eyeaDmTKayoc5LGSPbHRtsgexP67fN
PKc6Dk0pg3p0cHO6D50dvCaMNDKmrUGeV1qIP1Lpe0zwSRiqmgSQGgWe30aM7Q3oXd9+
yHOWZZud5+Up/kv3xWCZg304rodI45+9jOKRShzvBHTg7IzW2SMIqwikc7lyOeJV8QiV
+OTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=tVW9FLDITwdpsrnAl97ijbYw3Xp7IRpst7hVGdW6n4A=;
b=p8ZnCWvUm1nbfJuET3iemDoVfkKGYKRGG9DY31gMP509DqPUx0WZoqXmDqnDkskqdJ
q+ZpdPHfo9i+ddGz2OWbBReNy/QvS4G1lth/ngKA/1YFPLPet1XZwu639WFb3e/6Irm9
EpGOfKtY4WP+qlfE2ywJAECltf3kLgiwlvCq4j16y5ouyrDZaQ8rcNNYqWbRmTDMRsET
0sOAgtCA9K60iQaqxDzb+wcLC9/VJ7S60xr2L0WGVzEp6kidXzEqPmgeliZlM5G83cOz
T1mtxn2C7YB7pfU05pnRw4BoSFxyDGjCEW4dq0UAkZX34fKHTnjbOEp2i5uqT9YQWTso
WoFQ==
X-Gm-Message-State: AN3rC/7uwX5A86AUczTQIc38lnWdpuG430Koe08UtvslEuaybsmpeZPQ
WkD7F1EL9sqIANMJ
X-Received: by 10.223.135.102 with SMTP id 35mr7420009wrz.141.1493370808214;
Fri, 28 Apr 2017 02:13:28 -0700 (PDT)
Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr.
[2a01:cb0c:3c6:5100:226:b0ff:feed:2fc])
by smtp.gmail.com with ESMTPSA id w10sm1993470wmw.14.2017.04.28.02.13.27
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Fri, 28 Apr 2017 02:13:27 -0700 (PDT)
Date: Fri, 28 Apr 2017 11:13:25 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "Glynn, Michael J"
<michael.j.glynn@intel.com>, "Liu, Yu Y" <yu.y.liu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20170428111325.7f0d2ab2@platinum>
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com>
References: <1493089885-94889-1-git-send-email-wenzhuo.lu@intel.com>
<6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] lib/librte_cmdline: fix CLI parsing issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Apr 2017 09:13:28 -0000
Hi Wenzhuo,
On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> Hi Oilvier,
> As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks.
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Tuesday, April 25, 2017 11:11 AM
> > To: dev@dpdk.org
> > Cc: olivier.matz@6wind.com; Lu, Wenzhuo; stable@dpdk.org
> > Subject: [PATCH] lib/librte_cmdline: fix CLI parsing issue
> >
> > When parsing a CLI, all the CLI instances are checked one by one. Even if an
> > instance already matches the CLI, the parsing will not stop for ambiguous
> > check.
> > The problem is that the following check may change the parsing result of the
> > previous one even if the following instance doesn't match.
> >
> > Use a temporary validate for the parsing result when trying to match an
> > instance and only store the result when it matches, so the previous result
> > has no chance to be changed.
> >
> > Fixes: af75078fece3 ("first public release")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Sorry for the delay,
Acked-by: Olivier Matz <olivier.matz@6wind.com>