From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id EE5391E34 for ; Fri, 28 Apr 2017 12:04:56 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id m123so41984413wma.0 for ; Fri, 28 Apr 2017 03:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7H6UObJws81DYIs6XQtE+dpP3Z3rvL2ui8CFjhV6FMY=; b=bF0NV1UJrGoEZNpLwVW0qvHZQNd8UTuy723OrqL5kMcGAgbbjjU4+MPcx7yLtAe4Oy 7V1PJge88ZGT9AXpn2cN39/uwQ6Ag0z9pTLuD5DeTWJuoxdds1esgwdhJ/BrGLlAm6Pt Tm5K01QeunTlEgiSsDhjax9VQwIlk8eRQ83ult51OYs9+Sdue0h2WNbOD94W6N2WsIMK uufFr+B/u27+xGDbT5GMDtKA++xYSOQlYbz7eK+4+tReMDj/JSYTGN2NAk6gU206tBv0 eSEMrVwGavB2aOi0yACL2o6b6T+kTbNt30KH+K/KbrB6sJRhmAoYuC8PDwUkPlg9mMwU FjYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7H6UObJws81DYIs6XQtE+dpP3Z3rvL2ui8CFjhV6FMY=; b=IDjnHcocoJOW0CrZwszZDgCBNca/yrKY3oq5D9EuMxiQh5SZclFmMi3VS76AjXB1PW AoWkye5RP5PwbzwH8ER5RKvBzTL461dFS95Xy6SI3m/8V2DVpqUtosYMuCy5RP1AR2Cd /Ghnzgj/A6DdioQIdB1XtsPu6Rrn1NDxD2UviGTVz02Vk6Y0G7BuxUOiihO6QX8c1yOU Kl7YEwTVzeDp6JGDkrpPKCuf6L9jWDr6cvCno+4MkehAlah0pPcCwJUIOP6mHLQel8hm 4705mgl3sut7PPsuIRVAddNIxRm+ZjhwNHWndO7YUEyrHKyLfyk7sSHrbLyeUKN0lBFK e6Yg== X-Gm-Message-State: AN3rC/40SoOETNNcWMyS2KLpjIthlZfICRoecODHu3bLiuxyGMvVji3r X9Hb02+lUjxihzdFLuc= X-Received: by 10.28.30.23 with SMTP id e23mr5271795wme.94.1493373896546; Fri, 28 Apr 2017 03:04:56 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id o18sm7381296wrb.47.2017.04.28.03.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Apr 2017 03:04:56 -0700 (PDT) Date: Fri, 28 Apr 2017 12:04:54 +0200 From: Olivier Matz To: Thomas Monjalon Cc: "Wu, Jingjing" , Daniel Mrzyglod , Pablo de Lara , dev@dpdk.org, Oleg Kuporosov Message-ID: <20170428120454.1e9f0b0b@platinum> In-Reply-To: <7967304.9Aej4IakVR@xps> References: <1476369308-17021-1-git-send-email-olegk@mellanox.com> <5493210.cW0TSkhqM8@xps> <9BB6961774997848B5B42BEC655768F810D59753@SHSMSX103.ccr.corp.intel.com> <7967304.9Aej4IakVR@xps> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 10:04:57 -0000 Hi, On Fri, 28 Apr 2017 11:12:29 +0200, Thomas Monjalon wrote: > 28/04/2017 02:19, Wu, Jingjing: > > > 25/04/2017 16:02, Wu, Jingjing: > > > > From: Oleg Kuporosov > > > > > Implemented two methods of control > > > > > > > > > > - by --enable-timestamps CL testpmd application we can enable > > > timestamping > > > > > for all ports; > > > > > - in interactive mode port config timestamps on|off is able to > > > > > configure timestamping per specific port. > > > > > > > > > > The control doesn't interact with IEEE1588 PTP implementation there > > > > > as it is under macro compilation but can be extended in the future. > > > > > > > > > > This feature is required for debugging/testing purposes for real > > > > > time HW packet timestamping. > > > > > > > > We have ieee1588fwd.c to demo the timesync enable/disable, can we > > > > reuse The fwd engine instead of defining new commands? > > > > > > Yes for IEEE1588 feature, we should use app/test-pmd/ieee1588fwd.c. > > > > > > There is more to say about this feature. > > > > > > The main goal of this patchset was to add a timestamp in the mbuf. > > > It has been done by another patchset in 17.05. > > > > OK. But it is not clear now what is the timestamp for, right? > > Olivier can comment on the Rx timestamp (PKT_RX_TIMESTAMP). The timestamp can be added in a mbuf by a PMD or by software. The unit and time reference (the 0) is not normalized: they can be different between 2 PMDs but must be the same for one PMD on the same port. As of now, this field could be used by an application to know when a packet was effectively received by the hardware. The use case could be high frequency trading for instance. The PMD can provide an API to convert timestamp value into another unit. Possible evolutions are: - a library to normalize and compare timestamps from different sources - implementations in more PMDs > > Please Jingjing (or Pablo or Daniel), > could you explain the relation with PKT_TX_IEEE1588_TMST? > > > > Do we know how to test this timestamp in testpmd? > > > > Mbuf dump can show this value. The problem is if we can use the > > rte_eth_timesync_enable/disable to indicate the timestamp > > is in mbuf or not. > > Please could you describe the problem? > > > > About IEEE1588 feature, why is there a config option? > > > CONFIG_RTE_LIBRTE_IEEE1588 > > > A feature should never be disabled at compile time. > > > There is also a runtime enablement with rte_eth_timesync_enable(). > > > > > > I think we need some discussions here. > > > > Yes, I agree. > > What is your opinion? > What prevents from removing CONFIG_RTE_LIBRTE_IEEE1588? >