From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0057.outbound.protection.outlook.com [104.47.41.57]) by dpdk.org (Postfix) with ESMTP id 722CF377E for ; Tue, 2 May 2017 08:41:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qUGgK6Dn9CJOCUCSgAvVooHa3vy4d7dO+y+fsWepjLc=; b=OHQHSOmrfG+9jNBBthNszRwY6sTlstMrqdSjSJ4OIaH2oYEbzR2jD5j/O6iQ2mEiKufkvZOLFEVaomP3pje3yPO0dXI8O/C5oJVEyKU41oE7XOPdXSuhRR7DnEktlZFjSu7HEkh1BnbXIdiQxwJiKIoCoG8eC5LYP9FknqZIOF0= Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (106.201.122.214) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 2 May 2017 06:41:18 +0000 Date: Tue, 2 May 2017 12:11:00 +0530 From: Jerin Jacob To: Ashwin Sekhar T K Cc: byron.marohn@intel.com, pablo.de.lara.guarch@intel.com, jianbo.liu@linaro.org, dev@dpdk.org Message-ID: <20170502064059.GA28685@jerin> References: <20170427114249.31863-1-ashwin.sekhar@caviumnetworks.com> <20170502055953.29222-1-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170502055953.29222-1-ashwin.sekhar@caviumnetworks.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Originating-IP: [106.201.122.214] X-ClientProxiedBy: BMXPR01CA0032.INDPRD01.PROD.OUTLOOK.COM (10.174.214.18) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 450a690b-7d16-4fb2-0547-08d491263e0f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 3:fCQC16tUsFknrKOYdzSSo+JwoA1Y61Kxf0+p3uLRgcXk0TgvO7VG03T1cSEXNIPcjh0QeT2fNTQTusxI5LNosjnUdFoKJOBHhdL0ciaQd+plsRdjgUXAu9GP/2kgp8t2GbqXv7zWtiK9MO8X94k63Mr0xZ2JK06Xh/j79g0jdHfh5I5cs24Je//6bhSCWEeI4gGjSkZciIcd6JkqKNxLv/VBlwg7akYrlH05BxcY0e1e8WGGA0Q4QMksEE+lMNWNSbiK23AYuZvHW/1/7ltzaQhLia+mJ3rOdpL4WV367QNgDG5EtWJQSW6GGDKaKLwkLIRaAs/3mdbOokm3iagQpg==; 25:04fBX0Lt9I7aoiDh6YfxHE5aERZPr1a/8yuFyhRB5la3xtHPO04FxsPHpCEkhDjUJRf4ejRlAoduM4LhBwxGMR1DKGI8XEJZ4SJer2PdhfcFQ01A5DmIumPG9+grtlfalUZcp1Qc3BiubZuIp7uIE+AOqpfhKRmkkWypeQGxUJroEB3+6bmumKvMi7Fqyn+qXjmjhKByIN/8eIYbE3pNxjTIMPyV6v8RJQiRrDg+GfyQJLtFeTk6sY3UJ8AP2wc9a6mfWVmP5JpK8CqVxvEElxKUePiOZC271pMKHuYfU4pfCSPMcqCj8Lrw30hbD2rsAJCxVQkN4o5KHJ9hNRLI4BR1MZphgkZncvggR/o8f8P2VvK7gKYTKm/eyUjsgYv8+cvpSkEAE1VxzuwL7Xhz/ua9dAQcKqsSam6tOxLoaknTCoRskJymTSW7zcdIk+VMhVGyaAHVUdWCUvF97jfMgQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:F7eqiiatpc00Pk6pCgg3DhIr37cIg5mowuhptAOE5FC+0GUaRv7ImoF+VEb6BY9ityniiSuK1m+k21XG+HHA2dpxT6RuCp03+pfdvpfB8HnF6z2I/mJm6V30na8k5yrwwUKNwxAcOMoxAxJV7ok0BvQMjU6/JlB95CTmfVnqi3cFHPcvnJ7pZubI/EmyFxVjIi7t8rt+zsBPXhPp5fsXJxMt4KU0gyDP1T0qZGvrh1pGBnbHTb9OxByZfVaMtG/P; 20:L9l1YAlJnP6xy8STVUri3hJT0TVJ4sH3E+XEdSqtPkWJJXZE50ayXTm+C2LPAOI5CLgQdmLETTj6LUynYelHHfGz7VJmUvQFaAJsu3KaHyjIMEmIkIHL47FP4WYm1TVzMQPy4eEz0Sj+GfYnzhfd7A67mBvsUV5nNV1VR2famQXkQJnH2dQpRw0sVAw8UHMHctP8FXIBHzRY65NyuR0ahuTbKUGmIpfp/A1epdIAHr/NUUVds5rAOyMCQXscYcF4HLGimHx0fZxJMqmW7PDQH3su9oI/9wOKoRGRhIQa4fGXvI0N9kAWwLBY+dNhSxWBLVG6H2OV6zLwBxglCQ+4Ubdf7OJv9EvB85j+QJ9wUx+swDbD/E99DSxZseHlBacqi5J0ObP/z+9h8ZQ++d3OtF+0kQG6jcEM2he7KYbmahlUS3dnuThcB56MPpBOs4kXXKZErw8aSKYB1ueJCbCLp1UYFxApunblCOE1tQwbNA0bydHwcM2B6GPcoP3IDOIDYnQknwluja+nQdN+Edo1ug2pI/IqTPhv9M5OahYVilDdCTwptkZfc2Wgy72DZuA+dLK6Aoy9LdcvgbMS1SkQZlG0YoVwUv+a2i2BJgzrNIQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:gOhBYOjOcDCnqkTq+Ujr9+2BbkZHD2VbAQLIGeb1z3G3/tfHlyAd82LKuNuPiamOuAqfxaj0ET9DXYNSLNUYYJ9CN8Aqs/6h1bPAOTgI2M7+2GynnAWfrcnXEE0+Cqc6IXqNTzBSJnzjU+Z5LlPLhaMkY/iRjGLbtFHkFRxkWOVUmsfhke7tOwsBsIgTaQuOH7GP/6Tkl+kvDqlWgdvpiZUdJ1WFCCf6cjp4w+RrZcVyzhQtjb8N4JfKGve43f8EVGRtIbLbZ20SI5dlWpRmKSNf9ThimHB1L4MRnUgnvT+2EwKgLLskdkcI76+5IydrzM3EdDJ2VwRA654ZZb1UDp9EfIlcNiElKTadc9t2nL7BS4L+HR2QaSJYBeaCKlpJfn6g6KtM/hrctcoS2+ZhuQD6eP1KGTUhWV0Py126vtsq8o6PRQPJ6Ou/SjWoKNucQ+vhq3i6mXshjzxizJWDk7Ct6Z56p9w+c0xrvDb+VH6jD93Rr+JnrXyXA8Fk0xdZnrUM6aF1uBSTqDScxlassmBKcUvP6iUuEcF6t4LDTufnako/A+grusaWnStp8p8genHTBNEBt+ZhH32uZlMrEFLzbO0ECXxQTrU/orZw6gr/OFhcHFd+28sFKc4yku7gQX7qUUqMiINWQd+7HCfx31vjUc18F+8H4wXNoTH2x0Oxg/UCwtXvLQT+hXgFasZHM+LGTUGN3x4hjpbzKpzKNv8PAS7rifJ9NNWaei1yoQBta2/lenHW0u9HghgJ2foQ X-Forefront-PRVS: 02951C14DC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39450400003)(39400400002)(39840400002)(39850400002)(13464003)(1076002)(110136004)(38730400002)(3846002)(33716001)(83506001)(6116002)(229853002)(2906002)(5009440100003)(9686003)(55016002)(53936002)(6496005)(23726003)(50986999)(76176999)(6862004)(42186005)(81166006)(305945005)(33656002)(6246003)(54356999)(7736002)(8676002)(4326008)(25786009)(5660300001)(6636002)(4001350100001)(6666003)(42882006)(2950100002)(189998001)(47776003)(50466002)(66066001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:kzFXgLjpjREahvEfFEBi0KJGkBTR6AvCAyxxOCF?= =?us-ascii?Q?zTl3wYoe8s8Oqga3JF431C0MWIiqNVa9xtx98gj567tv81P6NyYtAPKXiIaZ?= =?us-ascii?Q?Mn+P6uZAXTL+/wNyuCPqeRtT4qX3w6iUicfofszPgxvbQA2fLPblPgXMS0l9?= =?us-ascii?Q?6QMF6suyKnaxqWa7SsEftWwZhCIR5hzjRLMLq323SoAWjGhmTNuLEhzMC6Q/?= =?us-ascii?Q?ZEvK8RV0Lg26j3ZkjpIdzB8uU9sC0KwGyibtyFipbii6nTN0FSAZ4izL1Zly?= =?us-ascii?Q?MUGJiDSsB+5EsWCYzQ2eQdQKh5Rb6FOsi4Op7Dcvy/D2ylQRX3f0148qd8ZS?= =?us-ascii?Q?3BMrSNDFlaHWEhGjtaejdUZLJ438WxWIlkYqa7Gi0Vxyi1ABF7Qkm0QTNY+O?= =?us-ascii?Q?6DeK8qSE5Y3CC1P5cUhc4P/RlZCL1agWwbTlyuPAaagQyvwYfsM1XP1HwR61?= =?us-ascii?Q?ROl5gtOjRh6tTYsXYPKBKJUmgqkOr4gWWEIu/QE+UF8Y8MnSsSdvG7YJGXUL?= =?us-ascii?Q?/3FhoPJqtOk9lS0LTawBYySDtQTorC45Bo4qHtqvc9AE8rDOrGnmTSS7WxQ2?= =?us-ascii?Q?/RHj1O/uCIQtL4kHk+PQa0b4N/m8UczetaePyAk/w7N9/DMHjNOjAlGwWvAH?= =?us-ascii?Q?qCxwCNhmo62/avbnDLiwISsoou/G59y0TwQUpOUtpUfvITYxf2ciuFPDDNWY?= =?us-ascii?Q?ocdDQvscUv2oaKvMiOgEnKAGV9AR1v9Zzhg4BBMs9VB/9k3J4mhk00mbhGFm?= =?us-ascii?Q?bm5ipFpN3DctQbxbx2Qr7bCWWGDJvFn/gTk904Lt8q/lvptCVN57ftcJdyV2?= =?us-ascii?Q?s71ouw4iQIACTyU1uGjGQZfEKN8kRFIc3XQtECPTUu+DjMOFuhr+e5LewssE?= =?us-ascii?Q?hAMMFhjpyFneMIRBrhO7DSL9PH5XLJivdgicE8BcgSG+QDuSfSEihqk0dR6I?= =?us-ascii?Q?Axfgp3zFlG9jTujyOj8+Xqv8lrilW1n03hYj8+54LQXoLMnEcuflnugYjwi6?= =?us-ascii?Q?lsLcskAU6aca00Zg7XLjBdownnEgiU/TsYGQrAtUzzBX25sv0Tq7FMeP2xyl?= =?us-ascii?Q?Fp4mf9mpDeWuwFjl0RaUFUo+lrVZOcHkqK8K/3DiBDdHrz08fOuCt2n8g+TM?= =?us-ascii?Q?7KoPQTOV8brGx3meOakUOEka8vQMPojCGOu+sRagu+5EXkTICe4FYU5dpa37?= =?us-ascii?Q?XtS0dzFXeIuiNVtA=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:/6vpwjrP530ylqf/+iVoEicwaAToXalgn8Nh50cIKKsAiPWHJnhbWSQgY2ncmtVSsIYm+7RatDFYZpR4CHPd+aoZJy7Cwge7BNRkqawAUf+Q91DNPU4WJS+oPaZn5/UMak55zlHlYArvrDbqYkvGRRuAjAk5N16pA/CGupjT6I2kirYgfpG48Kr0YETgz7wkJ1wcWsHyf6IOCuf2087epBr72ooMEUT3KUkXRjoIUDjD+V9sHnmFb8pGpTiEWoDX5w1yaux4FwHyz36cIYayaIOccNPD17z1cd368ZSp6uCUb+HRVGljmx2gYc0gU0ADmxG7rtEH9jNMucP7VDJ35SV6kjRCIetdO6DgKP9Pirk8Ms+cO+ZmMbq/Fox3kE7Bw0w0oibcFgx2F33xqddnfZ9Hw6IRr9Sz1zc/4TnvoRNYiA36sJE0SHmUtbxHzsa04TpPBdD2Zs1KmhxCdtqFtelbwM/yM8Np0xREgGcqMD8yUfIJta7Y7ElYM5iocR/Ir/G66S7YiE6GLjkLw6JTLA==; 5:iRe5NLLTqM7kSDtayFnjjy7IGtZD/5wjw7JGnWiJ8SuIwBG35wR5vi/H3LBBUB7/9QlZZNlSWCFeYTdQg+bIDdsHbn9cIcdlv7PwZUsCuZum9meNdDYEj1cUWIO0Q35NqmIzIaQRCfSmUPmobsmFZgzzs0+eXdX+KpSHe8u20lM=; 24:FE+wMIenltVazW3TMoHh7XO6z3hCJZqiOcJAuADEp/J8POz7YzGYM2rXHFboTxXW3Ek9wDVwVk5bnpEFFvKB9p0EYV6sRhD3PMrURVR/zIs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:URFzAQVtyn+Q5r61rHVsv+lXPzVl2waj9RIdV5tXcBjE+ZbDlcB/VchfbHeDPFUZr4D2ZgbbT59bXpge6mz+H/LnqiCZ01J128PO4fLnjV7RlpcKponiJUmN7/rUYc//47NRadycRtqYxJFYbUY+p1pDVJQtltS7uoUGc44SUiJlzOjHkGHO5QeGv3hqoUqWNR8A0f8Wyf/75Rf9E62+6V+qtribqc2Jv56Figqun6IJJ8P2N+Q/snb/WB6I6GqOd0DWDqiTRJ4G0yXIoCvPU2lU/2eG11WIzUHdHGGhnt171mC/PbVvPRedwTjtYvdMKf9J+QkMxbKnNDh1WfCEbA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2017 06:41:18.2508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH v3] efd: support lookup using neon intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 06:41:24 -0000 -----Original Message----- > Date: Mon, 1 May 2017 22:59:53 -0700 > From: Ashwin Sekhar T K > To: byron.marohn@intel.com, pablo.de.lara.guarch@intel.com, > jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org > Cc: dev@dpdk.org, Ashwin Sekhar T K > Subject: [dpdk-dev] [PATCH v3] efd: support lookup using neon intrinsics > X-Mailer: git-send-email 2.13.0.rc1 > > * Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 > specific definitions > * Verified the changes with efd_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > --- > v2: > * Slightly modified the content of the commit message body > * Added prefix [dpdk-dev] to the email subject line > > v3: > * Moved enum 'EFD_LOOKUP_NEON' under '#if defined(RTE_ARCH_ARM64)' > > MAINTAINERS | 1 + > lib/librte_efd/rte_efd.c | 24 +++++++++++++ > lib/librte_efd/rte_efd_arm64.h | 76 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 101 insertions(+) > create mode 100644 lib/librte_efd/rte_efd_arm64.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index b6495d2..7d708ae 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -147,6 +147,7 @@ F: lib/librte_eal/common/include/arch/arm/*_64.h > F: lib/librte_acl/acl_run_neon.* > F: lib/librte_lpm/rte_lpm_neon.h > F: lib/librte_hash/rte*_arm64.h > +F: lib/librte_efd/rte*_arm64.h > F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > F: drivers/net/i40e/i40e_rxtx_vec_neon.c > F: drivers/net/virtio/virtio_rxtx_simple_neon.c > diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c > index f601d62..5cc6283 100644 > --- a/lib/librte_efd/rte_efd.c > +++ b/lib/librte_efd/rte_efd.c > @@ -53,6 +53,8 @@ > #include "rte_efd.h" > #if defined(RTE_ARCH_X86) > #include "rte_efd_x86.h" > +#elif defined(RTE_ARCH_ARM64) > +#include "rte_efd_arm64.h" > #endif > > #define EFD_KEY(key_idx, table) (table->keys + ((key_idx) * table->key_len)) > @@ -103,6 +105,9 @@ allocated memory > enum efd_lookup_internal_function { > EFD_LOOKUP_SCALAR = 0, > EFD_LOOKUP_AVX2, > +#if defined(RTE_ARCH_ARM64) > + EFD_LOOKUP_NEON, > +#endif I think, we can remove this ifdef to - Make code looks clean - In future, in some case a new enum value gets added then the value will be different for each build. Any valid point to keep under RTE_ARCH_ARM64? > EFD_LOOKUP_NUM > };