From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B2B6C58D1; Wed, 3 May 2017 03:49:50 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2017 18:49:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,282,1491289200"; d="scan'208";a="81760336" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 02 May 2017 18:49:43 -0700 Date: Wed, 3 May 2017 09:46:01 +0800 From: Yuanhan Liu To: Wei Dai Cc: wenzhuo.lu@intel.com, thomas@monjalon.net, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, maxime.coquelin@redhat.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170503014601.GC3005@yliu-dev.sh.intel.com> References: <1493525507-56304-1-git-send-email-wei.dai@intel.com> <1493729065-17090-1-git-send-email-wei.dai@intel.com> <1493729065-17090-2-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493729065-17090-2-git-send-email-wei.dai@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 01:49:51 -0000 On Tue, May 02, 2017 at 08:44:23PM +0800, Wei Dai wrote: > Some customers find adding MAC addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > Following acknowledgements are from specific NIC PMD > maintainer for their managing part. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org Just a note, this patch changes API. It should not be backported to a stable/LTS release, even though it fixes something. --yliu