From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 35F33F72; Mon, 8 May 2017 11:05:51 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2017 02:05:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,308,1491289200"; d="scan'208";a="258246515" Received: from debian.sh.intel.com (HELO debian) ([10.239.67.137]) by fmsmga004.fm.intel.com with ESMTP; 08 May 2017 02:05:48 -0700 Date: Mon, 8 May 2017 17:07:36 +0800 From: Tiwei Bie To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20170508090736.GA11935@debian> References: <20170507133334.16219-1-tiwei.bie@intel.com> <20170507133334.16219-2-tiwei.bie@intel.com> <20170508085501.GB47408@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170508085501.GB47408@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix ioport write operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2017 09:05:52 -0000 On Mon, May 08, 2017 at 09:55:01AM +0100, Bruce Richardson wrote: > On Sun, May 07, 2017 at 01:33:33PM +0000, Tiwei Bie wrote: > > The first param of out*() on FreeBSD is port, and the second one is > > data. But they are reversed in DPDK. This patch fixes it. > > > > Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc: > > stable@dpdk.org > > > > Signed-off-by: Tiwei Bie --- > How was this bug discovered so that we can verify that it is fixed?. Is > this in use by virtio or was it just discovered via code inspection? > The virtio PMD in legacy mode doesn't work FreeBSD, and I tried to fix this issue. And then I found this bug. Best regards, Tiwei Bie